Unable to run mvn -Pspringcheck install

[gokceng1]

Hello I want to contribute to code base but couldn't run install on the fresh check-out in first place.


There are some errors on classes that have imports like:

import static com.googlecode.catchexception.CatchException.catchException;
import static com.googlecode.catchexception.CatchException.caughtException;
‍‍‍‍

or

import bitronix.tm.BitronixTransactionManager;
import bitronix.tm.resource.jdbc.PoolingDataSource;
‍‍‍‍

Those classes are under

activiti-spring‍

module and there is no problem when I use

-Pcheck‍

flag with install.
But using

-Pspringcheck‍

causes dependency problems because neither

com.googlecode.catch-exception:catch-exception‍

nor

org.codehaus.btm:btm‍

dependencies are defined in activiti-spring/pom.xml file. After adding them the profile runs with some test errors.

What should I do to solve this problem?
I'm using Intellij Idea, JDK 1.6.45 and Maven 3.2.2. The guide says Mavewn 3.0.4 should be used but I'm not sure if this can cause this.

[gokceng1]

I see that locale difference(TR/EN) causes some test errors.
For example <java>org.activiti.examples.bpmn.servicetask.JavaServiceTaskTest#testJavaServiceDelegation</java> under <code>activiti-spring</code> module; assertion checks the return value with "ACTIVITI BPM ENGINE" but there is a <b>I</b> character in Turkish with dot: <b>İ</b>. So the return value is:"ACTİVİTİ BPM ENGİNE" and this assertion fails.

I suggest <code>maven-surefire-plugin</code> can be used with vm parameter <code>user.language=en</code>.

[jbarrez]

Running -Pcheck is enough for pull request.
The errors are very odd - these should be publicly available jars. Im quite puzzled why you are running into these errors :ss

> I suggest maven-surefire-plugin can be used with vm parameter user.language=en.

Feel free to add that fix in (you know how to do pull request, so it'll be another one you can add to your list of contributions 😉

[gokceng1]

Thank you for your kind reply Joram.
I don't know why I'm facing these. I thought first about Intellij/Maven but using command line mvn gave those errors, too.

Feel free to add that fix in

I've created a pull request #375.
Finally I managed to run with <code>-Pcheck,springcheck</code> without test errors using these changes, but I had to add those 2 dependencies locally.
Thank you.