Support multiple tabs

[ndup0nt]

As you know, Vaadin versions before 7 do not support multiple tabs/windows.

I saw a commented block related to this in ExplorerApp.class :
<blockcode>
  /**
   *  Required to support multiple browser windows/tabs,
   *  see http://vaadin.com/web/joonas/wiki/-/wiki/Main/Supporting%20Multible%20Tabs
   */
//  public Window getWindow(String name) {
//    Window window = super.getWindow(name);
//    if (window == null) {
//      window = new Window("Activiti Explorer");
//      window.setName(name);
//      addWindow(window);
//      window.open(new ExternalResource(window.getURL()));
//    }
//
//    return window;
//  }
<blockcode>

Why is it commented ? Did you encounter any issue with supporting multiple tabs ?

[ndup0nt]

Why is it commented ? Did you encounter any issue with supporting multiple tabs ?

[jbarrez]

If you ever want to know why something was done, you can use the git blame: https://github.com/Activiti/Activiti/blame/master/modules/activiti-explorer/src/main/java/org/activi...

It's in there since the first version (2011), and I seem to remember it didn't work as advertised.