Issue with noRetriesLeft query

[bam]

Hello everybody,

My job query where I'm trying to select all jobs having no retries (in error) doesn't return the expected results.
Many results contains jobs having retries actually.

I've looked a bit on how the JobQuery works, and I'm wondering if something is not missing in Activiti :


in Job.xml, there is :

<if test="retriesLeft">
    and RES.RETRIES_ &gt; 0
</if>
‍‍‍‍‍

but I don't see any equivalent for noRetriesLeft. I would I've thought something like :

<if test="noRetriesLeft">
    and RES.RETRIES_ = 0
</if>
‍‍‍‍‍

Is this indeed a bug in Activiti Engine ?

Thanks,
Regards.

[bam]

And I'm really struggling with GitHub, can't do a proper pull-request. from my fork on bricefuji/Activiti…

[trademak]

Good catch. That was indeed not correctly implemented and I've fixed it on Github master now.

Thanks,