Intermediate timer event

[mproch]

Hello,

I implemented intermediate (catching) timer event - http://jira.codehaus.org/browse/ACT-641, I committed the code to my branch so far. I'd like to ask if there are special testcases I should add to make sure it doesn't break things (extend MultiInstanceTest?) - so far I have simple test showing it's working - https://svn.codehaus.org/activiti/activiti/branches/mproch/modules/activiti-engine/src/test/java/org...

[jbarrez]

Maciek,

Could you elaborate how you implemented it? I'm assuming you create a Job when execution arrives in the event.
When the job fires, it should just signal the wait state.

I don't see pitfalls regarding testing, since there is no interaction with the execution tree. Multi instance should also just work.

[bernd_ruecker]

Cool, the BPMN coverage increases step by step 🙂

[mproch]

Joram,
yes, I create job when execution reaches this activiti - in the same way as in boundary event.
I added appropriate JobHandler, which signals waiting Activity - I added new ActivityBehaviour for that, since I didn't find any appropriate type - ReceiveTaskActivityBehaviour does basically the same, but I think it wouldn't be correct to use TaskActivity for that.

The timer definition is parsed the same way as it's done for boundary event.

So it's all pretty simple and I also don't see any pitfalls, but wanted to ask before doing any commits, since it's part of 'core' engine and I don't want to break anything

[jbarrez]

Sounds OK. Feel free to commit it.

[tombaeyens]

Kudo's Maciej.
Much appreciated!