DBSqlSessionFacotry forcing commit

[frederikherema1]

Hi Team,

Anyone an idea why SqlSession.commit(boolean force) is called with argument true, in eg. DbSqlSessionFactory.dbSchemaCheckVersion, instead of the default commit()?
The commit() on DefaultSQLSession will check the autocommit-flag and won't commit when it is on. Forcing just ignores this flag, resulting in an exception.

If there is no particular reason for forcing, I'll use the default commit() instead.

[tombaeyens]

we're talking about these code pieces in DbSqlSessionFactory

    } finally {
      if (success) {
        sqlSession.commit(true);
      } else {
        sqlSession.rollback(true);
      }
      sqlSession.close();
    }
do you know a reason why we should not change that to

    } finally {
      if (success) {
        sqlSession.commit();  // default force is false
      } else {
        sqlSession.rollback();   // default force is false
      }
      sqlSession.close();
    }
?