ProcessInstance.isEnded() returns false

[frauke]

How can it be that processInstance.isEnded() does not return true if the process terminated?
What did I do wrong?
This is the process definition:

<process id="testProcess1" name="Test Process">
    <startEvent id="startTest" />
    <sequenceFlow id="flow1" sourceRef="startTest" targetRef="t1" />
    <userTask id="t1" name="T1" />
    <sequenceFlow id="flow2" sourceRef="t1" targetRef="t2" />
    <task id="t2" name="T2"/>
    <sequenceFlow id="flow3" sourceRef="t2" targetRef="ready" />
    <endEvent id="ready" />
</process>
‍‍‍‍‍‍‍‍‍‍‍

The test fails and the processInstance still holds activity 'T1':

        ProcessInstance processInstance = processEngine.getRuntimeService()
            .startProcessInstanceByKey("testProcess1");
        Task task = processEngine.getTaskService().createTaskQuery()
            .processInstanceId(processInstance.getId())
            .singleResult();
        processEngine.getTaskService().complete(task.getId());
        assertEquals(true, processInstance.isEnded());
‍‍‍‍‍‍‍‍‍

Frauke

[falko_menge]

Abstract BPMN 2.0 Tasks like T2 are by definition not executable. Could you try turning T2 into a User Task or Service Task?

[frauke]

Yes, thank you, I changed the task into a service task, but the behaviour is still the same.
The process instance does not "end" and still holds task T1.

[frauke]

Ok, wait a minute…
I now put a system out message into the service task's behaviour class and that prints its message.
That means, T2 is executed, but still the process instance doesn't end.

No, I did not forget to call performDefaultOutgoingBehavior()  

[frederikherema1]

Frauke,

A ProcessInstance is actually a snapshot of the ProcessInstance state at the moment (in your case, when processInstance was created and encountered the first wait-state).

To have a fresh state of the instance, query it using
runtimeService.createProcessInstanceQuery().processInstanceId(processInstance.getId()).singleResult()
In your case the process instance has already ended, the returned processInstance will be null. It is present in the activiti history (if enabled).
historyService.createHistoricProcessInstanceQuery().processInstanceId(processInstance.getId()).singleResult()

[frauke]

Oh great, thank you, Frederik.
So I indeed learned something! (I am quite new at the Activiti business)

Best regards
Frauke

[thetoolman]

If a process instance is archived to the history, when can you ever get myPI.isEnded() to return true ?

[ronald_van_kuij]

you can't.

[thetoolman]

you can't.

so that method should be called .returnFalseAlways()

[ronald_van_kuij]

you can't.

so that method should be called .returnFalseAlways()

No, certainly not. It should be .neverReturnTrue(). But yes it looks kind of strange. Internally it isn't though since if it is ended it is not in the runttime tables anymore