BpmnDeployer - 'incorrect' resourceName.

[gwt_inter]

Hi All,

please consider to add WARN message to org.activiti.engine.impl.bpmn.deployer.BpmnDeployer.

To be more concrete (version 5.7, line 65-…):

 …    if (resourceName.endsWith(BPMN_RESOURCE_SUFFIX)) {        ResourceEntity resource = resources.get(resourceName);        byte[] bytes = resource.getBytes();        ByteArrayInputStream inputStream = new ByteArrayInputStream(bytes);…} else {   LOG.warn("You need to provide resource name that ends with  " + BPMN_RESOURCE_SUFFIX + " Resource " + resourceName + " is not processed.");}        ‍‍‍‍‍‍‍‍‍‍‍‍‍

Or at least think about update of javaDoc at org.activiti.engine.repository.DeploymentBuilder.addInputStream(String, InputStream).

You can save quite a lot of time (I believe) to many activiti users (http://forums.activiti.org/en/search.php?keywords=addInputStream).

Thanks.

[frederikherema1]

You can add any resources you want (.form, .png, …), that's why it's not documented in the javadoc AND no warning is logged in the BPMN-parser since it gets all resources thrown at him.


The userguide alse states this (http://www.activiti.org/userguide/index.html#N106B0😞

When a business archive is deployed, it is scanned for BPMN files with a .bpmn20.xml extension. Each of those will be parsed and potentially contains multiple process definitions.

[gwt_inter]

Thanks for your reply.

Use Case:

* I want to deploy BMPN definition file.

** I put "myProcessDefinition" as a resourceName argument.
** I provide some.xml file as an InputStream.

* Result:
Nothing is deployed, no warning, no error.

I get why it is like that.

It just makes no sense to me that BpmnDeployer deploys any resource so it is clear that it can't "scream" that there is
something wrong with resource name.

Maybe it will be good to split BmpnDeployer to real BpmnDeployer definition and BpmnDeployer resource.
Or something "above" deployer (?) in case of zipped bundles.

Thanks

[jbarrez]

The thing that Frederik is trying to make clear: what if you actually want to upload xml files (eg a custom form).
The BPMNDeployer cant guess whether it should warn or not.