NumberFormatException when editing 5.3 activiti diagram

[tstephen]

Hi,

I created a .activiti file in designer release 5.3. The ids were automatically assigned to userTaskX, gatewayY etc. where X and Y are incrementing integers. Because these ids are used as the activity ids in the generated .bpmn20.xml file they are not really private to Designer. I opened the .activiti file in an XML editor and did a global search and replace for more typical Java-style names (e.g. performAction). When I reopened the .activiti file in the the 5.3 Designer it was happy with this and I could continue editing ok. However in 5.4 Designer it seems I cannot. The exception is at the end.

I think that the id that ends up in the BPMN file should be editable by the user. I can see this may pose problems for Designer so perhaps there should be an additional internalId private to the .activiti file? Also I note that the id field is editable in 5.4 though the edit is never committed to the .activiti file.

Tim

java.lang.NumberFormatException: For input string: "reviewMinutes"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:449)
at java.lang.Integer.valueOf(Integer.java:554)
at org.activiti.designer.eclipse.util.ActivitiUiUtil.getNextId(ActivitiUiUtil.java:222)
at org.activiti.designer.features.AbstractCreateBPMNFeature.getNextId(AbstractCreateBPMNFeature.java:28)
at org.activiti.designer.features.CreateUserTaskFeature.create(CreateUserTaskFeature.java:29)
at org.eclipse.graphiti.features.impl.AbstractCreateFeature.execute(AbstractCreateFeature.java:100)
at org.eclipse.graphiti.internal.command.GenericFeatureCommandWithContext.execute(GenericFeatureCommandWithContext.java:64)
at org.eclipse.graphiti.internal.command.GFPreparableCommand.doExecute(GFPreparableCommand.java:37)
at org.eclipse.emf.transaction.RecordingCommand.execute(RecordingCommand.java:135)
at org.eclipse.graphiti.ui.internal.editor.GFWorkspaceCommandStackImpl.execute(GFWorkspaceCommandStackImpl.java:52)
at org.eclipse.emf.transaction.impl.AbstractTransactionalCommandStack.execute(AbstractTransactionalCommandStack.java:219)
at org.eclipse.graphiti.ui.internal.editor.GFWorkspaceCommandStackImpl.execute(GFWorkspaceCommandStackImpl.java:39)
at org.eclipse.graphiti.internal.command.CommandExec.executeCommand(CommandExec.java:74)
at org.eclipse.graphiti.ui.internal.command.CreateModelObjectCommand.execute(CreateModelObjectCommand.java:52)
at org.eclipse.graphiti.ui.internal.editor.EmfOnGefCommand.execute(EmfOnGefCommand.java:58)
at org.eclipse.graphiti.internal.command.GFPreparableCommand2.doExecute(GFPreparableCommand2.java:37)
at org.eclipse.emf.transaction.RecordingCommand.execute(RecordingCommand.java:135)
at org.eclipse.emf.workspace.EMFCommandOperation.doExecute(EMFCommandOperation.java:119)
at org.eclipse.emf.workspace.AbstractEMFOperation.execute(AbstractEMFOperation.java:150)
at org.eclipse.core.commands.operations.DefaultOperationHistory.execute(DefaultOperationHistory.java:511)
at org.eclipse.emf.workspace.impl.WorkspaceCommandStackImpl.doExecute(WorkspaceCommandStackImpl.java:208)
at org.eclipse.emf.transaction.impl.AbstractTransactionalCommandStack.execute(AbstractTransactionalCommandStack.java:165)
at org.eclipse.graphiti.ui.internal.editor.GFWorkspaceCommandStackImpl.execute(GFWorkspaceCommandStackImpl.java:47)
at org.eclipse.emf.transaction.impl.AbstractTransactionalCommandStack.execute(AbstractTransactionalCommandStack.java:219)
at org.eclipse.graphiti.ui.internal.editor.GFWorkspaceCommandStackImpl.execute(GFWorkspaceCommandStackImpl.java:39)
at org.eclipse.graphiti.ui.internal.editor.GFCommandStack.execute(GFCommandStack.java:108)
at org.eclipse.gef.tools.AbstractTool.executeCommand(AbstractTool.java:426)
at org.eclipse.gef.tools.AbstractTool.executeCurrentCommand(AbstractTool.java:443)
at org.eclipse.gef.tools.CreationTool.performCreation(CreationTool.java:266)
at org.eclipse.gef.tools.CreationTool.handleButtonUp(CreationTool.java:186)
at org.eclipse.gef.tools.AbstractTool.mouseUp(AbstractTool.java:1206)
at org.eclipse.gef.EditDomain.mouseUp(EditDomain.java:301)
at org.eclipse.gef.ui.parts.DomainEventDispatcher.dispatchMouseReleased(DomainEventDispatcher.java:380)
at org.eclipse.draw2d.LightweightSystem$EventHandler.mouseUp(LightweightSystem.java:548)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:213)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3552)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3171)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

[trademak]

Hi,

This problem is solved in the trunk.
I also created a new archived update site that has these fixes in it at http://www.activiti.org/designer/archived/activiti-designer-5.4.1.zip.

Best regards,

[tstephen]

Thanks. The archived update site has a couple of problems…
- The site.xml is in a sub-folder site so by default Eclipse won't find it. I got past this by modifying the URL is creates from the file picker to be jar:file…..jar!/site/site.xml. (The bold bit is what I had to add)
- Although the zip is numbered 5.4.1 the feature bundle and xml file still say 5.4.0 so Eclipse won't let me install it over the existing 5.4.0.

I realise I could install in a fresh Eclipse or even overwrite the existing files but I think for now I'll wait. Let me know if you put together an updated archive site.
Tim

[trademak]

Hi,

The update site works fine if you install it with the local update site functionality in the install software wizard of Eclipse. Did you use the archive option?
You are right that the version is still 5.4.0, so you have to install it to a fresh Eclipse.
Version 5.5.0 will have a new version number.

Best regards,