Activiti Explorer uses not stalbe AbstractFormType Class

[udoderk]

The stable org.activiti.explorer.form.UserFormType uses not a stable AbstractFormType class.

Hi, Today I found out what can happen when you do not use stable activiti classes from impl packages: the ant deploy classes were in 5.11 removed.

Currently in my code is inherited from a non-stable class: org.activiti.engine.impl.form.AbstractFormType, that has 3 methods

  public abstract Object convertFormValueToModelValue(String propertyValue);

  public abstract String convertModelValueToFormValue(Object modelValue);

  public Object getInformation(String key) {
    return null;
  }‍‍‍‍‍‍‍

That AbstractFormType implements the org.activiti.engine.form.FormType interface, that has only

  String getName();

  Object getInformation(String key);‍‍‍

I use the impl class, because the org.activiti.explorer.form.UserFormType uses it too and i'm not found  otger better solutions :shock: I builded my code using UserFormType as example.


The question is whether it is planned to offer the public stable interface, so that someone in the future does not get the problems that today someone get with ant as example.

[jbarrez]

You are correct, there is no reason why that class should be in the impl package, especially since the internal PropertyHandler class depends on it.

Moved it next to the FormType interface: https://github.com/Activiti/Activiti/commit/23a9393118b706fd5f2dafc21fa4572dd7d4948e