topic Why does copyContents() method of documentModelImpl class ignore a metaData change if its value has been removed from the source document. in Nuxeo Forum

Why does copyContents() method of documentModelImpl class ignore a metaData change if its value has been removed from the source document.

Swaminathan_Jay — Fri, 13 May 2016 21:30:43 GMT

Why does copyContents ignore a metaData change if its value has been removed from the source document.

https://github.com/nuxeo/nuxeo/blob/master/nuxeo-core/nuxeo-core-api/src/main/java/org/nuxeo/ecm/core/api/impl/DocumentModelImpl.java#L1210

I see that while calling the copyContents method, if the dataModel encounters a empty or null value, it moves ahead without replacing the destination field with the NULL value.

Was there any specific reason for doing like this? I thought of modifying the underlying logic. But i m not able to build and replace the NUXEO_CORE_API jar in my local bundles folder.

Changed copyContents() method can be found below

public static DataModel cloneDataModel(Schema schema, DataModel data) {


DataModel dm = new DataModelImpl(schema.getName());


for (Field field : schema.getFields()) {


String key = field.getName().getLocalName();


Object value;


try {


value = data.getData(key);


} catch (PropertyException e1) {


continue;


}


Object clone =null;


  


if (value != null) {


clone = cloneField(field, key, value);


}


try {


dm.setData(key, clone);


} catch (PropertyException e) {


throw new ClientRuntimeException(e);


}


}


return dm;


}

Re: Why does copyContents() method of documentModelImpl class ignore a metaData change if its value has been removed from the source document.

Florent_Guillau — Wed, 18 May 2016 09:41:46 GMT

Hi. Could you provide a unit test that demonstrates why in your opinion the current behavior is wrong? We use copyContent to copy data from an existing DocumentModel into a newly-created empty one, so the current behavior is correct in my opinion.

Re: Why does copyContents() method of documentModelImpl class ignore a metaData change if its value has been removed from the source document.

Swaminathan_Jay — Wed, 18 May 2016 16:46:08 GMT

I don't have a unit test handy. You are correct. As per the Current behavior, the data gets copied over without any issues into a new empty document.