topic Re: Configuring transaction manager for activiti process engine. in Alfresco Archive

Configuring transaction manager for activiti process engine.

susubhas — Fri, 22 Feb 2013 10:52:48 GMT

Hi,In my application i have transactionManager already defined which is either JTA or Hibernate transaction manager depending on which server the app will be deployed on. I have configured SpringProcessEngineConfiguration to use this transactionManager, but activiti doesn't reuse existing transactio

Re: Configuring transaction manager for activiti process engine.

jbarrez — Fri, 22 Feb 2013 11:16:15 GMT

What does your activiti config look like? Without it, we can only guess.

Re: Configuring transaction manager for activiti process engine.

susubhas — Sun, 24 Feb 2013 06:55:54 GMT

Hi jbarrez,

Spring activiti config file is pasted below. Here "txManager" is the HibernateTransactionManager which is created on the datasource looked up below.

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:jee="http://www.springframework.org/schema/jee"
       xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-2.0.xsd http://www.springframework.org/schema/jee http://www.springframework.org/schema/jee/spring-jee-3.0.xsd">

    <import resource="Spring.core.beans.xml"/>
    <bean id="dataSource" class="org.springframework.jdbc.datasource.TransactionAwareDataSourceProxy">
        <property name="targetDataSource">
            <jee:jndi-lookup id="dbDataSource"
                jndi-name="@jndi-name@"
                />
        </property>
    </bean>

    <bean id="processEngineConfiguration" class="org.activiti.spring.SpringProcessEngineConfiguration">
        <property name="databaseType" value="@db-type@" />
        <property name="dataSource" ref="dataSource"/>
        <property name="transactionManager" ref="txManager" />
        <property name="databaseSchemaUpdate" value="false" />
        <property name="historyLevel" value="ACTIVITY"/>
        <property name="preParseListeners">
            <list>
                <bean class="com.dev.sdp.core.workflow.listeners.SDPBpmnParseListener"/>
            </list>
        </property>
    </bean>

    <bean id="processEngine" class="org.activiti.spring.ProcessEngineFactoryBean">
        <property name="processEngineConfiguration" ref="processEngineConfiguration" />
    </bean>
    <bean id="repositoryService"
        factory-bean="processEngine"
        factory-method="getRepositoryService" />
    <bean id="runtimeService"
        factory-bean="processEngine"
        factory-method="getRuntimeService" />
    <bean id="taskService"
        factory-bean="processEngine"
        factory-method="getTaskService" />
    <bean id="historyService"
        factory-bean="processEngine"
        factory-method="getHistoryService" />
    <bean id="managementService"
        factory-bean="processEngine"
        factory-method="getManagementService" />
</beans>

Rgds,
Sujata

Re: Configuring transaction manager for activiti process engine.

araghuraman — Sun, 24 Feb 2013 17:12:21 GMT

Perhaps a new transaction is required because it does not want you to tie your business logic (short transaction)
with its own transaction (long transaction). If you want to execute the workflow process in a transactional way, have you tried using transaction sub process with compensation handlers?

Re: Configuring transaction manager for activiti process engine.

susubhas — Mon, 25 Feb 2013 05:22:38 GMT

It not during process runtime, its during process deploying. I am trying to deploy multiple process definitions(not using .Bar purposely because i want a deploymentId for each processDefinition), in one call and i am expecting if the deployment of one process definition fails also all the other deployments should rollback which is not happening now.

Rgds,
Sujata

Re: Configuring transaction manager for activiti process engine.

susubhas — Mon, 25 Feb 2013 09:57:23 GMT

Any Solution for the above issue???

Re: Configuring transaction manager for activiti process engine.

jbarrez — Mon, 25 Feb 2013 14:43:09 GMT

I am trying to deploy multiple process definitions

How are you doing that? In a method marked with @Transactional?

Re: Configuring transaction manager for activiti process engine.

susubhas — Tue, 26 Feb 2013 00:33:32 GMT

Yes, my method looks like below

@Transactional
public void registerOrUpdateWorkflowDefinition(String barFileUrl)
            throws InvalidArgumentException, WorkflowServiceException
    {
        LOGGER.info("barFileUrl" + barFileUrl);
        Deployment deployment;
        List<String> keys = null;
        try
        {
            if (StringUtil.isEmpty(barFileUrl))
            {
                LOGGER.error("barFileUrlis null or empty");
                throw new InvalidArgumentException(WorkflowServiceErrorCode.ERROR_020001);
            }

            ZipInputStream zipInputStream = new ZipInputStream(new   FileInputStream(SharedFSUtil.getLocalFilePath(barFileUrl)));
            ZipEntry entry = zipInputStream.getNextEntry();
            byte[] buffer = new byte[1024];

            while(entry!=null){
                String newFileName = entry.getName();
                File newFile = new File(newFileName);
                FileOutputStream fos = new FileOutputStream(newFile);
                int len;
                while ((len = zipInputStream.read(buffer)) > 0) {
                    fos.write(buffer, 0, len);
                }
                fos.close();

                repositoryService.createDeployment().addInputStream(newFileName,new FileInputStream(newFile)).deploy();

                entry = zipInputStream.getNextEntry();
            }

        }
        catch (FileNotFoundException fnfExe)
        {
            LOGGER.error("Could not find file at the specified shared location " + fnfExe);
            throw new InvalidArgumentException(WorkflowServiceErrorCode.ERROR_020002);
        }
        catch (ActivitiException aExe)
        {
            LOGGER.error("Unknown error occured during workflow registration " + aExe);
            throw new WorkflowServiceException(aExe.getMessage());
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

Re: Configuring transaction manager for activiti process engine.

jbarrez — Tue, 26 Feb 2013 13:40:55 GMT

It looks all ok.

I tried a simple test that mimics your use case but I couldn't make it fail: see https://github.com/Activiti/Activiti/commit/c4e454c93f0fbf0d74b47e141f808d62682a9d33

Re: Configuring transaction manager for activiti process engine.

susubhas — Wed, 27 Feb 2013 17:01:13 GMT

But in my app i have hibernate, so i am creating HibernateTransactionManager by passing sessionFactory to it. And to activiti i m passing the reference of this transaction manager. I guess activiti creates its own sessionFactory. is it that the transaction manager is only managing the transaction for the sessions which it knows about???

Rgds,
Sujata

Re: Configuring transaction manager for activiti process engine.

jbarrez — Thu, 28 Feb 2013 16:04:56 GMT

And to activiti i m passing the reference of this transaction manager.

That is indeed what is needed.

I guess activiti creates its own sessionFactory.

No, activiti certainly doesn't do that.

is it that the transaction manager is only managing the transaction for the sessions which it knows about???

No, once you pass an external transaction manager, activiti never tries to start or manage a transaction itselfs, it leaves all that to the transaction manager.
The only difference I see is that I didn't define a databaseType … maybe remove that.
Can you extract a very simple unit test that demonstrates the issue, similar to the test I posted above?

Re: Configuring transaction manager for activiti process engine.

susubhas — Fri, 01 Mar 2013 12:42:18 GMT

Hi jbarrez,

I could reproduce the issue on my local machine, will soon upload it to Github.

Rgds,
Sujata

Re: Configuring transaction manager for activiti process engine.

larswillrich — Fri, 01 Mar 2013 15:20:56 GMT

i dont know, but i could not find

<tx:annotation-driven transaction-manager="transactionManager"/>
in your spring xml file… so the @Transaction annotation will be ignored?

Re: Configuring transaction manager for activiti process engine.

jbarrez — Fri, 01 Mar 2013 18:24:36 GMT

Damn, that I didn't see that one … good point, and indeed probably the cause of seeing multiple transactions