topic Difference between DeploymentBuilderImpl.add* methods in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/difference-between-deploymentbuilderimpl-add-methods/m-p/139134#M97517 <HTML><HEAD></HEAD><BODY><SPAN>I have always assumed that the various DeploymentBuilderImpl.add* methods were equivalent but apparently in 5.13 SNAPSHOT they are not (I have not gone back to check earlier versions). </SPAN><BR /><BR /><SPAN>Specifically this deploys correctly: </SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Deployment deployment = createDeployment().addClasspathResource(resource).deploy();<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>and this does not: </SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; String resourceName = "test";<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; InputStream inputStream = ReflectUtil.getResourceAsStream(resource);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; byte[] bytes = IoUtil.readInputStream(inputStream, resourceName);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Deployment deployment = deploy((DeploymentBuilderImpl) createDeployment()<BR />&nbsp;&nbsp;&nbsp;&nbsp; .addString(resourceName, definition.trim()));<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>Note that </SPAN><PRE class="language-none line-numbers"><CODE>resource<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN></CODE></PRE><SPAN> is the same in both cases. To be honest I was already pretty close by the time I figured this out having first spent ages investigating how I must have corrupted the String on the wire somehow!</SPAN><BR /><BR /><SPAN>It all comes down to this line in BpmnDeployer: </SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp; if (isBpmnResource(resourceName)) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; … parse the resource etc..<BR />&nbsp;&nbsp;&nbsp; }<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>Apparently because my resource is named 'test' it will never be parsed or the process definition stored! If I call it 'test.bpmn' all is well. </SPAN><BR /><BR /><SPAN>So what is the intent on this line? I suppose someone was trying to protect against an attempt to parse a non-BPMN resource but if I do feed a garbage string into the parser it gives a pretty reasonable exception (org.activiti.engine.ActivitiException: Error parsing XML). </SPAN><BR /><BR /><SPAN>Anyone object to simply removing the check? </SPAN><BR /><SPAN>Cheers, </SPAN><BR /><SPAN>Tim </SPAN></BODY></HTML> Fri, 17 May 2013 17:32:09 GMT tstephen 2013-05-17T17:32:09Z Difference between DeploymentBuilderImpl.add* methods https://connect.hyland.com/t5/alfresco-archive/difference-between-deploymentbuilderimpl-add-methods/m-p/139134#M97517 I have always assumed that the various DeploymentBuilderImpl.add* methods were equivalent but apparently in 5.13 SNAPSHOT they are not (I have not gone back to check earlier versions). Specifically this deploys correctly: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Deployment deployment = createDeployment().addClasspathResource(resource Fri, 17 May 2013 17:32:09 GMT https://connect.hyland.com/t5/alfresco-archive/difference-between-deploymentbuilderimpl-add-methods/m-p/139134#M97517 tstephen 2013-05-17T17:32:09Z Re: Difference between DeploymentBuilderImpl.add* methods https://connect.hyland.com/t5/alfresco-archive/difference-between-deploymentbuilderimpl-add-methods/m-p/139135#M97518 <HTML><HEAD></HEAD><BODY><SPAN>Hi Tim, sorry for the late response. Really busy lately.</SPAN><BR /><BR /><SPAN>Regarding your problem: yes it has hit me too in the past.</SPAN><BR /><SPAN>The problem is that in theory, you can upload any resource to a deployment (images, word docs, etc.) and they will all be stored in the database for later retrieval.</SPAN><BR /><BR /><SPAN>Maybe is a dedicated, new method, specifically for the process xml is a good solution (not breaking backwards compatibility)?</SPAN></BODY></HTML> Wed, 22 May 2013 09:37:04 GMT https://connect.hyland.com/t5/alfresco-archive/difference-between-deploymentbuilderimpl-add-methods/m-p/139135#M97518 jbarrez 2013-05-22T09:37:04Z