topic Re: SpringJobExecutor cannot be shutdown and started up. in Alfresco Archive

SpringJobExecutor cannot be shutdown and started up.

sangv — Wed, 09 Jan 2013 17:29:33 GMT

Hey Guys,I wanted to understand this before I create a defect. Recently, I moved to using the SpringJobExecutor and found that I could not shut it down and restart it without booting up the process engine again. Ofcourse, I was experiencing this in my unit tests ( jobExecutor.start() in the setup me

Re: SpringJobExecutor cannot be shutdown and started up.

frederikherema1 — Thu, 10 Jan 2013 08:18:55 GMT

I think this is a problem that grew historically. In the beginning, the threadPoolExecutor was not configurable but rather always created internally, using the passed in params for max/core pool sizes. A default ThreadPoolExecutor cannot be started again/reused after shutdown, AFAIK. When the spring-implementation was added, the existing behavior was not altered, rather just built upon.

So you're absolutely right about the fact that (especially in spring-case) it makes no sense to set the executor to null, since it's injected at the beginning, rather than created. The main problem is that the TaskExecutor interface has no start/shutdown methods available, so explicit start/shutdown of the executor is in spring's hands. Now that I look into this, the current implementation (setting task executor to null) doesn't have any effect and cannot guarantee that no jobs will be executed (which were in the executor queue) after job-executor was shut down.

I'll remove the taskExecutor = null call from the codebase…

Re: SpringJobExecutor cannot be shutdown and started up.

sangv — Thu, 10 Jan 2013 14:51:36 GMT

Sounds good (I am assuming that you don't need me to create a JIRA ticket for this, but let me know if otherwise).

Thanks,
Sang

Re: SpringJobExecutor cannot be shutdown and started up.

frederikherema1 — Thu, 10 Jan 2013 14:53:08 GMT

No need for that, it's already pushed to master. Thanks for reporting!

Re: SpringJobExecutor cannot be shutdown and started up.

jdp — Wed, 12 Jul 2017 13:20:28 GMT

Hi,

Is this query resolved ?

if yes, with which version, can I start stop job executor at run time now ?

Thanks,

Paresh