topic Migration to 5.13 issues in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126770#M89166 <HTML><HEAD></HEAD><BODY><SPAN>Hi guys,</SPAN><BR /><BR /><SPAN>I recently upgraded to 5.13 version from 5.11. Since then I encountered a few migration problems, I hope you will be able to clarify them to me:</SPAN><BR /><BR /><SPAN>1. I have been using a custom scripting engine implementation (I was doing some script preprocessing before evaluating it). I registered the engine the following way:</SPAN><BR /><BR /><SPAN>ScriptingEngines scriptingEngines = configuration.getScriptingEngines();</SPAN><BR /><SPAN>if (scriptingEngines == null)</SPAN><BR /><SPAN>{</SPAN><BR /><SPAN>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scriptingEngines = new ScriptingEngines(new ScriptBindingsFactory(rfactories));</SPAN><BR /><SPAN>}</SPAN><BR /><SPAN>configuration.setScriptingEngines(new CustomScriptingEngines(scriptingEngines));</SPAN><BR /><BR /><SPAN>After upgrading to 5.13 the engine ignrores this registration and is only using the default ScriptingEngines implementation.</SPAN><BR /><BR /><SPAN>2. This method org.activiti.bpmn.model.ExtensionElement.getChildElements() returns a map of &lt;String, ExtensionElement&gt; that doesn't allow multiple extension elements with the same name. I temporarily managed by replacing your declaration with </SPAN><BR /><SPAN>protected LinkedMultiValueMap&lt;String, ExtensionElement&gt; childElements = new LinkedMultiValueMap&lt;String, ExtensionElement&gt;();</SPAN><BR /><SPAN>and by adding a getter like this: LinkedMultiValueMap&lt;String, ExtensionElement&gt; getMultiChildElements(), but it's actually a poor quality patch while waiting for your fix. </SPAN><BR /><BR /><SPAN>3. I don't actually feel that the BpmnParseHandler based API fully covers the possibilities of the previous BpmnParseListener approach. After a few hours of fighting with the new API I decided to write my own BpmnXMLConverter implementation (where I handled all custom extensions and build my own task object). And - surprisingly - I find this a very correct and handy approach: I build the task object from XML properties and then pass the complete object to the ParseHandler. It greatly separates parsing logic from the remaining work on the parsed task. The only problem is that I had to register the converters by using reflection. Is there any chance that you make org.activiti.bpmn.converter.BpmnXMLConverter.addConverter method public? </SPAN><BR /><BR /><SPAN>Thanks,</SPAN></BODY></HTML> Wed, 17 Jul 2013 14:03:14 GMT pkromolowski 2013-07-17T14:03:14Z Migration to 5.13 issues https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126770#M89166 Hi guys,I recently upgraded to 5.13 version from 5.11. Since then I encountered a few migration problems, I hope you will be able to clarify them to me:1. I have been using a custom scripting engine implementation (I was doing some script preprocessing before evaluating it). I registered the engine Wed, 17 Jul 2013 14:03:14 GMT https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126770#M89166 pkromolowski 2013-07-17T14:03:14Z Re: Migration to 5.13 issues https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126771#M89167 <HTML><HEAD></HEAD><BODY><SPAN>1) I'll look into the issue with the script-bindings.</SPAN><BR /><BR /><SPAN>2) We're going to resolve this issue indeed, always interested to see how you implemented a workaround.</SPAN><BR /><BR /><SPAN>3) Sure thing, </SPAN><A href="https://github.com/Activiti/Activiti/commit/389bf278a48acfeb367bdcda464292a1a1f3124c" rel="nofollow noopener noreferrer">https://github.com/Activiti/Activiti/commit/389bf278a48acfeb367bdcda464292a1a1f3124c</A></BODY></HTML> Wed, 17 Jul 2013 14:32:24 GMT https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126771#M89167 frederikherema1 2013-07-17T14:32:24Z Re: Migration to 5.13 issues https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126772#M89168 <HTML><HEAD></HEAD><BODY><SPAN>I don't immediately see any code that would replace the scriptingEngines that you're using, UNLESS you're using the OSGI org.activiti.osgi.blueprint.ProcessEngineFactoryWithELResolver -&gt; are you using this?</SPAN><BR /><BR /><SPAN>If not, please reply on this thread so we can look deeper. Any idea what particular part of the code is responsible for throwing away your custom ScriptEngines?</SPAN></BODY></HTML> Wed, 17 Jul 2013 14:38:53 GMT https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126772#M89168 frederikherema1 2013-07-17T14:38:53Z Re: Migration to 5.13 issues https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126773#M89169 <HTML><HEAD></HEAD><BODY><SPAN>As for #1 - I'm lame, sorry for reporting this issue. </SPAN><BR /><SPAN>In 5.11 I was overriding the org.activiti.engine.impl.scripting.ScriptingEngines.evaluate(String, String, VariableScope) method, and in 5.13 it isn't called anymore. When I override org.activiti.engine.impl.scripting.ScriptingEngines.evaluate(String, String, Bindings) - everything works fine. </SPAN><BR /><BR /><SPAN>Thanks.</SPAN></BODY></HTML> Thu, 18 Jul 2013 11:04:34 GMT https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126773#M89169 pkromolowski 2013-07-18T11:04:34Z Re: Migration to 5.13 issues https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126774#M89170 <HTML><HEAD></HEAD><BODY><SPAN>Okay, thanks for letting us know what the issue was eventually.</SPAN></BODY></HTML> Fri, 19 Jul 2013 06:10:03 GMT https://connect.hyland.com/t5/alfresco-archive/migration-to-5-13-issues/m-p/126774#M89170 frederikherema1 2013-07-19T06:10:03Z