topic Re: Transaction rolled back in Alfresco Archive

Transaction rolled back

hbf — Thu, 10 Jan 2008 11:45:46 GMT

Hi,I need some advice from a Spring transaction guru, it seems: I don't get the following to work try { UserTransaction transaction = transactionService.getNonPropagatingUserTransaction(); transaction.begin(); authenticationService.authenticate(LOGIN, PASSWORD.toCharArray());

Re: Transaction rolled back

kevinr — Mon, 21 Jan 2008 17:59:48 GMT

You are pretty much correct. Certain types of runtime exceptions - anything that extends AlfrescoRuntimeException in our case - has been configured to be caught by Spring and will cause the current exception to be marked as rollback. Basically if certain exceptions occur then you will have no choice but to start another transaction. However, InvalidNodeRefException is NOT derived from AlfrescoRuntimeException so i would not think this would cause the problem you are having…

Kevin

Re: Transaction rolled back

hbf — Mon, 21 Jan 2008 19:12:20 GMT

Thank you very much, Kevin, I guess that will help me track this down further: I'll check what exact exception is thrown that caused the roll-back…

In the meantime: How does the Web Client react if its transaction is rolled back? I've made the experience that once this happens, it starts behaving strangely.

Could it be that the Web Client does not check for rolled back transactions and does not start a new transaction?

Which would mean that you have to take the system down and restart to be able to work again.

Kaspar

Re: Transaction rolled back

hbf — Mon, 04 Feb 2008 09:28:09 GMT

I am trying to track down the cause of the problem described in the original post. Does somebody have answer to the following questions?

1. Where exactly is Spring configured to mark a transaction for rollback on AlfrescoRuntimeException?

I've tried

grep  AlfrescoRuntimeException `find HEAD -name '*xml'`‍

without success. Ã¢â‚¬â€œ Is it done via exception catching?

2. I've set a breakpoint on both AlfrescoRuntimeException and InvalidNodeRefException (caught and uncaught) and only the latter breaks for the code in the original post. Still, the transaction gets marked as rollback. Any idea why this could be? In what other way can a transaction be marked as rollback?

3. The strange thing is that after the code from the original post is run in a a webapp running alongside the Web Client, the Web Client itself has a transaction that is marked for rollback Ã¢â‚¬â€œ even though these are different threads! As a consequence, users cannot log in anymore without errors and see this:

An error occurred in one of the dashlets.

    * Failed to get to do tasks: javax.transaction.RollbackException: The transaction has already been marked for rollback
    * Failed to get pooled tasks: javax.transaction.RollbackException: The transaction has already been marked for rollback
    * Failed to get all active tasks: javax.transaction.RollbackException: The transaction has already been marked for rollback
‍‍‍‍‍‍

Is it true that only the current transaction is marked for rollback and not all?

Thanks,
Kaspar

Re: Transaction rolled back

rivarola — Mon, 04 Feb 2008 14:29:28 GMT

Hi Kaspar,

Tu debug this kind of crash, you can set a breakpoint in org.springframework.transaction.support.ResourceHolderSupport, method setRollbackOnly().

Re: Transaction rolled back

hbf — Mon, 04 Feb 2008 17:02:11 GMT

Rivarola, thanks a lot for your kind hint. Using it, I found out the following but Ã¢â‚¬â€œ unfortunately Ã¢â‚¬â€œ am again stuck.

In order to isolate what is going on, I've added the following code to CutNodeEvaluator.java (in Alfresco's SVN code); it is COMPLETE NONSENSE semantically but serves to reproduce the behaviour I am struggling with.


package org.alfresco.web.action.evaluator;

import javax.faces.context.FacesContext;

import org.alfresco.web.bean.repository.Node;
import org.alfresco.web.action.ActionEvaluator;
import org.alfresco.model.ContentModel;
import org.alfresco.service.cmr.dictionary.DictionaryService;
import org.alfresco.service.cmr.repository.NodeRef;
import org.alfresco.service.cmr.repository.NodeService;
import org.alfresco.service.cmr.security.AuthenticationService;
import org.alfresco.service.namespace.QName;
import org.alfresco.service.transaction.TransactionService;
import org.alfresco.web.bean.ml.MultilingualUtils;

import javax.faces.context.FacesContext;
import javax.transaction.UserTransaction;

import org.alfresco.web.app.servlet.FacesHelper;

public class CutNodeEvaluator extends BaseActionEvaluator
{
   public boolean evaluate(Node node)
   {

     // BEGIN for debugging only
     FacesContext fc = FacesContext.getCurrentInstance();

     NodeService nodeService = (NodeService) FacesHelper.getManagedBean(fc, "NodeService");
     TransactionService transactionService = (TransactionService) FacesHelper.getManagedBean(fc, "TransactionService");
     AuthenticationService authenticationService = (AuthenticationService) FacesHelper.getManagedBean(fc, "AuthenticationService");
     try
     {
       UserTransaction transaction = null;
       try
       {
         //transaction = transactionService.getNonPropagatingUserTransaction(); // (**)
         //transaction.begin(); // (**)
         //authenticationService.authenticate("admin", "J8uqw82_".toCharArray()); // (**)
         NodeRef nodeRef = new NodeRef("workspace://SpacesStore/rubbish"); // invalid input
         //int status = transaction.getStatus(); // 0  // (**)
         //System.err.println(status);  // (**)
         nodeService.getProperty(nodeRef, ContentModel.PROP_CATEGORIES);
       }
       catch (Exception e)
       {
         // int status = transaction.getStatus(); // (*)  // (**)
         // System.err.println(status); // (**)
       }
       // transaction.commit();  // (**)
     }
     catch (Exception e)
     {
     }
     // END for debugging only

     // just some dummy return value
     return false;
    }
  }
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

If you build Alfresco using this code and list the contents of a space in the Web Client with a few content nodes, a InvalidNodeRefException will be thrown. This results in a rollback (break on setRollbackOnly() to see this, as Rivarola suggested). But otherwise, you can log in, log out of the Web Client and everything works.

(Kevin: It seems that Spring is not configured to only rollback on AlfrescoRuntimeException but on RuntimeException's or Error's, see org/springframework/transaction/interceptor/DefaultTransactionAttribute.java, method rollbackOn(). At least, in my case, the latter method gets called…)

Nowthe strange behaviour: If you uncomment the 8 lines with (**) and rebuild, the transactions are also rolled back but you cannot log in/log out anymore without errors showing up: The transaction has already been marked for rollback, etc.

What am I doing wrong?

Even stranger: If I do the same in a different Tomcat webapp (implying: in a different thread of Tomcat with its own transactions), it knocks out the Web Client, too! How can this be?

Many thanks,
Kaspar

Re: Transaction rolled back

hbf — Tue, 05 Feb 2008 13:17:05 GMT

I've added a JIRA issue for this and am available if further debugging is needed.

Re: Transaction rolled back

hbf — Wed, 21 May 2008 09:49:25 GMT

Has anybody got an idea how to fix this? We are running into "transaction already marked for rollback" exceptions regularly and after these we cannot log in again, as discussed above. So we have to restart the server which is really annoying.

Thanks for any hint!
Kaspar

Re: Transaction rolled back

hbf — Fri, 27 Jun 2008 13:16:27 GMT

The JIRA issue mentioned above has changed: It is now this issue.

Re: Transaction rolled back

derek — Wed, 08 Oct 2008 12:51:30 GMT

Hi,

I need some advice from a Spring transaction guru, it seems: I don't get the following to work


    try {
      UserTransaction transaction = transactionService.getNonPropagatingUserTransaction();
      transaction.begin();
      authenticationService.authenticate(LOGIN, PASSWORD.toCharArray());
      NodeRef nodeRef = new NodeRef("workspace://SpacesStore/rubbish"); // invalid input
      int status = alfrescoContext.getTransaction().getStatus(); // 0
      nodeService.getProperty(nodeRef, ContentModel.PROP_CATEGORIES);
    }
    catch (Exception e)
    {
      int status = alfrescoContext.getTransaction().getStatus(); // (*)
    }
    transaction.commit();
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

…
Regards,
Kaspar

Hi, Kaspar

Any exception that passes through the Spring transactional layers and has not been explicitly declared will force the transaction to be marked for rollback. So, InvalidNodeRefException will render the transaction as "ROLLBACK_ONLY". You can't reuse the transaction or continue with it. That's the first thing. You work around this by doing NodeService.exists(), or by having alternate actions in a new transaction after you catch an exception.

The second thing is that you need to be 100% sure that the transactions are not leaked out of scope. There are three ways to do this.
1. Fix up the try-catch-finally behaviour
2. (Recommended) Use the RetryingTransactionHelper available from TransactionService. It doesn't leak transactions!
3. Switch on debug to detect any leaked transactions: log4j.logger.org.alfresco.util.transaction.SpringAwareUserTransaction.trace=DEBUG

Regards
Derek

Re: Transaction rolled back

hbf — Wed, 08 Oct 2008 13:49:58 GMT

The second thing is that you need to be 100% sure that the transactions are not leaked out of scope. There are three ways to do this.
1. Fix up the try-catch-finally behaviour
2. (Recommended) Use the RetryingTransactionHelper available from TransactionService. It doesn't leak transactions!
3. Switch on debug to detect any leaked transactions: log4j.logger.org.alfresco.util.transaction.SpringAwareUserTransaction.trace=DEBUG

Hi Derek,

Many thanks for looking into this, very much appreciated. With your explanations, I now understand how this strange behaviour - error from one request "persisted" in the next request - could occur:

In your case, the unclosed transaction is going back into the thread pool. The next operation that attempts to start a new transaction on that thread will generate the "already marked for rollback" exception. That's exactly right. The transaction is still open, you're asking to continue doing some work on the transaction but the transaction is guaranteed to rollback.

Regarding the three ways you mention: I understand that you recommend RetryingTransactionHelper and I am actually using it in our Web layer (which is done in Wicket). However, it seems to be against the normal way in which one would handle an update request: In my web app, I'd like to open a transaction at the beginning of the request, then the MVC code of the web app (scattered over many Wicket components) would make calls to the Alfresco NodeService API and finally a commit() call would save the changes. With RetryingTransactionHelper, however, I cannot (?) do this but am instead forced to collect all calls to the NodeService API in one method, which does not seem natural. Do you have any recommendation for a situation like this?

Thanks for your help,
Kaspar

Re: Transaction rolled back

derek — Thu, 09 Oct 2008 08:18:59 GMT

…
Regarding the three ways you mention: I understand that you recommend RetryingTransactionHelper and I am actually using it in our Web layer (which is done in Wicket). However, it seems to be against the normal way in which one would handle an update request: In my web app, I'd like to open a transaction at the beginning of the request, then the MVC code of the web app (scattered over many Wicket components) would make calls to the Alfresco NodeService API and finally a commit() call would save the changes. With RetryingTransactionHelper, however, I cannot (?) do this but am instead forced to collect all calls to the NodeService API in one method, which does not seem natural. Do you have any recommendation for a situation like this?

Thanks for your help,
Kaspar

Hi, Kaspar
You don't have to use the retrying, of course. Normally there is a single entry point to the service call where the transaction can be declared, but it's not always convenient or even possible; we have some bits where the transaction start and transaction commit are separated e.g. JCR and CIFS implementations. The critical thing, though, is not to leak the transaction under any circumstances. When your commit/rollback code is possibly not going to get called, you should get very nervous; if you're not using RetryingTransactionHelper then make sure your QA includes running with the transaction leak detection enabled. Aside from all those caveats, you need to do something like this:


   Transaction txn = txnService.getUserTranscation(…);
   try
   {
      txn.begin();
      // Do stuff
      txn.commit();
   }
   catch (Throwable e)
   {
      // Try a rollback.  This doesn't always work if the txn is already marked for rollback.  But who cares as long as it is rolled back!
      try
      {
         txn.rollback();
      }
      catch (Throwable e)
      {
         // Just log, don't rethrow
      }
      // Rethrow original exception
      throw e;
   }
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Now, naturally, the outer try-catch can be virtual or implemented by some other mechanism. But either commit OR rollback must be called and the rollback should be wrapped in a try-catch to absorb any exception (illegal state, etc) that might hide the underlying, original exception that triggered the rollback in the first place.