topic Re: Call activity (but not a subprocess) multiple times in Alfresco Archive

Call activity (but not a subprocess) multiple times

lars1 — Tue, 05 Jun 2012 13:09:41 GMT

I have the following activiti flows:mainflowdefault-processprocess-type-aprocess-type-b'mainflow' will call 'default-process' twice (using Call Activiti, not subprocess). Once with an input param 'type-a' and once with the param 'type-b'The default-process will execute a few steps, and then call ano

Re: Call activity (but not a subprocess) multiple times

jbarrez — Wed, 06 Jun 2012 14:03:47 GMT

I would need to see some process XML to better understand what you're doing

Re: Call activity (but not a subprocess) multiple times

lars1 — Thu, 07 Jun 2012 07:54:55 GMT

oké, I'll try to explain it a little better with some xml

I have a main process. This process will call the "subProcessBase" twice (in parallel), but with a different parameter value for the var processKey

The subProcessBase will call another subProcess (typeA or typeB) based on the value of processKey

When I test these processes, the process typeA will be called twice, typeB will not be called at all.

<process id="mainProcess">
<callActivity id="callSubProcessTypeA" calledElement="subProcessBase">
   <extensionElements>
<activiti:in sourceExpression="typeA" target="processKey"></activiti:in>
   </extensionElements>
</callActivity>
<callActivity id="callSubProcessTypeB" calledElement="subProcessBase">
   <extensionElements>
<activiti:in sourceExpression="typeB" target="processKey"></activiti:in>
   </extensionElements>
</callActivity>
</process>

<process id="subProcessBase">
<callActivity id="callSubProcess" calledElement="${processKey}">
</callActivity>
</process>

<process id="typeA">
</process>

<process id="typeB">
</process>

Re: Call activity (but not a subprocess) multiple times

jbarrez — Thu, 07 Jun 2012 08:32:11 GMT

That should indeed just work … so I'm smelling a bug there.

Could you pour it into a unit test so I can verify it at my side?

Re: Call activity (but not a subprocess) multiple times

lars1 — Fri, 08 Jun 2012 08:04:58 GMT

I made a small testcase demonstrating this. Hope this helps.
See attachment

Re: Call activity (but not a subprocess) multiple times

lars1 — Thu, 19 Jul 2012 13:20:13 GMT

Any news on this issue? I don't know if this has been submitted as a bug, but I think this is a real issue so it would be a shame to just ignore this.

Re: Call activity (but not a subprocess) multiple times

urgelacko — Thu, 02 Aug 2012 14:34:07 GMT

Any update on this? I have the same issue.

When I run the process once everything seems alright. But if I run it multiple times, the following executions calls the sub activity with the value of the variable from the first execution. I have logged the variable just before the CallActivity element, and it contains the correct value.

Maybe will there a bugfix in 5.10?

Re: Call activity (but not a subprocess) multiple times

urgelacko — Thu, 02 Aug 2012 14:43:40 GMT

Any update on this? I have the same issue.

When I run the process once everything seems alright. But if I run it multiple times, the following executions calls the sub activity with the value of the variable from the first execution. I have logged the variable just before the CallActivity element, and it contains the correct value.

Maybe will there a bugfix in 5.10?

I have debugged into the CallActivityBehavior class, and I found that the following statement generates the problem:

if ((processDefinitonKey == null) && (processDefinitionExpression != null)) {
      processDefinitonKey = (String) processDefinitionExpression.getValue(execution);
}

After the first run, the processDefinitonKey is not null, so it wouldn't reevaluate the processDefinitionExpression. I have thought the CallActivityBehavior should be constructed in every new processInstance scope. Otherwise it should be stateless.
Am I wrong somewhere? If yes, what should I do different?

Thanks in advance!

Re: Call activity (but not a subprocess) multiple times

frederikherema1 — Fri, 03 Aug 2012 07:07:30 GMT

This has indeed been fixed: http://jira.codehaus.org/browse/ACT-1156, so it will be in 5.10

Re: Call activity (but not a subprocess) multiple times

urgelacko — Mon, 06 Aug 2012 08:30:11 GMT

This has indeed been fixed: http://jira.codehaus.org/browse/ACT-1156, so it will be in 5.10

Great news! Big thanks for the reply.
Keep up the good work