topic Re: activiti:delegateExpression: BpmnError not caught in Alfresco Archive

activiti:delegateExpression: BpmnError not caught

workflowuser2 — Fri, 20 Jul 2012 03:02:36 GMT

Hi,I have a subprocess and a boundary error event on the subprocess scope. Now, in the subprocess, I have service tasks with activiti:delegateExpression. In these java delegates, if I throw BpmnError, it is never caught and processed.The same process works if I use java delegates (activiti:class="ja

Re: activiti:delegateExpression: BpmnError not caught

frederikherema1 — Fri, 20 Jul 2012 07:08:50 GMT

As of 5.10 (due in august), this is supported. Current trunk of ServiceTaskDelegateExpressionActivityBehavior contains:


 } catch (Exception exc) {

      Throwable cause = exc;
      BpmnError error = null;
      while (cause != null) {
        if (cause instanceof BpmnError) {
          error = (BpmnError) cause;
          break;
        }
        cause = cause.getCause();
      }

      if (error != null) {
        ErrorPropagation.propagateError(error, execution);
      } else {
        throw exc;
      }

    }

This was fixed this month for http://jira.codehaus.org/browse/ACT-1159. But thanks for reporting this!

Re: activiti:delegateExpression: BpmnError not caught

pfalcon — Fri, 10 Aug 2012 17:28:20 GMT

I have compiled from 5.10-tag and now BpmnError is caught. However executions processed on error path don't ended, so a process seams as not ended.
In reality all task and a process are ended. However not all DB data are moved to historical tables, and according to API some tasks and a process are not ended.

My process:


  <process id="multiSubProcess">
    <startEvent id="sid-D59EFC88-5697-4ED8-87A2-53FDDFF403AA"></startEvent>
    <subProcess id="bookSubProcess" name="Book Domain">
      <multiInstanceLoopCharacteristics isSequential="false" activiti:collection="orderItemCol" activiti:elementVariable="orderItem"></multiInstanceLoopCharacteristics>
      <startEvent id="start" name="Start"></startEvent>
      <serviceTask id="bookDomain" name="Book" activiti:expression="#{multiSubProcess.bookDomain(processError, orderItem)}"></serviceTask>
      <boundaryEvent id="boundaryerror4" cancelActivity="false" attachedToRef="bookDomain">
        <errorEventDefinition></errorEventDefinition>
      </boundaryEvent>
      <endEvent id="end" name="End"></endEvent>
      <serviceTask id="validateDomain" name="Validate" activiti:expression="#{multiSubProcess.validateOrderElem(processError, orderItem)}"></serviceTask>
      <boundaryEvent id="boundaryerror2" name="" cancelActivity="false" attachedToRef="validateDomain">
        <errorEventDefinition></errorEventDefinition>
      </boundaryEvent>
      <endEvent id="endevent1" name="End"></endEvent>
      <sequenceFlow id="flow3" name="" sourceRef="bookDomain" targetRef="end"></sequenceFlow>
      <sequenceFlow id="flow4" name="" sourceRef="start" targetRef="validateDomain"></sequenceFlow>
      <sequenceFlow id="flow5" name="" sourceRef="validateDomain" targetRef="bookDomain"></sequenceFlow>
    </subProcess>
    <endEvent id="sid-4F5FE891-7E26-445F-9324-416B5E244D8B"></endEvent>
    <sequenceFlow id="flow6" name="" sourceRef="sid-D59EFC88-5697-4ED8-87A2-53FDDFF403AA" targetRef="bookSubProcess"></sequenceFlow>
    <sequenceFlow id="flow7" name="" sourceRef="bookSubProcess" targetRef="sid-4F5FE891-7E26-445F-9324-416B5E244D8B"></sequenceFlow>
    <sequenceFlow id="flow8" name="" sourceRef="boundaryerror2" targetRef="endevent1"></sequenceFlow>
    <sequenceFlow id="flow9" name="" sourceRef="boundaryerror4" targetRef="endevent1"></sequenceFlow>
  </process>

Re: activiti:delegateExpression: BpmnError not caught

bernd_ruecker — Tue, 14 Aug 2012 05:14:32 GMT

Do you have a testcase for that?

Re: activiti:delegateExpression: BpmnError not caught

bernd_ruecker — Tue, 14 Aug 2012 13:27:32 GMT

Hmm, you have set the boundary event to "cancelActivity="false"", which means the process is not ended. If you change that to true the behavior should change. Could you please double check that and come back with more detailed information if it still doesn't work as expected?

Thanks.

Re: activiti:delegateExpression: BpmnError not caught

pfalcon — Thu, 16 Aug 2012 10:50:53 GMT

Thanks.

After change "cancelActivity=true" a process and its all tasks are ended, so it works as expected.

But this setting (false) is default for boundary error in ActivitiDesigner.
After all throwing a BpmnError should automatically cancel an activity, shouldn't it?

Re: activiti:delegateExpression: BpmnError not caught

bernd_ruecker — Thu, 16 Aug 2012 11:17:10 GMT

Basically by BPMN it is intenially left to the user to decide, that's why you have to model it. Changing the default in the Activiti Designer might be an improvement indeed, you could open a jira for this and select the component designer (as we with camunda fox have a different designer which does the canceling one as default already, I am personally not really eager to do it ;-)).

Re: activiti:delegateExpression: BpmnError not caught

fabttl — Thu, 30 Aug 2012 08:51:36 GMT

Hello,

I have the same problem, and setting cancelActivity="true" resolved it.

But, what about the previous PI in the database based on the previous BPMN with the cancelActivity="false" ?

How should I "close/cancel/finish" the previous PIs ?
Are there any APIs ?
Should I use SQL queries ?

Thank you for any ideas that could help me

FRO

Re: activiti:delegateExpression: BpmnError not caught

bernd_ruecker — Tue, 11 Sep 2012 16:03:18 GMT

There are API's to either cancel (see RuntimeService.delete…) or even upgrade the version for instances (see https://app.camunda.com/confluence/display/foxUserGuide/Process+Versioning). So there are different possibilities to achieve that.