topic Re: Problem with autodeploy feature and 5.9 in Alfresco Archive

Problem with autodeploy feature and 5.9

aparraga — Mon, 12 Mar 2012 12:58:58 GMT

I did not noticed this error in 5.8, but in 5.9:When I launched my development environment against a production database backup in 5.8 (and my environment in 5.9), the database was upgraded to 5.9 because I have activated the databaseSchemaUpdate property, BUT it crashes with a NULL Pointer Exceptio

Re: Problem with autodeploy feature and 5.9

trademak — Mon, 12 Mar 2012 14:34:27 GMT

Hi,

We changed this logic in version 5.9, so that's probably the cause of this.
The idea is that a process will not be redeployed without it being changed, this logic was not implemented correctly before 5.9.
Can you raise a JIRA with a test case?

Thanks,

Re: Problem with autodeploy feature and 5.9

jrussell_smyth — Thu, 19 Apr 2012 19:23:42 GMT

I have added to the jira here http://jira.codehaus.org/browse/ACT-1150

This is not a minor issue. Adding a new bpmn to the auto deploy will cause any future deployments/starts to fail. The missing logic in the deploymentsDiffer function is clear, the fix is very small but without it autodeployment is unusable.

Re: Problem with autodeploy feature and 5.9

aparraga — Thu, 19 Apr 2012 19:49:34 GMT

I already fixed the issue by changing the DeployCmd::deploymentsDiffer method as following:


 protected boolean deploymentsDiffer(DeploymentEntity deployment,
         DeploymentEntity saved) {
  Map<String, ResourceEntity> resources = deployment.getResources();
  Map<String, ResourceEntity> savedResources = saved.getResources();

  for (String resourceName : resources.keySet()) {
   String diagramName = resourceName.replaceAll(".+\\/", "");
   boolean isNewDiagram = true; //by default
   for (String pathToDiagram : savedResources.keySet()) {
    if (pathToDiagram.indexOf(diagramName) >= 0) {
     isNewDiagram = false;
     ResourceEntity savedResource = savedResources
             .get(pathToDiagram);
     if (!savedResource.isGenerated()) {
      ResourceEntity resource = resources.get(resourceName);

      byte[] bytes = resource.getBytes();
      byte[] savedBytes = savedResource.getBytes();
      if (!Arrays.equals(bytes, savedBytes)) {
       return true;
      }
     }
    }
   }
   if(isNewDiagram) {
    return true;
   }
  }
  return false;
 }

I mean, I don't compare the path to the diagrams, just the filenames. I know that this is not the best general purpose solution, but for our concrete use case is enough.

Anyway, in our case the bug was due to the paths to the diagrams.

Re: Problem with autodeploy feature and 5.9

heymjo — Fri, 20 Apr 2012 08:59:07 GMT

Is it feasible to get a 5.9.1 for this fix ?

Re: Problem with autodeploy feature and 5.9

trademak — Mon, 23 Apr 2012 10:16:27 GMT

Hi,

I committed a fix for this issue to trunk. It was a really stupid bug, I'm sorry for that.
It will be part of Activiti 5.10, but you can always build a version yourself with the trunk code.

Best regards,

Re: Problem with autodeploy feature and 5.9

heymjo — Wed, 02 May 2012 08:26:23 GMT

you can't seriously expect us to build from trunk and use the result in production 🙂

It would be very helpful if you could link here the commit or diff that fixes this bug. I tried extracting it from the svn logs but there have been several commits on BpmnDeployer since the release so i'm not quite sure.

Re: Problem with autodeploy feature and 5.9

trademak — Wed, 02 May 2012 09:04:22 GMT

Hi,

I only said you can build a distribution from trunk, I'm not expecting anyone to use that in production.
On the other hand, we have a good continuous QA environment, so it's not that stupid.
Here's the diff:

https://fisheye.codehaus.org/browse/activiti/activiti/trunk/modules/activiti-engine/src/main/java/org/activiti/engine/impl/cmd/DeployCmd.java?r2=3393&r1=3249

Best regards,

Re: Problem with autodeploy feature and 5.9

heymjo — Wed, 02 May 2012 13:45:11 GMT

ok thanks, found the diff. We'll be forking off 5.9 and apply this locally until 5.10 is released.

Re: Problem with autodeploy feature and 5.9

robin1 — Wed, 02 May 2012 19:30:12 GMT

I'm building a new application using Activiti and encountered the same problem.

If you have an existing database you need to keep, this won't help you but as a temporary fix every time I change the resources I've been wiping out my Activiti database tables.

delete from ACT_RU_JOB;
delete from ACT_RU_VARIABLE;
delete from ACT_GE_BYTEARRAY;
delete from ACT_HI_ACTINST;
delete from ACT_RE_DEPLOYMENT;
delete from ACT_HI_TASKINST;
delete from ACT_HI_PROCINST;
delete from ACT_RU_VARIABLE;
delete from ACT_RU_IDENTITYLINK;
delete from ACT_RU_TASK;
delete from ACT_RU_EXECUTION;
delete from ACT_RE_PROCDEF;

Re: Problem with autodeploy feature and 5.9

heymjo — Thu, 03 May 2012 07:54:14 GMT

Wiping out those tables is not possible for us in production systems.

So you're saying that if you have an existing 5.8 database and you upgrade it to 5.9+above fix it will still not be enough to solve this bug ?