topic Re: Event subprocess with error start event in Alfresco Archive

Event subprocess with error start event

alemser — Wed, 18 Jul 2012 18:59:31 GMT

Hi,Please, see attachment and XML below…When the Review task ends with error, the respective error start event of the event subprocess is not activated.This message appears in the log:18/07/2012 14:26:56 org.activiti.engine.impl.bpmn.helper.ErrorPropagation propagateErrorINFO: errorEnd throws error

Re: Event subprocess with error start event

frederikherema1 — Thu, 19 Jul 2012 07:02:28 GMT

You throw an error with error-code "123", have you tried with our the error-code?

Re: Event subprocess with error start event

alemser — Mon, 23 Jul 2012 12:34:31 GMT

I did try it in different ways.
I did the same as the user guide example (snippet below). Still not works.


…
                <error id="myError" errorCode="E1" />
…
  <endEvent id="errorEnd" name="err">
   <incoming>toErrorEnd</incoming>
   <errorEventDefinition errorRef="myError" id="errId" />
  </endEvent>
…

  <subProcess completionQuantity="1" id="eventSubProcess" isForCompensation="false"
   name="" startQuantity="1" triggeredByEvent="true">
   
   <startEvent id="errStartEvent" name="err">
    <outgoing>toReport</outgoing>
    <errorEventDefinition errorRef="myError" id="errStartId" />
   </startEvent>
…

Could you suggest some changes to make it work?

Re: Event subprocess with error start event

frederikherema1 — Mon, 23 Jul 2012 12:44:23 GMT

Have you tried this process:
https://svn.codehaus.org/activiti/activiti/trunk/modules/activiti-engine/src/test/resources/org/activiti/engine/test/bpmn/event/error/ErrorEventSubProcessTest.testCatchErrorThrownByScriptTaskInTopLevelProcess.bpmn20.xml

This is used to run tests against the engine. There is an "empty" error-event definition:


<errorEventDefinition /> <!– no errorCode: catch any error –>

Re: Event subprocess with error start event

alemser — Mon, 23 Jul 2012 20:40:04 GMT

Thanks for the link.
I can't run it due some groovy dependencies, but I did some adjusts in my model to make it similar to the example, and got the same error.

I think that might be some problem when, after a gateway, the error comes from an error end event.


…
  <exclusiveGateway gatewayDirection="Diverging" id="okGtw" name="ok?">
   <incoming>toOkGtw</incoming>
   <outgoing>toEmptyEnd</outgoing>
   [b]<outgoing>toErrorEnd</outgoing>[/b]
  </exclusiveGateway>
  
  <endEvent id="emptyEnd" name="emptyEnd">
   <incoming>toEmptyEnd</incoming>
  </endEvent>
  
  <endEvent id="errorEnd" name="err">
   <incoming>toErrorEnd</incoming>
   [b]<errorEventDefinition errorRef="myError" />[/b]
  </endEvent>

  <subProcess completionQuantity="1" id="eventSubProcess" isForCompensation="false"
   name="" startQuantity="1" triggeredByEvent="true">
   
   <startEvent id="errStartEvent" name="err">
    <outgoing>toReport</outgoing>
    [b]<errorEventDefinition />[/b]
   </startEvent>
…

Re: Event subprocess with error start event

frederikherema1 — Tue, 24 Jul 2012 07:22:07 GMT

Could you please create a failing unit-test, showing this problem (replace all your business-specific service-taks with simple stuff), that would help a lot.

Re: Event subprocess with error start event

alemser — Tue, 24 Jul 2012 17:27:55 GMT

Below is the definition and the unit test.

XML


<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<definitions id="definitions" 
  xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"
  xmlns:activiti="http://activiti.org/bpmn"
  targetNamespace="Examples"
  xmlns:tns="Examples"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >
  
 <process id="EventSubprocessErrorStartTest" isExecutable="true">
 
  <startEvent id="startEvent01">
   <outgoing>toReview</outgoing>
  </startEvent>
  
  <userTask id="reviewUserTask" name="Review">
   <incoming>toReview</incoming>
   <outgoing>toOkGtw</outgoing>
  </userTask>
  
  <exclusiveGateway gatewayDirection="Diverging" id="okGtw" name="ok?">
   <incoming>toOkGtw</incoming>
   <outgoing>toEmptyEnd</outgoing>
   <outgoing>toErrorEnd</outgoing>
  </exclusiveGateway>
  
  <endEvent id="emptyEnd" name="emptyEnd">
   <incoming>toEmptyEnd</incoming>
  </endEvent>
  
  <endEvent id="errorEnd" name="err">
   <incoming>toErrorEnd</incoming>
   <errorEventDefinition errorRef="myError" />
  </endEvent>
  
  <sequenceFlow id="toReview" sourceRef="startEvent01" targetRef="reviewUserTask" />
   
  <sequenceFlow id="toOkGtw" sourceRef="reviewUserTask" targetRef="okGtw" />
   
  <sequenceFlow id="toEmptyEnd" sourceRef="okGtw" targetRef="emptyEnd">
   
   <conditionExpression id="exp01" xsi:type="tFormalExpression">${condition=='A'}</conditionExpression>
    
  </sequenceFlow>
  
  <sequenceFlow id="toErrorEnd" sourceRef="okGtw" targetRef="errorEnd">
   
   <conditionExpression id="exp02" xsi:type="tFormalExpression">${condition=='R'}</conditionExpression>
    
  </sequenceFlow>
 </process>
 
 <process id="SubprocessErrorStartTest" isExecutable="true">
 
  <subProcess id="eventSubProcess" triggeredByEvent="true">
   
   <startEvent id="errStartEvent" name="err">
    <outgoing>toReport</outgoing>
    <errorEventDefinition/>
   </startEvent>
   
   <userTask id="reportUserTask" name="Report">
    <incoming>toReport</incoming>
    <outgoing>toSubEmptyEnd</outgoing>
   </userTask>
   
   <endEvent id="subEmptyEnd">
    <incoming>toSubEmptyEnd</incoming>
   </endEvent>
   
   <sequenceFlow id="toReport" sourceRef="errStartEvent"
    targetRef="reportUserTask" />
    
   <sequenceFlow id="toSubEmptyEnd" sourceRef="reportUserTask"
    targetRef="subEmptyEnd" />
  </subProcess>
 </process>
</definitions>

Java


 @Test
 public void testEventSubprocessoErrorStart() {
     Deployment deployment = 
         repositoryService.createDeployment()
                     .addClasspathResource("org/activiti/examples/bpmn/subprocess/EventSubprocess.bpmn20.xml")
                     .deploy();
       
       
       ProcessInstance pi = runtimeService.startProcessInstanceByKey("EventSubprocessErrorStartTest");
       
       //should return only one task called 'Review'
       List<Task> tasks = taskService.createTaskQuery()
                                     .processInstanceId(pi.getId()).list();
       assertEquals(1, tasks.size());
       Task reviewTask = tasks.get(0);
       assertEquals("Review", reviewTask.getName());
       //
       
       //creating the variable to evaluate the expression that will lead to an error end event
       Map<String, Object> vars = new HashMap<String, Object>();
       vars.put("condition", "R");
       
       //complete the 'Review' task with the variables
       taskService.complete(reviewTask.getId(), vars);
       
       //should return only one task (event subprocess 'Report' task) bot no one will be returned
       tasks = taskService.createTaskQuery().list();
       
       assertEquals(1, tasks.size());
       
       // Clean up
       repositoryService.deleteDeployment(deployment.getId(), true);
 }

Re: Event subprocess with error start event

frederikherema1 — Wed, 25 Jul 2012 07:31:14 GMT

I see your problem… You defined the sub-process in a SECOND <process id="…"> tag, which makes it a different process. You should define the sub-process inside the process that throws the error-event, see http://activiti.org/userguide/index.html#bpmnEventSubprocess:

An event subprocess can be added at the process level or at any subprocess level.

If you want cross-process "messaging", use the message-start event end throwing message events.

Re: Event subprocess with error start event

alemser — Wed, 25 Jul 2012 12:05:30 GMT

I made the change and the problem persists.
Do you have an unit-test with this scenario?

I put the subProcess element below inside the main process and remove the second process from the definition.


<subProcess id="eventSubProcess" triggeredByEvent="true">
 <startEvent id="catchError">
                <errorEventDefinition errorRef="myError" /> 
        </startEvent>
        <sequenceFlow id="flow2" sourceRef="catchError" targetRef="taskAfterErrorCatch" />
        <userTask id="taskAfterErrorCatch" name="Provide additional data" />
</subProcess>

Re: Event subprocess with error start event

frederikherema1 — Wed, 25 Jul 2012 12:54:18 GMT

You also forgot to define an "error" definition, in the root <definitions …> element in your XML:


<error id="myError" errorCode="123" />

Re: Event subprocess with error start event

alemser — Wed, 25 Jul 2012 13:59:57 GMT

ok, I put it now… but still not working

Here is my XML


<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<definitions id="definitions" 
  xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"
  xmlns:activiti="http://activiti.org/bpmn"
  targetNamespace="Examples"
  xmlns:tns="Examples"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >
  
   <error id="myError" errorCode="123" />
  
 <process id="EventSubprocessErrorStartTest" isExecutable="true">
  <startEvent id="startEvent01">
   <outgoing>toReview</outgoing>
  </startEvent>
  
  <userTask id="reviewUserTask" name="Review">
   <incoming>toReview</incoming>
   <outgoing>toOkGtw</outgoing>
  </userTask>
  <sequenceFlow id="toReview" sourceRef="startEvent01" targetRef="reviewUserTask" />
  <sequenceFlow id="toOkGtw" sourceRef="reviewUserTask" targetRef="okGtw" />
  
  <exclusiveGateway gatewayDirection="Diverging" id="okGtw" name="ok?">
   <incoming>toOkGtw</incoming>
   <outgoing>toEmptyEnd</outgoing>
   <outgoing>toErrorEnd</outgoing>
  </exclusiveGateway>
  <sequenceFlow id="toEmptyEnd" sourceRef="okGtw" targetRef="emptyEnd">
   <conditionExpression id="exp01" xsi:type="tFormalExpression">${condition=='A'}</conditionExpression>
  </sequenceFlow>
  <sequenceFlow id="toErrorEnd" sourceRef="okGtw" targetRef="errorEnd">
   <conditionExpression id="exp02" xsi:type="tFormalExpression">${condition=='R'}</conditionExpression>
  </sequenceFlow>

  <endEvent id="emptyEnd" name="emptyEnd">
   <incoming>toEmptyEnd</incoming>
  </endEvent>
  
  <endEvent id="errorEnd" name="err">
   <incoming>toErrorEnd</incoming>
   <errorEventDefinition errorRef="myError" />
  </endEvent>
  
  <subProcess id="eventSubProcess" triggeredByEvent="true">   
       <startEvent id="catchError">
                                <errorEventDefinition errorRef="myError" /> 
              </startEvent>
              <sequenceFlow id="flow2" sourceRef="catchError" targetRef="taskAfterErrorCatch" />
               <userTask id="taskAfterErrorCatch" name="Provide additional data" />
  </subProcess>  
  
 </process>
</definitions>

Re: Event subprocess with error start event

frederikherema1 — Wed, 25 Jul 2012 14:15:01 GMT

Your sub-process doesn't contain a end-event, it just stops with the "userTask". I assume this is the issue, as the rest is perfectly fine…

Try debugging first before posting immediately on the form please.

Re: Event subprocess with error start event

alemser — Wed, 25 Jul 2012 14:46:10 GMT

In this case, please, review the XML you sent me: https://svn.codehaus.org/activiti/activiti/trunk/modules/activiti-engine/src/test/resources/org/activiti/engine/test/bpmn/event/error/ErrorEventSubProcessTest.testCatchErrorThrownByScriptTaskInTopLevelProcess.bpmn20.xml

I modified the XML as suggested but still not work. (I debug as I did in the last post)

Thank you.

Re: Event subprocess with error start event

frederikherema1 — Wed, 25 Jul 2012 14:56:04 GMT

Your test with the suggested modifications, runs green:


@Test
  public void testEventSubprocessoErrorStart() {
      org.activiti.engine.repository.Deployment deployment = 
          repositoryService.createDeployment()
                      .addClasspathResource("org/activiti/examples/bpmn/subprocess/EventSubprocess.bpmn20.xml")
                      .deploy();
        
        
        ProcessInstance pi = runtimeService.startProcessInstanceByKey("EventSubprocessErrorStartTest");
        
        //should return only one task called 'Review'
        List<Task> tasks = taskService.createTaskQuery()
                                      .processInstanceId(pi.getId()).list();
        assertEquals(1, tasks.size());
        Task reviewTask = tasks.get(0);
        assertEquals("Review", reviewTask.getName());
        //
        
        //creating the variable to evaluate the expression that will lead to an error end event
        Map<String, Object> vars = new HashMap<String, Object>();
        vars.put("condition", "R");
        
        //complete the 'Review' task with the variables
        taskService.complete(reviewTask.getId(), vars);
        
        //should return only one task (event subprocess 'Report' task) bot no one will be returned
        tasks = taskService.createTaskQuery().list();
        
        assertEquals(1, tasks.size());
        
        // Clean up
        repositoryService.deleteDeployment(deployment.getId(), true);
  }


<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<definitions id="definitions" 
  xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL"
  xmlns:activiti="http://activiti.org/bpmn"
  targetNamespace="Examples"
  xmlns:tns="Examples"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >
  
   <error id="myError" errorCode="123" />
   <process id="EventSubprocessErrorStartTest" isExecutable="true">
   
      <startEvent id="startEvent01">
         <outgoing>toReview</outgoing>
      </startEvent>
      
      <userTask id="reviewUserTask" name="Review">
         <incoming>toReview</incoming>
         <outgoing>toOkGtw</outgoing>
      </userTask>
      
      <exclusiveGateway gatewayDirection="Diverging" id="okGtw" name="ok?">
         <incoming>toOkGtw</incoming>
         <outgoing>toEmptyEnd</outgoing>
         <outgoing>toErrorEnd</outgoing>
      </exclusiveGateway>
      
      <endEvent id="emptyEnd" name="emptyEnd">
         <incoming>toEmptyEnd</incoming>
      </endEvent>
      
      <endEvent id="errorEnd" name="err">
         <incoming>toErrorEnd</incoming>
         <errorEventDefinition errorRef="myError" />
      </endEvent>
      
      <sequenceFlow id="toReview" sourceRef="startEvent01" targetRef="reviewUserTask" />
         
      <sequenceFlow id="toOkGtw" sourceRef="reviewUserTask" targetRef="okGtw" />
         
      <sequenceFlow id="toEmptyEnd" sourceRef="okGtw" targetRef="emptyEnd">
         
         <conditionExpression id="exp01" xsi:type="tFormalExpression">${condition=='A'}</conditionExpression>
            
      </sequenceFlow>
      
      <sequenceFlow id="toErrorEnd" sourceRef="okGtw"   targetRef="errorEnd">
         
         <conditionExpression id="exp02" xsi:type="tFormalExpression">${condition=='R'}</conditionExpression>
            
      </sequenceFlow>

     
      <subProcess id="eventSubProcess" triggeredByEvent="true">
         
         <startEvent id="errStartEvent" name="err">
            <outgoing>toReport</outgoing>
            <errorEventDefinition errorRef="myError"/>
         </startEvent>
         
         <userTask id="reportUserTask" name="Report">
            <incoming>toReport</incoming>
            <outgoing>toSubEmptyEnd</outgoing>
         </userTask>
         
         <endEvent id="subEmptyEnd">
            <incoming>toSubEmptyEnd</incoming>
         </endEvent>
         
         <sequenceFlow id="toReport" sourceRef="errStartEvent"
            targetRef="reportUserTask" />
            
         <sequenceFlow id="toSubEmptyEnd" sourceRef="reportUserTask"
            targetRef="subEmptyEnd" />
      </subProcess>
   </process>
</definitions>

Re: Event subprocess with error start event

alemser — Wed, 25 Jul 2012 15:25:54 GMT

yes really works now. great!
Sorry, last debugging did not caught the changes I made in the XML

Thank you, case closed.