topic Tool (Import, Export) dont use LOG4J and invoke System.exit in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/tool-import-export-dont-use-log4j-and-invoke-system-exit/m-p/11892#M4786 <HTML><HEAD></HEAD><BODY><SPAN>Hi,</SPAN><BR /><BR /><SPAN>I've noticed that the org.alfresco.tools.Tool abstract class does not use the LOG4J framework, but use "System.out" and "exception.printStackTrace()".</SPAN><BR /><BR /><SPAN>Moreover, the Tool class ends with System.exit(0) or System.exit(-1).</SPAN><BR /><BR /><SPAN>This is not so "extensible" like ALL your other services&nbsp; :wink: </SPAN><BR /><BR /><SPAN>I propose that the Tool class:</SPAN><BR /><SPAN>- use the "log4j" framework</SPAN><BR /><SPAN>- do not invoke System.exit(..)</SPAN><BR /><SPAN>- let the exception be thrown outside the method to be caught by the default JVM exception handler or by a wrapper class as in this example:</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR /><BR />import org.alfresco.tools.Import;<BR />import org.apache.commons.logging.Log;<BR />import org.apache.commons.logging.LogFactory;<BR /><BR />/**<BR /> * This class is a "wrapper" to:<BR /> * - log errors using log4j<BR /> * - return a "exit code" different from 0 when one error occurs.<BR /> */<BR />public final class ImportWrapper<BR />{<BR />&nbsp;&nbsp;&nbsp;protected static Log logger = LogFactory.getLog(ImportWrapper.class);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR /> &nbsp;&nbsp;&nbsp;public static void main(String[] args)<BR />&nbsp;&nbsp;&nbsp; {<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;logger.debug("Start of import");<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;int exitCode = 1;<BR /><BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;try<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;{<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Import.main(args);<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;// OK<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;exitCode = 0;<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;catch (Throwable t)<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;{<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;logger.error("ERROR DURING IMPORT:" + t.getMessage(), t);<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;logger.debug("End of import - exitCode=" + exitCode);<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;System.exit(exitCode);<BR /> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<BR />&nbsp;&nbsp;&nbsp; }<BR /> <BR /><BR />}<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE></BODY></HTML> Mon, 29 May 2006 15:24:40 GMT sbroussi 2006-05-29T15:24:40Z Tool (Import, Export) dont use LOG4J and invoke System.exit https://connect.hyland.com/t5/alfresco-archive/tool-import-export-dont-use-log4j-and-invoke-system-exit/m-p/11892#M4786 Hi,I've noticed that the org.alfresco.tools.Tool abstract class does not use the LOG4J framework, but use "System.out" and "exception.printStackTrace()".Moreover, the Tool class ends with System.exit(0) or System.exit(-1).This is not so "extensible" like ALL your other services&nbsp; :wink: I propose tha Mon, 29 May 2006 15:24:40 GMT https://connect.hyland.com/t5/alfresco-archive/tool-import-export-dont-use-log4j-and-invoke-system-exit/m-p/11892#M4786 sbroussi 2006-05-29T15:24:40Z Re: Tool (Import, Export) dont use LOG4J and invoke System.exit https://connect.hyland.com/t5/alfresco-archive/tool-import-export-dont-use-log4j-and-invoke-system-exit/m-p/11893#M4787 <HTML><HEAD></HEAD><BODY><SPAN>You can track fix progress at </SPAN><A href="http://www.alfresco.org/jira/browse/AR-619" rel="nofollow noopener noreferrer">http://www.alfresco.org/jira/browse/AR-619</A><SPAN>.</SPAN></BODY></HTML> Tue, 30 May 2006 17:07:58 GMT https://connect.hyland.com/t5/alfresco-archive/tool-import-export-dont-use-log4j-and-invoke-system-exit/m-p/11893#M4787 davidc 2006-05-30T17:07:58Z