topic Re: DeploymentBuilderImpl - isDuplicateFilterEnabled in Alfresco Archive

DeploymentBuilderImpl - isDuplicateFilterEnabled

davejenknz — Tue, 23 Aug 2011 23:39:20 GMT

Activiti 5.6I'm using SpringProcessEngineConfiguration to deploy resources.Each time the container is restarted the same (unchanged) resources are deployed again.In DeploymentBuilderImpl I notice that the flag isDuplicateFilterEnabled is unused. Is this a bug thats being worked on?Dave

Re: DeploymentBuilderImpl - isDuplicateFilterEnabled

trademak — Wed, 24 Aug 2011 06:56:38 GMT

Hi,

In the DeployCmd you can find the following lines:

if ( deploymentBuilder.isDuplicateFilterEnabled() ) {
      DeploymentEntity existingDeployment = Context
        .getCommandContext()
        .getDeploymentManager()
        .findLatestDeploymentByName(deployment.getName());

      if ( (existingDeployment!=null)
           && !deploymentsDiffer(deployment, existingDeployment)) {
        return existingDeployment;
      }
    }

This should prevent the deployments from being deployed over and over again (if you set the duplicateFilterEnabled to true)

Best regards,

Re: DeploymentBuilderImpl - isDuplicateFilterEnabled

davejenknz — Thu, 01 Sep 2011 21:17:11 GMT

Hi,

FYI I'm running Spring 3.0.5, Activiti 5.6, Postgres 8.4, Java 1.6. I'm configuring the SpringProcessEngineConfiguration in a @Configuration bean.

I'm using an SpringProcessEngineConfiguration instance which does allow me to directly set isDuplicateFilterEnabled.

Looking at the SpringProcessEngineConfiguration code I see that the autoDeployResouces method creates a deployment builder and it calls enableDuplicateFiltering.
Debugging the code shows that autoDeployResouces is called and that the DeploymentBuilderImpl has got the isDuplicateFilterEnabled variable set to true.

However, the unchanged resources are still being written to act_re_deployment and act_ge_bytearray.

Dave

Re: DeploymentBuilderImpl - isDuplicateFilterEnabled

frederikherema1 — Fri, 02 Sep 2011 07:14:04 GMT

I'll have a deeper look at this, in some circumstances I've seen this behaviour, issue already exists: ACT-845

Re: DeploymentBuilderImpl - isDuplicateFilterEnabled

seanmills — Thu, 29 Sep 2011 19:17:03 GMT

I ran into this issue as well. I evaluated the DeployCode.deploymentsDiffer() method and found savedResources contains a png for one of my deployments, however I never deployed a png resource in any previous execution. Do I need to do something different or does the code below need to change?

protected boolean deploymentsDiffer(DeploymentEntity deployment, DeploymentEntity saved) {
    Map<String, ResourceEntity> resources = deployment.getResources();
    Map<String, ResourceEntity> savedResources = saved.getResources();
    if (!resources.keySet().equals(savedResources.keySet())) {
      return true;
    }
    for (String resourceName: resources.keySet()) {
      ResourceEntity resource = resources.get(resourceName);
      byte[] bytes = resource.getBytes();
      ResourceEntity savedResource = savedResources.get(resourceName);
      byte[] savedBytes = savedResource.getBytes();
      if (!Arrays.equals(bytes, savedBytes)) {
        return true;
      }
    }
    return false;
}

Thanks
Sean

Re: DeploymentBuilderImpl - isDuplicateFilterEnabled

seanmills — Fri, 30 Sep 2011 15:50:46 GMT

I found the issue already logged in Jira and scheduled for 5.8… http://jira.codehaus.org/browse/ACT-736