topic Re: TaskQuery slow with many tasks in Alfresco Archive

TaskQuery slow with many tasks

pcsquirrel — Wed, 15 Jun 2011 13:52:16 GMT

Hi,first off all CONGRATULATION - ACTIVITI is really a awesome framework.I´m just implementing an application using Activiti and fiddling for better performance. While doing that I discoverd that Taskquery is rather slow if I have many Tasks. Let me explain:I have 100 Tasks for group "management".I

Re: TaskQuery slow with many tasks

frederikherema1 — Wed, 15 Jun 2011 13:56:07 GMT

What version are you using? I discovered this a while ago and it was fixed:
http://jira.codehaus.org/browse/ACT-766

If you're using the latest version and you're still seeing this problem, let me know…

Re: TaskQuery slow with many tasks

pcsquirrel — Wed, 15 Jun 2011 14:17:07 GMT

its v5.6

i searched the forum but not i JIRA so I haven´t found the bugentry.

I had a look on the changes Tom Baeyens made to fixe the issue. He introduced "set*WithoutCascade" methods for MyBatis. he made this for a couple of properties, but not for "taskDefinitionKey" which still triggers the query.

it is maybe also necessary for "setTaskDefinition" but I´´m not sure.

I will try to extend the patch and will report

philipp eichhorn

Re: TaskQuery slow with many tasks

pcsquirrel — Wed, 15 Jun 2011 14:29:22 GMT

I have done the following patch


Index: java/org/activiti/engine/impl/persistence/entity/TaskEntity.java
===================================================================
— java/org/activiti/engine/impl/persistence/entity/TaskEntity.java (revision xxx)
+++ java/org/activiti/engine/impl/persistence/entity/TaskEntity.java (working copy)
@@ -493,7 +493,11 @@
     this.parentTaskId = parentTaskId;
   }
 
+  public void setTaskDefinitionKeyWithoutCascade(String taskDefinitionKey) {
+     this.taskDefinitionKey = taskDefinitionKey;
+  }     
   public void fireEvent(String taskEventName) {
     TaskDefinition taskDefinition = getTaskDefinition();
     if (taskDefinition != null) {
Index: resources/org/activiti/db/mapping/entity/Task.xml
===================================================================
— resources/org/activiti/db/mapping/entity/Task.xml (revision xxx)
+++ resources/org/activiti/db/mapping/entity/Task.xml (working copy)
@@ -69,7 +69,7 @@
     <result property="executionId" column="EXECUTION_ID_" jdbcType="VARCHAR" />
     <result property="processInstanceId" column="PROC_INST_ID_" jdbcType="VARCHAR" />
     <result property="processDefinitionId" column="PROC_DEF_ID_" jdbcType="VARCHAR"/>
-    <result property="taskDefinitionKey" column="TASK_DEF_KEY_" jdbcType="VARCHAR"/>
+    <result property="taskDefinitionKeyWithoutCascade" column="TASK_DEF_KEY_" jdbcType="VARCHAR"/>
     <result property="dueDateWithoutCascade" column="DUE_DATE_" jdbcType="TIMESTAMP"/>
   </resultMap>

it seems to work, but I haven´t run the testsuite against it.

philipp eichhorn

Re: TaskQuery slow with many tasks

jsissom — Fri, 19 Aug 2011 07:44:22 GMT

Task queries still have a N+1 select bug with the default history level. Can this patch be included in v5.8?

Re: TaskQuery slow with many tasks

frederikherema1 — Wed, 24 Aug 2011 08:46:54 GMT

Applied the patch to trunk