topic Re: Own validator without own export marshaller in Alfresco Archive

Own validator without own export marshaller

christianelmer — Wed, 27 Jul 2011 09:15:44 GMT

Hello,can I write my own validating diagram class without using my own export marshaller? Because I want define rules for the diagrams, but I want use the standard BPMN export marshaller to export the diagrams.Now my own validator extension only works if I write also an export marshaller with this c

Re: Own validator without own export marshaller

tiesebarrell — Sat, 30 Jul 2011 10:43:06 GMT

Christian,

at the moment, you cannot. This is subject to implementation of http://jira.codehaus.org/browse/ACT-523, which to be honest, has not been high on my priority list. I've assigned the issue to myself and will look into it soon.

Re: Own validator without own export marshaller

christianelmer — Sun, 31 Jul 2011 11:27:18 GMT

Ok, then I have to write my own export marshaller. But can I use the standard BPMN export class in my own export mashaller, that I have the same BPMN XML output?

Thanks,
Christian

Re: Own validator without own export marshaller

tiesebarrell — Sun, 31 Jul 2011 12:56:16 GMT

Well, you could subclass org.activiti.designer.export.bpmn20.export.BPMN20ExportMarshaller I suppose, although that would not really help because you can't get directly to the validator it invokes. I could make that overridable by providing a default implementation of a new method, getValidatorId(), which would return the default validator's id in the org.activiti.designer.export.bpmn20.export.BPMN20ExportMarshaller class, but which you could override in a subclass. Would that help?

Re: Own validator without own export marshaller

tiesebarrell — Sun, 31 Jul 2011 12:59:32 GMT

On second thoughts, you might run into the issue that you need to be dependent on the org.activiti.designer.export.bpmn20 to actually be able to subclass the default marshaller. If you could confirm this would work for you, I can see whether I can include the overridable method in the next release of designer.

Re: Own validator without own export marshaller

christianelmer — Sun, 31 Jul 2011 13:19:52 GMT

That would be help, but I can't import the package org.activiti.designer.export.bpmn20.export in the plug-in dependencies. Well, I can add org.activiti.designer.export.bpmn20 to required plug-ins, but it doesn't export the package org.activiti.designer.export.bpmn20.export. Can you also add the export to this or another plug-in?

Thanks,
Christian

Re: Own validator without own export marshaller

tiesebarrell — Sun, 31 Jul 2011 14:03:13 GMT

That's right. I'll do that as well. I've created an issue here http://jira.codehaus.org/browse/ACT-894. Not sure when the next release will be, but I expect to put it in SVN in the next couple of days if you want to run from source.

Since I have your attention Christian, could you take a look at this thread as well? I've placed some questions there for you. http://forums.activiti.org/en/viewtopic.php?f=8&t=2026 . Thanks

Re: Own validator without own export marshaller

tiesebarrell — Sun, 07 Aug 2011 09:34:22 GMT

Christian,

I've committed the changes we discussed. There will be a 5.7.1 release sometime soon which will include this enhancement. If you can't wait for that, you can check out the trunk version to get to it now. Let me know how it works out for you.

Re: Own validator without own export marshaller

christianelmer — Tue, 09 Aug 2011 12:52:47 GMT

Hello Tiese,

I can't use the new version 5.7.1. I have used these instructions: http://docs.codehaus.org/display/ACT/Activiti+Designer+Developer+Guide with the actual trunk from http://svn.codehaus.org/activiti/projects/designer (Revision 2952). But if I want create a new diagram, the editor field is empty and I see a NoSuchMethodError exception:


!ENTRY org.eclipse.ui 4 0 2011-08-09 14:38:10.569
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NoSuchMethodError: org.eclipse.graphiti.services.Graphiti.getMigrationService()Lorg/eclipse/graphiti/services/IMigrationService;
 at org.activiti.designer.eclipse.editor.ActivitiDiagramEditor.setInput(ActivitiDiagramEditor.java:118)
 at org.eclipse.gef.ui.parts.GraphicalEditor.init(GraphicalEditor.java:346)
 at org.eclipse.graphiti.ui.internal.editor.DiagramEditorInternal.init(DiagramEditorInternal.java:1074)
 at org.activiti.designer.eclipse.editor.ActivitiDiagramEditor.init(ActivitiDiagramEditor.java:51)
 at org.eclipse.ui.internal.EditorManager.createSite(EditorManager.java:798)
 at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:647)
 at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:465)
 at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595)
 at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313)
 at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
 at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
 at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
 at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473)
 at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1254)
 at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1207)
 at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1606)
 at org.eclipse.ui.internal.PartStack.add(PartStack.java:497)
 at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103)
 at org.eclipse.ui.internal.PartStack.add(PartStack.java:483)
 at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112)
 at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63)
 at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:225)
 at org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:213)
 at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:778)
 at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:677)
 at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:638)
 at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2860)
 at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2768)
 at org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPage.java:2760)
 at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2711)
 at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
 at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2707)
 at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2691)
 at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2674)
 at org.activiti.designer.eclipse.ui.wizard.diagram.CreateDefaultActivitiDiagramWizard.performFinish(CreateDefaultActivitiDiagramWizard.java:225)
 at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:811)
 at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:430)
 at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
 at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
 at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
 at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
 at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3161)
 at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
 at org.eclipse.jface.window.Window.open(Window.java:801)
 at org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:254)
 at org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:274)
 at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
 at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
 at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
 at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
 at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
 at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
 at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
 at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
 at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
 at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
 at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
 at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3540)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3161)
 at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
 at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
 at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
 at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
 at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
 at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
 at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
 at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
 at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
 at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
 at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:620)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:575)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1408)
 at org.eclipse.equinox.launcher.Main.main(Main.java:1384)

Maybe something is wrong with the Graphiti version? In the pom.xml at the package org.activiti.designer.parent I see this repository entry:


<repository>
 <id>Graphiti</id>
 <layout>p2</layout>
 <url>http://download.eclipse.org/graphiti/updates/0.8.0/</url>
</repository>

But Graphiti version 0.7.1 is installed at the started up eclipse platform…

Greetings,
Christian

Re: Own validator without own export marshaller

trademak — Tue, 09 Aug 2011 13:11:15 GMT

Hi Christian,

You have to install Graphiti version 0.8.0. I'll change the docs rightaway.

Thanks,

Re: Own validator without own export marshaller

christianelmer — Tue, 09 Aug 2011 13:45:53 GMT

Thank you Tijs, now its worked.

I see the multi line text at task and resizing of task - nice features! But the "Yes, import a BPMN 2.0 file" is still not selectable.

Re: Own validator without own export marshaller

tiesebarrell — Tue, 09 Aug 2011 17:59:57 GMT

That's right, it hasn't been implemented yet. It's on the list, though

Re: Own validator without own export marshaller

christianelmer — Wed, 10 Aug 2011 13:10:35 GMT

Did you also changed something at the plug in development for own validators. Because I can' override the method validateDiagram, if I extends from AbstractProcessValidator. I have build and installed the designer 5.7.1 at the Eclipse SDK for develop with the new version. I have also installed Graphiti 0.8.0.

Thanks,
Christian

Re: Own validator without own export marshaller

tiesebarrell — Wed, 10 Aug 2011 18:57:30 GMT

Hello Christian,

no, nothing changed there as far as I know. There's no override needed (AbstractProcessValidator doesn't provide a base implementation), but you should implement the method from the interface if that's what you mean. Maybe something's not setup correctly with your dependencies. Can you subclass AbstractProcessValidator at all or can't you find the class?

You can find an example in the org.activiti.designer.validation.bpmn20.validation.BPMN20ProcessValidator class itself, because it actually just extends AbstractProcessValidator. For your dependencies in MANIFEST.MF, you'll probably need a set like this (this is an old example as far as versions go):

Require-Bundle: org.eclipse.ui,
org.eclipse.core.runtime,
org.activiti.designer.eclipse;bundle-version="5.7.0",
org.activiti.designer.model;bundle-version="5.7.0",
org.eclipse.graphiti.mm;bundle-version="0.7.1",
org.eclipse.graphiti.ui;bundle-version="0.7.1",
org.activiti.designer.gui;bundle-version="5.7.0",
org.eclipse.emf;bundle-version="2.6.0",
org.activiti.designer.export.bpmn20;bundle-version="5.7.0"

Hope this helps.

Re: Own validator without own export marshaller

christianelmer — Thu, 11 Aug 2011 13:35:07 GMT

Now it works without the Override Annotation. Its also works with the new Designer version 5.7.1. I have used this dependencies:

Require-Bundle: org.eclipse.ui,
org.eclipse.core.runtime,
org.activiti.designer.export.bpmn20;bundle-version="5.7.1",
org.activiti.designer.eclipse;bundle-version="5.7.1",
org.activiti.designer.model;bundle-version="5.7.1",
org.eclipse.emf;bundle-version="2.6.0",
org.eclipse.graphiti.mm;bundle-version="0.8.0",
org.eclipse.graphiti.ui;bundle-version="0.8.0",
org.eclipse.core.resources;bundle-version="3.6.0"

I have one more problem. I use this line to add a message to the problem view:


addProblemToDiagram(diagram,"[…]",((FlowNode)object).getId());

But if the message appears, it writes "Location: unknown" and no task. In this case the "object" is an EndEvent object.

Re: Own validator without own export marshaller

tiesebarrell — Thu, 11 Aug 2011 13:42:31 GMT

Christian, could you maybe attach your validator? It's easier to look into any problems that way.

Re: Own validator without own export marshaller

christianelmer — Thu, 11 Aug 2011 14:17:15 GMT

Here the Validator, a little bit clipped and with one simple check:


[…]
public class ProcessValidator extends AbstractProcessValidator {

    […]
    
    public final boolean validateDiagram(final Diagram diagram, final IProgressMonitor monitor) {
        this.diagram = diagram;
        this.monitor = monitor;
        boolean valid = false;

        // Clear markers for this diagram first
        clearMarkers(getResource(diagram.eResource().getURI()));

        monitor.beginTask(VALIDATOR_NAME, 1);

        valid = checkGetJob();

        return valid;
    }
  
    /**
     * Checks if an receive task with the id "getjob" is in front of every end event.
     * 
     * @return The correctness of the diagram.
     */
    private boolean checkGetJob() {
        boolean valid = true;

        final EList<EObject> contents = getResourceForDiagram(diagram).getContents();
        for (final EObject object : contents) {
            if (object instanceof EndEvent) {
                final List<SequenceFlow> incomingFlows = ((EndEvent)object).getIncoming();
                for (SequenceFlow flow : incomingFlows) {
                    if (!flow.getSourceRef().getId().equals("getjob")) {
                        addProblemToDiagram(diagram,
                                "The last task before an EndEvent have to be a receive task with the Id \"getjob\"",
                                ((FlowNode)object).getId());
                        valid = false;
                    }
                }
            }
        }
        monitor.worked(1);
        return valid;
    }
}

Re: Own validator without own export marshaller

tiesebarrell — Thu, 11 Aug 2011 14:24:55 GMT

Thanks, I'll take a look at it soon. It might be the case that the location is never correctly linked to the XML file, if that's what you're referring to. I think I haven't implemented that yet.

Re: Own validator without own export marshaller

tiesebarrell — Thu, 11 Aug 2011 20:06:03 GMT

Christian,

I've checked, but the Location field is simply not implemented in the base class (it's not an issue in your code, but ours), so it will always be empty (or unknown). I'm unsure how the location in the .activiti file would help, but I could look into adding it. I also don't know if I can determine the correct line number from the model element, but that would be part of the investigation. Can you add a Jira issue for this if you feel it's important?

I don't understand what you mean by there's no task. Can you explain?

Re: Own validator without own export marshaller

christianelmer — Fri, 12 Aug 2011 08:19:49 GMT

Hey Tiese,

I mean the Location column at the problem view, there is only "Unknown", not the task with the failure. I thought I have seen it in a previous version of my or the standard validator. Another strange thing is, that there is a little cross on red background inside the task with the failure, not after the saving progress when the failure was produced, but atfer the next saving progress. I hope you understand.

Greetings,
Christian