topic Re: Deleting nodes in BeforeDeleteNode Behaviour in Alfresco Archive

Deleting nodes in BeforeDeleteNode Behaviour

krzysztof_nowac — Wed, 04 Dec 2013 09:25:18 GMT

I created following codeublic class DocumentBehavior implements NodeServicePolicies.BeforeDeleteNodePolicy {private Behaviour beforeDeleteNode;@Overridepublic void beforeDeleteNode(NodeRef nodeRef) { //In this function I'm searching others nodes and then I'm trying delete them. String type = (

Re: Deleting nodes in BeforeDeleteNode Behaviour

yogeshpj — Wed, 04 Dec 2013 09:49:25 GMT

Just make sure that you have appropriate rights to delete the content and it is obvious that the function that you have implemented will call multiple time as you are again deleting content in that.

Re: Deleting nodes in BeforeDeleteNode Behaviour

kaynezhang — Wed, 04 Dec 2013 10:03:00 GMT

Your code have logic error:
Your behaviour is bound to type "kn:document" and before you delete a node of type "kn:document" ,you search node with type "kn:document" and delete it.This will cause beforeDeleteNode is called again.
This may cause an infinite loop.

Re: Deleting nodes in BeforeDeleteNode Behaviour

krzysztof_nowac — Wed, 04 Dec 2013 13:07:00 GMT

I run it as administrator.

I think there is no logic error, because I searching nodes that are other than deleting node: d.cmisbjectId <> '" + nodeRef.toString() + "'

Moreover, this query is simplified. The original search query also excludes the "parent" node when beforeDeleteNode is called again on "child" node.

Re: Deleting nodes in BeforeDeleteNode Behaviour

kaynezhang — Wed, 04 Dec 2013 14:37:00 GMT


sp.setQuery("SELECT d.* FROM kn:document AS d WHERE d.cmis:objectId <> '" + nodeRef.toString() + "' AND d.kn:docType= '" + type + "'");
‍‍‍

You are searching nodes with type of kn:document.
By


NamespaceService.ALFRESCO_URI, "beforeDeleteNode"), QName.createQName("kn", "document"),
      this.beforeDeleteNode);
‍‍‍‍

Your behaviour is bound to type "kn:document.
When you delete node returned by previous (which return node type "kn:document") ,it will tigger your beforeDeleteNode Behaviour again,and so search and delete will be called again and again.It is a cross recurrence call and maybe called many times
I'm sorry I used the word inaccurate(infinite loop) in my last post.

Re: Deleting nodes in BeforeDeleteNode Behaviour

mrogers — Wed, 04 Dec 2013 15:30:00 GMT

What happens if you are trying to delete two documents of type kn:document? Document A will try to delete B and B will try to delete A ad-infinitum.

Your <> test probably needs to be expanded to a list of nodes that you have deleted. You can store your list in the current transaction to stop these sorts of infinite chains.

Re: Deleting nodes in BeforeDeleteNode Behaviour

yogeshpj — Wed, 04 Dec 2013 15:48:12 GMT

You have to filter out the node in beforeDeleteNode method.This behavior will call for every node which is going to be delete.
Add logic to filter other nodes.

Re: Deleting nodes in BeforeDeleteNode Behaviour

rfernandes — Wed, 04 Dec 2013 16:54:27 GMT

Following up on Mike last comment. You need to leverage transaction listeners for your policy. Look to the ContentHitsAspect example in the Alfresco SDK. https://svn.alfresco.com/repos/alfresco-open-mirror/alfresco/HEAD/root/projects/sdk/samples/CustomAspect/source/org/alfresco/sample/ContentHitsAspect.java

Re: Deleting nodes in BeforeDeleteNode Behaviour

krzysztof_nowac — Thu, 05 Dec 2013 08:46:37 GMT

Rui,
I did as you wrote. It works! Thank you very much for your help.