topic Bug with custom actions overrides ? in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299871#M253001 <HTML><HEAD></HEAD><BODY><SPAN>Hi,</SPAN><BR /><BR /><SPAN>I think I found some bug defining custom actions that override native actions in Share.</SPAN><BR /><BR /><SPAN>I created 2 custom actions that override both "document-edit-properties" and "folder-view-details" Share actions. My configuration looks like this :</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&lt;action id="custom-folder-view-details" type="pagelink" label="actions.folder.view-details" icon="folder-view-details"&gt;<BR />&lt;param name="page"&gt;custom-folder-details?nodeRef={node.nodeRef}&lt;/param&gt;<BR />&lt;override&gt;folder-view-details&lt;/override&gt;<BR />&lt;/action&gt;<BR /><BR />&lt;action id="custom-document-edit-properties" type="javascript" icon="folder-edit-properties" label="actions.folder.edit-metadata"&gt;<BR />&lt;param name="function"&gt;onCustomEdit&lt;/param&gt;<BR />&lt;override&gt;document-edit-properties&lt;/override&gt;<BR />&lt;/action&gt;<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>When the actions are rendered in the document library, the "custom-document-edit-properties" action successfully overrides the native one, but both "custom-folder-view-details" and "folder-view-details" actions are displayed.</SPAN><BR /><BR /><SPAN>I made some debugging in the surf-doclist.lib.js and found that the filterOverrides method loops over the actions to filter and removes (in the loop !) the actions which are overridden by other ones. The problem is, when overridden actions are removed from the beginning of the list, all actions are shifted and some actions are never processed.</SPAN><BR /><BR /><BR /><SPAN>Here is what happens with my custom actions :</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />Step 1 : The "custom-document-edit-properties" is processed<BR />[<BR />document-edit-properties,<BR />custom-document-edit-properties, &lt;– Loop cursor<BR />custom-folder-view-details,<BR />folder-view-details<BR />]<BR /><BR />Step 2 : The "document-edit-properties" is removed and all action are shifted<BR />[<BR />custom-document-edit-properties,<BR />custom-folder-view-details,<BR />folder-view-details<BR />]<BR /><BR />Step 3 : The next action is processed, i.e. "folder-view-details" instead of "custom-folder-view-details"<BR />[<BR />custom-document-edit-properties, <BR />custom-folder-view-details,<BR />folder-view-details&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &lt;– Loop cursor<BR />]<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>Here is the filterOverrides method :</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp; filterOverrides: function filterOverrides(p_array)<BR />&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // Remove any indicators overridden by others<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; var item, override, i, ii, j, jj;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; for each (item in p_array)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (item.overrides)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; for (i = 0, ii = item.overrides.length; i &lt; ii; i++)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; override = item.overrides<EM>;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; for (j = 0; j &lt; p_array.length; j++)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (p_array[j].id == override)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; DocList.arrayRemove(p_array, j);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; break;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR /><BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return p_array;<BR />&nbsp;&nbsp; },<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></EM></CODE></PRE><BR /><BR /><BR /><SPAN>I just wanted to know if anyone had/could reproduce this bug.</SPAN><BR /><SPAN>I'm suprised this has not been reported yet, so maybe I'm just doing this the wrong way. Don't hesitate to tell me so.</SPAN><BR /><BR /><SPAN>Thanks in advance for your feedback.</SPAN></BODY></HTML> Mon, 10 Feb 2014 13:52:54 GMT tonyrivet 2014-02-10T13:52:54Z Bug with custom actions overrides ? https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299871#M253001 Hi,I think I found some bug defining custom actions that override native actions in Share.I created 2 custom actions that override both "document-edit-properties" and "folder-view-details" Share actions. My configuration looks like this :&lt;action id="custom-folder-view-details" type="pagelink" lab Mon, 10 Feb 2014 13:52:54 GMT https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299871#M253001 tonyrivet 2014-02-10T13:52:54Z Re: Bug with custom actions overrides ? https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299872#M253002 <HTML><HEAD></HEAD><BODY><SPAN>Any help from the Alfresco Team ?</SPAN></BODY></HTML> Tue, 18 Feb 2014 17:10:55 GMT https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299872#M253002 tonyrivet 2014-02-18T17:10:55Z Re: Bug with custom actions overrides ? https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299873#M253003 <HTML><HEAD></HEAD><BODY><SPAN>What "help" we're you expecting?&nbsp; You seem to have found and diagnosed a problem.&nbsp; </SPAN><BR /><BR /><SPAN>If you want to report a potential bug then please use JIRA.&nbsp;&nbsp; </SPAN><BR /><BR /></BODY></HTML> Tue, 18 Feb 2014 20:54:50 GMT https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299873#M253003 mrogers 2014-02-18T20:54:50Z Re: Bug with custom actions overrides ? https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299874#M253004 <HTML><HEAD></HEAD><BODY><SPAN>I just wanted to know if someone could or have already reproduced this, but it seems it isn't the right place…</SPAN><BR /><SPAN>I'll raise a JIRA.</SPAN></BODY></HTML> Wed, 19 Feb 2014 08:32:54 GMT https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299874#M253004 tonyrivet 2014-02-19T08:32:54Z Re: Bug with custom actions overrides ? https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299875#M253005 <HTML><HEAD></HEAD><BODY><SPAN>FYI, here is the JIRA I just created : </SPAN><A href="https://issues.alfresco.com/jira/browse/ALF-20851" rel="nofollow noopener noreferrer">https://issues.alfresco.com/jira/browse/ALF-20851</A></BODY></HTML> Wed, 19 Feb 2014 16:10:02 GMT https://connect.hyland.com/t5/alfresco-archive/bug-with-custom-actions-overrides/m-p/299875#M253005 tonyrivet 2014-02-19T16:10:02Z