topic workflow fails to set aspect in Alfresco Archive

workflow fails to set aspect

purohitsumit — Thu, 03 Apr 2014 00:42:20 GMT

I am following "http://ecmarchitect.com/alfresco-developer-series-tutorials" and have new workflow in my share's web app.I have reused "http://ecmarchitect.com/alfresco-developer-series-tutorials/workflow/tutorial/tutorial.html#someco-whitepaper-submission-example" example and on "approve" action I

Re: workflow fails to set aspect

lementree — Tue, 15 Apr 2014 06:50:44 GMT

Hi,

Can you send your whole error log and SetWebFlag.java, so I can find the cause.

Regards,

Re: workflow fails to set aspect

purohitsumit — Tue, 15 Apr 2014 20:40:34 GMT

Thanks for your help.
I am using sample file from tutorial. I have changed "constant" string to fit my model definition



import java.io.Serializable;
import java.util.Date;
import java.util.List;
import java.util.Map;

import org.alfresco.repo.action.ParameterDefinitionImpl;
import org.alfresco.repo.action.executer.ActionExecuterAbstractBase;
import org.alfresco.service.cmr.action.Action;
import org.alfresco.service.cmr.action.ParameterDefinition;
import org.alfresco.service.cmr.dictionary.DataTypeDefinition;
import org.alfresco.service.cmr.repository.NodeRef;
import org.alfresco.service.cmr.repository.NodeService;
import org.alfresco.service.namespace.QName;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;



public class SetWebFlag extends ActionExecuterAbstractBase {
   
   public final static String NAME = "set-web-flag";
   public final static String PARAM_ACTIVE = "active";
   
   /** The NodeService to be used by the bean */
   protected NodeService nodeService;
   
   private static Log logger = LogFactory.getLog(SetWebFlag.class);
   
   @Override
   protected void executeImpl(Action action, NodeRef actionedUponNodeRef) {
         
      Boolean activeFlag = (Boolean)action.getParameterValue(PARAM_ACTIVE);

      if (activeFlag == null) activeFlag = true;
      
      if (logger.isDebugEnabled()) logger.debug("Inside executeImpl");
               
      // set the sc:isActive property to true
      // set the sc:published property to now
      Map<QName, Serializable> properties = nodeService.getProperties(actionedUponNodeRef);
      properties.put(QName.createQName(eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL, eDCRModel.PROP_IS_ACTIVE), activeFlag);
        
      if (activeFlag) {
         properties.put(QName.createQName(eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL, eDCRModel.PROP_PUBLISHED), new Date());
      }
      
      // if the aspect has already been added, set the properties
      if (nodeService.hasAspect(actionedUponNodeRef,
             QName.createQName(
                   eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL,
                   eDCRModel.ASPECT_SC_WEBABLE))) {
         if (logger.isDebugEnabled()) logger.debug("Node has aspect");
         nodeService.setProperties(actionedUponNodeRef, properties);
      } else {
         // otherwise, add the aspect and set the properties
         if (logger.isDebugEnabled()) logger.debug("Node does not have aspect");
         nodeService.addAspect(actionedUponNodeRef, QName.createQName(eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL, eDCRModel.ASPECT_SC_WEBABLE), properties);
      }                  
            
      if (logger.isDebugEnabled()) logger.debug("Ran web enable/disable action");
                                 
   }

   @Override
   protected void addParameterDefinitions(List<ParameterDefinition> paramList) {
      paramList.add(
               new ParameterDefinitionImpl(               // Create a new parameter definition to add to the list
                  PARAM_ACTIVE,                           // The name used to identify the parameter
                  DataTypeDefinition.BOOLEAN,             // The parameter value type
                  false,                                  // Indicates whether the parameter is mandatory
                  getParamDisplayLabel(PARAM_ACTIVE)));   // The parameters display label
      
   }

   /**
   * @param nodeService The NodeService to set.
   */
   public void setNodeService(NodeService nodeService) {
      this.nodeService = nodeService;
   }

}
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Error is attached as file

Re: workflow fails to set aspect

kaynezhang — Wed, 16 Apr 2014 03:50:09 GMT

Try to create a new properties map instead of using the properties map returned by nodeService.getProperties(actionedUponNodeRef) When update properties or add aspect
<code>

Map<QName, Serializable> properties = new HashMap<QName, Serializable>();
properties.put(QName.createQName(eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL, eDCRModel.PROP_IS_ACTIVE), activeFlag);
properties.put(QName.createQName(eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL, eDCRModel.PROP_PUBLISHED), new Date());

nodeService.addAspect(actionedUponNodeRef, QName.createQName(eDCRModel.NAMESPACE_SOMECO_WORKFLOW_MODEL, eDCRModel.ASPECT_SC_WEBABLE), properties);
</code

Re: workflow fails to set aspect

purohitsumit — Fri, 18 Apr 2014 21:17:53 GMT

Thanks @kaynezhang

Using a newly created Map for properties does not give above error and aspect get set correctly.

But this way I am overriding any properties set by any other part of code on input node. Isn't this true ?

I even tried to iterate through map from nodeservice and copy it to new map but it still gives me error.


      Iterator it = exisitngproperties.keySet().iterator();
      while(it.hasNext())
      {
         QName key = (QName) it.next();
         properties.put(key, (Serializable)exisitngproperties.get(key));
      }
‍‍‍‍‍‍‍‍

Any idea what is reason of error when some properties are from nodeservice

Thanks

Re: workflow fails to set aspect

kaynezhang — Sat, 19 Apr 2014 16:16:00 GMT

The properties map returned by nodeService.getProperties is an unmodifiable map.If you modified it it will give you unmodifiable exception.
If you want to update some properties ,you can just create a new map and set the properties you want to modify ,Other existing properties not contained in your new map will not be affected.