topic Re: proxying custom webscript errors in Alfresco Archive

proxying custom webscript errors

danlangford — Sat, 19 May 2012 18:58:22 GMT

we have written many webscripts and a handful of custom interfaces on Share. when our webscripts encounter a server side error with out other systems we have them return an error like so:// some-action.get.js returns application/jsonmodel.result = "FAILED: custom, localized exception message";status

Re: proxying custom webscript errors

flm — Mon, 11 Jun 2012 11:14:43 GMT

I am facing this issue as well. I opened a ticket with Alfresco support because even the JSON error result of the default document library actions is not available anymore.

Since the Share implementation doesn't seem to use these as error messages, it is not apparent in the Share App but we use these messages in our custom code.

Re: proxying custom webscript errors

kevinr — Tue, 12 Jun 2012 21:09:17 GMT

Thank you for raising the issue with detailed information. The behaviour of error handling you mention was changed to fix a number of customer issues relating to the fact that we did *not* allow the J2EE container to handle the 500 errors. The customers wished to customise the 500 JSP error page (and potentially add other errorXYZ.jsp pages).

My apologies that this is has broken your customisations. I will looking into a solution ASAP.

Cheers,

Kev

Re: proxying custom webscript errors

flm — Tue, 12 Jun 2012 21:43:44 GMT

As a reference, these are two Jira issues related to this problem:
https://issues.alfresco.com/jira/browse/ALF-14524
https://issues.alfresco.com/jira/browse/ALF-14451

Re: proxying custom webscript errors

kevinr — Wed, 13 Jun 2012 13:03:39 GMT

Fixed in 3.4.11 rev 37720.

The fix requires a SpringSurf library update. The latest is now 1.2.0-SNAPSHOT.

The change is very small though, so I can provide a modified spring-webscripts JAR that will work against 3.4.9 or 4.0.1 etc.

Index: spring-webscripts/spring-webscripts/src/main/java/org/springframework/extensions/webscripts/connector/RemoteClient.java
===================================================================
— spring-webscripts/spring-webscripts/src/main/java/org/springframework/extensions/webscripts/connector/RemoteClient.java   (revision 1088)
+++ spring-webscripts/spring-webscripts/src/main/java/org/springframework/extensions/webscripts/connector/RemoteClient.java   (revision 1089)
@@ -1119,7 +1119,7 @@
             if (debug) logger.debug("Response encoding: " + contentType);

             // generate container driven error message response for specific response codes
-            if (res != null && (responseCode == HttpServletResponse.SC_UNAUTHORIZED || responseCode >= HttpServletResponse.SC_INTERNAL_SERVER_ERROR) && allowResponseCommit)
+            if (res != null && responseCode == HttpServletResponse.SC_UNAUTHORIZED && allowResponseCommit)
             {
                 res.sendError(responseCode, method.getStatusText());
             }