topic Re: until ACT-60 is done, development should go in branch dev in Alfresco Archive

until ACT-60 is done, development should go in branch dev

tombaeyens — Wed, 28 Jul 2010 08:49:05 GMT

Hi All,The PVM refactoring is having a big impact on the codebase. E.g. pvm classes are being extracted into a separate module. They are now starting with packages org.activiti.pvm and all engine classes remain in the engine module, but they now al start with org.activiti.engine. So e.g. all the

Re: until ACT-60 is done, development should go in branch dev

bernd_ruecker — Wed, 28 Jul 2010 10:55:10 GMT

Hi Tom.

That raises a question for us: Where do we put teh cacle stuff? I would propose to NOT move it below the engine package, but to move it to "org.activiti.cycle" and "org.activiti.cycle.impl". If that is OK with you, it shouldn't have impact on our development and I would move that now in trunk and create a branch from that if you wish? But since it is pretty seperated from the PVM refactorings, we could keep working in trunk as well?

One question just because I am curious: In which packages will the "BPMN" language go? In engine.impl? Or will the languages be seperated?

Thanks
Bernd

Re: until ACT-60 is done, development should go in branch dev

tombaeyens — Wed, 28 Jul 2010 11:38:52 GMT

I think I prefer org.activiti.cycle too. But to be consistent we might reconsider putting it in a different module.

Re: until ACT-60 is done, development should go in branch dev

bernd_ruecker — Wed, 28 Jul 2010 11:44:11 GMT

Hmm, as I remeber, that was my proposal from the beginning 😉

Okay, but I would be happy with it: It would make the cycle development more independant for now and it would make things better seperated. So I do that in trunk, OK?

Re: until ACT-60 is done, development should go in branch dev

bernd_ruecker — Wed, 28 Jul 2010 17:01:51 GMT

Okay, as discussed on the phone I moved cycle to an own module called "activiti-cycle". The webapp moved to "activiti-webapp-cycle" (explorer and probe will follow that naming pattern). Everything seems to compile and build here on my machine and is committed (so I can go ahead make the stuff I wanted to do in cycle today, finally ;-)).

I think Nils can check tomorrow if the distro and webapp is still working.