topic Potential Bug in EntityManagerSessionImpl in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/potential-bug-in-entitymanagersessionimpl/m-p/240517#M193647 <HTML><HEAD></HEAD><BODY><SPAN>Hello everyone,</SPAN><BR /><BR /><SPAN>I was writing a small benchmark testing a quite simple process that manipulates a JPA Entity by calling Services (CDI-Beans). As soon as I tried to run several instances&nbsp; one after another, the system stopped responding due to a lack of available database connections.</SPAN><BR /><BR /><SPAN>We are currently using Activiti 5.20.0, Hibernate 5.1.1, Weld 2.2.11 on Tomcat 7.0.47. The ProcessEngine is configured based upon a CdiStandaloneProcessEngineConfiguration, including</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; conf.setJpaHandleTransaction(true);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; conf.setJpaCloseEntityManager(true);<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><SPAN>Debugging through the stack lead me to </SPAN><PRE class="language-none line-numbers"><CODE>org.activiti.engine.impl.variable.EntityManagerSessionImpl.close()<SPAN class="line-numbers-rows"><SPAN>‍</SPAN></SPAN></CODE></PRE><SPAN>.</SPAN><BR /><BR /><SPAN>I'm a little bit puzzled about the check within this method:</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp; if (closeEntityManager &amp;&amp; entityManager != null &amp;&amp; !entityManager.isOpen()) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; try {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; entityManager.close();<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; } catch (IllegalStateException ise) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; throw new ActivitiException("Error while closing EntityManager, may have already been closed or it is container-managed", ise);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; } <BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><SPAN>Is this intended? Checking for the entityManager to be not open prior to closing it? Shouldn’t it check for the entityManager to be open?</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp; if (closeEntityManager &amp;&amp; entityManager != null &amp;&amp; entityManager.isOpen()) {<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><SPAN>I’ve fetched the 5.20.0 sources, modified the check and built it. The unit tests ran fine and my benchmark executed as expected.</SPAN><BR /><BR /><SPAN>I can’t imagine being the first person to stumble over this, it feels like I am wrong in my presumptions.</SPAN><BR /><BR /><SPAN>Best regards,</SPAN><BR /><BR /><SPAN>Thomas</SPAN><BR /></BODY></HTML> Mon, 17 Oct 2016 15:59:19 GMT schtho 2016-10-17T15:59:19Z Potential Bug in EntityManagerSessionImpl https://connect.hyland.com/t5/alfresco-archive/potential-bug-in-entitymanagersessionimpl/m-p/240517#M193647 Hello everyone,I was writing a small benchmark testing a quite simple process that manipulates a JPA Entity by calling Services (CDI-Beans). As soon as I tried to run several instances&nbsp; one after another, the system stopped responding due to a lack of available database connections.We are currently Mon, 17 Oct 2016 15:59:19 GMT https://connect.hyland.com/t5/alfresco-archive/potential-bug-in-entitymanagersessionimpl/m-p/240517#M193647 schtho 2016-10-17T15:59:19Z Re: Potential Bug in EntityManagerSessionImpl https://connect.hyland.com/t5/alfresco-archive/potential-bug-in-entitymanagersessionimpl/m-p/240518#M193648 <HTML><HEAD></HEAD><BODY><SPAN>Hi Thomas,</SPAN><BR /><BR /><SPAN>Yes, you are right, it should be closed if it is opened. I didn't test it&nbsp; it by myself yet but according to the code I think it's a bug.</SPAN><BR /><SPAN>Please add also some tests for your change and then creating a PR for this change will give you all the credit for this fix.</SPAN><BR /><SPAN>Thanks for your input.</SPAN><BR /></BODY></HTML> Tue, 08 Nov 2016 09:29:55 GMT https://connect.hyland.com/t5/alfresco-archive/potential-bug-in-entitymanagersessionimpl/m-p/240518#M193648 vasile_dirla 2016-11-08T09:29:55Z