topic Re: Wrong script task listener executed in Alfresco Archive

Wrong script task listener executed

rwa — Fri, 29 Jan 2016 10:10:48 GMT

Hi,We face a really annoying bug with activiti.We use version 5.13 of activiti.Here is the bug scenario (see bpmn here: https://drive.google.com/file/d/0BxxZafFzNUQdV1JGSnRUZ242SnM/view?usp=sharing for activity references) :The process instance is in the usertask31 activity. The user does action for

Re: Wrong script task listener executed

jbarrez — Mon, 01 Feb 2016 09:27:40 GMT

The error "This causes an error that says : "No outgoing sequence flow of the exclusive gateway 'exclusivegateway35' could be selected for continuing the process"." means that none of the expressions defined on the sequenceflow going out of 'exclusivegateway35' evaluated to true.

The fact you say this is happening 'randomly' means that at that point your data is different and evaluates to false. In the other cases, it evaluates to true for one of the expressions.

Re: Wrong script task listener executed

rwa — Mon, 01 Feb 2016 10:00:06 GMT

I agree with your reasoning, but as I said in the second part of my post, we added some logs into activiti engine core to understand what happened exactly. It appears that the complete listener of the task usertask31 (the one we complete) is not executed. Instead, the complete listener of the task usertask23 is executed (although the process does not go through usertask23).

So, do you think that a wrong task-listener association could be done (randomly!) ?
Have you ever heard of such a bug?

Re: Wrong script task listener executed

vasile_dirla — Mon, 01 Feb 2016 13:12:11 GMT

Hi,
I never seen or even heard about this behaviour but would be nice if you could provide a unit test to reproduce this behaviour. (it would be a good starting point of investigation)

Considering that Activiti 5.13 is more than 2 years old, did you test it with a more recent version of Activiti ?

Re: Wrong script task listener executed

rwa — Wed, 10 Feb 2016 12:14:32 GMT

No we did not test it with a more recent version of Activiti. I cannot upgrade right now.

I make unit test in order to reproduce the problem. But I face some problem to run unit test on my workflow. As I said, I use some alfresco component (e.g. alfresco ScriptTaskListener). This causes exception when running test.
How could I configure activiti unit test to be able to run it on a workflow containing alfresco component ?

Re: Wrong script task listener executed

jbarrez — Thu, 11 Feb 2016 09:44:05 GMT

Doesn't need to be that particular script task listener … any task listener would do. Given your explanation above, the error doesn't seem to be in the area of the tasklistener, right?

Re: Wrong script task listener executed

rwa — Thu, 11 Feb 2016 09:54:12 GMT

It could be in the area of the listener because the right task is executed/completed (usertask31) but the wrong listener is executed (the one of task usertask23). I check the bpmn code in db : No error. So it seems like the listeners loading in cache is wrong.

Re: Wrong script task listener executed

jbarrez — Tue, 16 Feb 2016 11:07:18 GMT

That would be very strange, I would assume many more people would have seen the issue if some caching would be wrong.

Re: Wrong script task listener executed

scspy — Tue, 01 Mar 2016 15:59:33 GMT

Hi,

We faced same problem on production server. Configuration: alfresco version 4.2.4, activiti version 5.13-alf-20140708.
We have 600 everyday active users. Sometimes complete task listeners aren't execute and process's behavior goes incorrect.
After restart system behaves normally, but then problem appears again in other process instances.
We can't reproduce this problem on unit tests.

Re: Wrong script task listener executed

ilyagalahov — Wed, 02 Mar 2016 15:01:20 GMT

Hello.

The same issue…

Re: Wrong script task listener executed

jbarrez — Mon, 07 Mar 2016 09:34:08 GMT

As said above, a unit test that demonstrates this problem would help a lot here
It seems to be environmental (ie Alfresco), so not sure how to reproduce with the bare engine.

Re: Wrong script task listener executed

behemot — Fri, 11 Mar 2016 11:58:24 GMT

Hello,
We have debug and fixed this problem. Our customers faced same problem daily.
Activiti load workflow definitions, parse and change to object and after that keeps in some kind of cache (map).
The problem is with workflow parser, which/when is working asynchronous. Restart is required because cache keep wrong/mixed listeners.

We have solved problem by just changing synchronize deploy method in BpmnDeployer.
Patch is tested and ready for production.

Please find the attached file "activiti-engine-5.13-alf-20130918_patched.jar_.txt" and remove "_.txt" to use it.

Re: Wrong script task listener executed

rwa — Fri, 11 Mar 2016 12:57:30 GMT

Hello,

Thanks a lot for this patch.

Do you think such a problem could happen with listeners in java ?

Re: Wrong script task listener executed

ilyagalahov — Fri, 11 Mar 2016 14:11:30 GMT

Thank you, David.

We already solved this problem too by executing web script to remove definition from cache…

Something like this:
activitiProcessEngineConfiguration.getDeploymentManager().getProcessDefinitionCache().remove(args['defId']);

But this works after problem already occured.

We cannot use patches by company policy.

Could you please share concrete code or github link ?

Are you just marked method deploy() synchronized ?
How does it impact performance ?

Regards Ilya.

ilyagalahov1@gmail.com

Re: Wrong script task listener executed

behemot — Fri, 11 Mar 2016 15:14:21 GMT

No problem. Welcome.

Regarding to your comments:
activitiProcessEngineConfiguration.getDeploymentManager().getProcessDefinitionCache().remove(args['defId']);
> this is only temporary solution, because Altiviti will do same mistake again

Could you please share concrete code or github link ?
> please just change:
public void deploy(DeploymentEntity deployment) {
to
public synchronized void deploy(DeploymentEntity deployment) {

How does it impact performance ?
> our customers have not over 20 workflows (not over 30 tasks per workflow, with not over 2000 JavaScript lines per workflow), and we do not see any differences

Re: Wrong script task listener executed

behemot — Fri, 11 Mar 2016 15:20:06 GMT

Hello,

Welcome.

No, there is no problem with listener, but with parser. Unfortunately we do not have time to analyze Activiti source code to fix asynchronous parsing, so we switch to synchronous