topic Re: When a CallActivity fails, the Workflow never ends in Alfresco Archive

When a CallActivity fails, the Workflow never ends

calbertts — Mon, 25 Jan 2016 20:43:19 GMT

Hi everyone,I'm facing a problem with asynchronous workflows.I have this design:workflow1:start -> ScriptActivity1 (is throwing a NullPointerException to test error handling) -> endworkflow2:start -> CallActivity (which calls workflow1) -> endI'm seeing that if I deploy the workflow as a

Re: When a CallActivity fails, the Workflow never ends

vasile_dirla — Tue, 26 Jan 2016 07:11:27 GMT

Hi,
will have to reproduce the issue and investigate it.
could you create a unit test for it ? (it will help a lot for reproducing the issue)

Re: When a CallActivity fails, the Workflow never ends

calbertts — Mon, 01 Feb 2016 17:41:43 GMT

Hi Vasile,

Thanks for answering, I've created a unit test trying to reproduce the scenario, when the variable ASYNC is true, the error isn't shown and I don't know how to catch it, when it's false it works as I expect.

Thanks in advance!

Re: When a CallActivity fails, the Workflow never ends

martin_grofcik — Tue, 02 Feb 2016 08:31:13 GMT

Hi,

I would say that the problem is that job is executed and exception is thrown. Based on the exception _retries are decreased (from 3 -> 0). Job is re-executed 3 times and it is not fetched any more. That's normal async job exception handling.
You can re-execute the job again by setting retries to e.g. 1.

http://activiti.org/userguide/index.html#jobExecutorConfiguration

regards
Martin

Re: When a CallActivity fails, the Workflow never ends

calbertts — Tue, 02 Feb 2016 14:11:26 GMT

I don't want retries, I just want to catch the exception the first time and then to deal with the exception, for any reason in the unit test running in debug mode it seems the custom command is never executed, do you know why?

Re: When a CallActivity fails, the Workflow never ends

martin_grofcik — Wed, 03 Feb 2016 13:57:47 GMT

Hi,

I've just add your test to the activiti test project template.
The exception is


org.activiti.engine.ActivitiException: problem evaluating script: javax.script.ScriptException: org.activiti.engine.ActivitiException: Cannot get property 'prop' on null object

Could you create jUnit test project please?
https://forums.activiti.org/content/sticky-how-write-unit-test

Regards
Martin

Re: When a CallActivity fails, the Workflow never ends

calbertts — Thu, 04 Feb 2016 15:20:43 GMT

Hi Martin,

I've created this repo with the Unit Test template for activiti:
https://github.com/calbertts/activiti-unit-test-template

Reading the docs, I was able to came up with solution to finish the parent workflow if a subworkflow fails, I'm using a boundary event, I'm not sure if this would be the right approach, but the problem now is that I'd like to make the parent workflow fail if a subprocess fail.

In the unit test I added some logs to show the execution flow, I'm seeing that the parent process receives this event when the subprocess fails: ACTIVITY_ERROR_RECEIVED

But the main process finishes successfully with: JOB_EXECUTION_SUCCESS

How can I throw an error if a sub process fails?

Remember I'm running everything asynchronously.

Thanks

Re: When a CallActivity fails, the Workflow never ends

trademak — Thu, 04 Feb 2016 20:06:12 GMT

Hi,

The easiest way to accomplish this is probably to catch the exception in the sub process and use an error end event there. On the call activity you can then define a boundary error event. This is an unit test that's part of the Activiti test suite:

https://github.com/Activiti/Activiti/blob/master/modules/activiti-engine/src/test/resources/org/activiti/engine/test/bpmn/event/error/BoundaryErrorEventTest.testCatchErrorOnCallActivity-parent.bpmn20.xml

Best regards,