topic Re: Java backed webscript not working - upgrade 3.0 to 3.2r in Alfresco Archive

Java backed webscript not working - upgrade 3.0 to 3.2r

lynnders — Wed, 26 May 2010 15:22:05 GMT

I'm upgrading from 3.0 to 3.2r and the only thing not working is a a Java backed webscript.My webscript class Bloghunter extends PageableWebScript which in turn extends DeclarativeWebscriptHere is an extract from Bloghunter.getResults SearchParameters sp = new SearchParameters(); sp.ad

Re: Java backed webscript not working - upgrade 3.0 to 3.2r

lynnders — Fri, 28 May 2010 09:48:31 GMT

The problem was in ADMLuceneSearcherImpl at line 330

The propertyDef is null so the call to propertyDef.getDataType throws an error

It used to work in 3.0 only because the guy who worked here before me had modified the alfresco code and added the following check
if (propertyDef != null)

So here's the code that works for me


    public ResultSet query(SearchParameters searchParameters)
    {
        if (searchParameters.getStores().size() != 1)
        {
            throw new IllegalStateException("Only one store can be searched at present");
        }

        ArrayList<StoreRef> stores = searchParameters.getStores();
        stores.set(0, tenantService.getName(searchParameters.getStores().get(0)));

        String parameterisedQueryString;
        if (searchParameters.getQueryParameterDefinitions().size() > 0)
        {
            Map<QName, QueryParameterDefinition> map = new HashMap<QName, QueryParameterDefinition>();

            for (QueryParameterDefinition qpd : searchParameters.getQueryParameterDefinitions())
            {
                map.put(qpd.getQName(), qpd);
            }

            parameterisedQueryString = parameterise(searchParameters.getQuery(), map, null, namespacePrefixResolver);
        }
        else
        {
            parameterisedQueryString = searchParameters.getQuery();
        }

        if (searchParameters.getLanguage().equalsIgnoreCase(SearchService.LANGUAGE_LUCENE))
        {
            try
            {

                Operator defaultOperator;
                if (searchParameters.getDefaultOperator() == SearchParameters.AND)
                {
                    defaultOperator = LuceneQueryParser.AND_OPERATOR;
                }
                else
                {
                    defaultOperator = LuceneQueryParser.OR_OPERATOR;
                }

                ClosingIndexSearcher searcher = getSearcher(indexer);
                Query query = LuceneQueryParser.parse(parameterisedQueryString, DEFAULT_FIELD, new LuceneAnalyser(getDictionaryService(),
                        searchParameters.getMlAnalaysisMode() == null ? getLuceneConfig().getDefaultMLSearchAnalysisMode() : searchParameters.getMlAnalaysisMode()),
                        namespacePrefixResolver, getDictionaryService(), tenantService, defaultOperator, searchParameters, getLuceneConfig(), searcher.getIndexReader());
                if (s_logger.isDebugEnabled())
                {
                    s_logger.debug("Query is " + query.toString());
                }
                if (searcher == null)
                {
                    // no index return an empty result set
                    return new EmptyResultSet();
                }

                Hits hits;

                boolean requiresPostSort = false;
                if (searchParameters.getSortDefinitions().size() > 0)
                {
                    int index = 0;
                    SortField[] fields = new SortField[searchParameters.getSortDefinitions().size()];
                    for (SearchParameters.SortDefinition sd : searchParameters.getSortDefinitions())
                    {
                        switch (sd.getSortType())
                        {
                        case FIELD:
                            Locale sortLocale = null;
                            String field = sd.getField();
                            if (field.startsWith("@"))
                            {
                                field = expandAttributeFieldName(field);
                                PropertyDefinition propertyDef = getDictionaryService().getProperty(QName.createQName(field.substring(1)));

                                // ********************** 28/05/10 MODIFICATION - check for null propertyDef **********************
                                if (propertyDef != null)
                                {
                                    if (propertyDef.getDataType().getName().equals(DataTypeDefinition.CONTENT))
                                    {
                                        throw new SearcherException("Order on content properties is not curently supported");
                                    }
                                    else if ((propertyDef.getDataType().getName().equals(DataTypeDefinition.MLTEXT))
                                            || (propertyDef.getDataType().getName().equals(DataTypeDefinition.TEXT)))
                                    {
                                        List<Locale> locales = searchParameters.getLocales();
                                        if (((locales == null) || (locales.size() == 0)))
                                        {
                                            locales = Collections.singletonList(I18NUtil.getLocale());
                                        }
    
                                        if (locales.size() > 1)
                                        {
                                            throw new SearcherException("Order on text/mltext properties with more than one locale is not curently supported");
                                        }
    
                                        sortLocale = locales.get(0);
                                        // find best field match
    
                                        MLAnalysisMode analysisMode = getLuceneConfig().getDefaultMLSearchAnalysisMode();
                                        HashSet<String> allowableLocales = new HashSet<String>();
                                        for (Locale l : MLAnalysisMode.getLocales(analysisMode, sortLocale, false))
                                        {
                                            allowableLocales.add(l.toString());
                                        }
    
                                        String sortField = field;
    
                                        for (Object current : searcher.getReader().getFieldNames(FieldOption.INDEXED))
                                        {
                                            String currentString = (String) current;
                                            if (currentString.startsWith(field) && currentString.endsWith(".sort"))
                                            {
                                                String fieldLocale = currentString.substring(field.length() + 1, currentString.length() - 5);
                                                if (allowableLocales.contains(fieldLocale))
                                                {
                                                    if (fieldLocale.equals(sortLocale.toString()))
                                                    {
                                                        sortField = currentString;
                                                        break;
                                                    }
                                                    else if (sortLocale.toString().startsWith(fieldLocale))
                                                    {
                                                        if (sortField.equals(field) || (currentString.length() < sortField.length()))
                                                        {
                                                            sortField = currentString;
                                                        }
                                                    }
                                                    else if (fieldLocale.startsWith(sortLocale.toString()))
                                                    {
                                                        if (sortField.equals(field) || (currentString.length() < sortField.length()))
                                                        {
                                                            sortField = currentString;
                                                        }
                                                    }
                                                }
                                            }
                                        }
    
                                        field = sortField;
    
                                    }
                                    else if (propertyDef.getDataType().getName().equals(DataTypeDefinition.DATETIME))
                                    {
                                        DataTypeDefinition dataType = propertyDef.getDataType();
                                        String analyserClassName = dataType.getAnalyserClassName();
                                        if (analyserClassName.equals(DateTimeAnalyser.class.getCanonicalName()))
                                        {
                                            field = field + ".sort";
                                        }
                                        else
                                        {
                                            requiresPostSort = true;
                                        }
                                    }
                                }

                            }
                            if (fieldHasTerm(searcher.getReader(), field))
                            {
                                fields[index++] = new SortField(field, sortLocale, !sd.isAscending());
                            }
                            else
                            {
                                fields[index++] = new SortField(null, SortField.DOC, !sd.isAscending());
                            }
                            break;
                        case DOCUMENT:
                            fields[index++] = new SortField(null, SortField.DOC, !sd.isAscending());
                            break;
                        case SCORE:
                            fields[index++] = new SortField(null, SortField.SCORE, !sd.isAscending());
                            break;
                        }

                    }
                    hits = searcher.search(query, new Sort(fields));

                }
                else
                {
                    hits = searcher.search(query);
                }

                ResultSet rs = new LuceneResultSet(hits, searcher, nodeService, tenantService, searchParameters, getLuceneConfig());
                rs = new PagingLuceneResultSet(rs, searchParameters, nodeService);
                if (getLuceneConfig().getPostSortDateTime() && requiresPostSort)
                {
                    ResultSet sorted = new SortedResultSet(rs, nodeService, searchParameters, namespacePrefixResolver);
                    return sorted;
                }
                else
                {
                    return rs;
                }
            }
            catch (ParseException e)
            {
                throw new SearcherException("Failed to parse query: " + parameterisedQueryString, e);
            }
            catch (IOException e)
            {
                throw new SearcherException("IO exception during search", e);
            }
        }
        else if (searchParameters.getLanguage().equalsIgnoreCase(SearchService.LANGUAGE_XPATH))
        {
            try
            {
                XPathReader reader = new XPathReader();
                LuceneXPathHandler handler = new LuceneXPathHandler();
                handler.setNamespacePrefixResolver(namespacePrefixResolver);
                handler.setDictionaryService(getDictionaryService());
                // TODO: Handler should have the query parameters to use in
                // building its lucene query
                // At the moment xpath style parameters in the PATH
                // expression are not supported.
                reader.setXPathHandler(handler);
                reader.parse(parameterisedQueryString);
                Query query = handler.getQuery();
                Searcher searcher = getSearcher(null);
                if (searcher == null)
                {
                    // no index return an empty result set
                    return new EmptyResultSet();
                }
                Hits hits = searcher.search(query);
                ResultSet rs = new LuceneResultSet(hits, searcher, nodeService, tenantService, searchParameters, getLuceneConfig());
                rs = new PagingLuceneResultSet(rs, searchParameters, nodeService);
                return rs;
            }
            catch (SAXPathException e)
            {
                throw new SearcherException("Failed to parse query: " + searchParameters.getQuery(), e);
            }
            catch (IOException e)
            {
                throw new SearcherException("IO exception during search", e);
            }
        }
        else
        {
            LuceneQueryLanguageSPI language = queryLanguages.get(searchParameters.getLanguage().toLowerCase());
            if (language != null)
            {
                return language.executQuery(searchParameters, this);
            }
            else
            {
                throw new SearcherException("Unknown query language: " + searchParameters.getLanguage());
            }
        }
    }
‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

I could do some more investigation and find out what is expected here:
PropertyDefinition propertyDef = getDictionaryService().getProperty(QName.createQName(field.substring(1)));

Re: Java backed webscript not working - upgrade 3.0 to 3.2r

mrogers — Fri, 28 May 2010 09:59:08 GMT

If you come to the conclusion that there is a bug in Alfresco please raise it in JIRA so that it can be fixed.
Even better would be to contribute your solution.

Re: Java backed webscript not working - upgrade 3.0 to 3.2r

lynnders — Fri, 28 May 2010 10:55:04 GMT

I've setup an account in Alfresco Jira. Do I 'Create Issue' here - https://issues.alfresco.com/jira/browse/ETHREEOH/fixforversion/10572 ?

I'm using the Community Version 3.2r

Re: Java backed webscript not working - upgrade 3.0 to 3.2r

lynnders — Fri, 28 May 2010 12:31:58 GMT

Raised in JIRA - https://issues.alfresco.com/jira/browse/ALF-3042

Re: Java backed webscript not working - upgrade 3.0 to 3.2r

dward — Mon, 02 Aug 2010 16:25:46 GMT

The error indicates that the property you are using as a sort field with namespace http://www.alfresco.org/alfresco/blog and short name "created" does not exist in the data model. Have you checked that there is a *Model.xml file that registers this property? Perhaps you haven't re-installed one of the amps you previously had installed?

Whilst the NPE isn't very helpful here, it is indicative of another problem.