topic BUG in Activiti or not? in Alfresco Archive

BUG in Activiti or not?

irenailievska1 — Thu, 14 Jan 2016 14:05:04 GMT

I created a very advanced custom workflow. The diagram is shown on this picture https://www.dropbox.com/s/9phdey2pd976weo/fullProcess.bmp?dl=0The process works as it is intended - no problem with the logic.It appears that if the user task is inside of an subprocess- alfresco stops showing the tasks

Re: BUG in Activiti or not?

jbarrez — Wed, 20 Jan 2016 22:39:41 GMT

Thanks for the kind words 🙂

It's hard to say … but it seems to be happening in the LazyActivitiWorkflowTask … which definitely is not an Activiti class.

The process, altough rich in exclusive gateways … doesn't seem to have anything odd in it.

Re: BUG in Activiti or not?

irenailievska1 — Mon, 25 Jan 2016 14:41:02 GMT

Do you have perhaps some idea what could be the problem?
I solved it in another way- so it won't show the red line, but I am still curious as to the reason behind this. I found another post like this and it wasn't solved either. I also wasn't able to find this LazyActivitiWorkflowTask class. It is strange. I also replaced the regular end events with TerminatedEndEvent, but it made no difference.
Thanks

Re: BUG in Activiti or not?

bjx123 — Wed, 11 May 2016 09:11:48 GMT

And how did you solf your probleme I have the same probleme with the subprocesses?

Re: BUG in Activiti or not?

irenailievska1 — Thu, 19 May 2016 13:17:43 GMT

Hi,
I replied to your message, but here it goes again:
I removed the subprocesses and also changed the code where I was assigning variables to null from the custom content model. This triggered the error in the places where I am in a loop.
Hope this helps

Re: BUG in Activiti or not?

hoecake — Tue, 22 Nov 2016 06:58:58 GMT

We have same problem , our process has bit complex defination with 3 level subprocess, looking forward to a way to resolve this error.

Re: BUG in Activiti or not?

tas100 — Wed, 08 Mar 2017 16:07:47 GMT

Same issue here, after a bit of investigation we have worked out the following:

It throws the NPE when a workflow has a user task defined in a subprocess.

The NPE is being thrown because taskDefinition is null in LazyActivitiWorkflowTask.

          // Fetch task-definition and a partially-initialized WorkflowTask (not including properties and path)
          WorkflowTaskDefinition taskDefinition = activitiTypeConverter.getTaskDefinition(historicTask.getTaskDefinitionKey(), historicTask.getProcessDefinitionId());
          
          String workflowDefinitionName = activitiTypeConverter.getWorkflowDefinitionName(historicTask.getProcessDefinitionId());
          workflowDefinitionName = tenantService.getBaseName(workflowDefinitionName);
          
          WorkflowTask partiallyInitialized = typeConverter.getWorkflowObjectFactory().createTask(historicTask.getId(), taskDefinition, taskDefinition.getId(), historicTask.getName(),
                    historicTask.getDescription(), WorkflowTaskState.COMPLETED, null, workflowDefinitionName , lazyPropertiesMap);‍‍‍‍‍‍‍‍

ActivitiTypeConverter.getTaskDefinition should populate taskDefinition:

    /**
     * Get the taskDefinition key based on the Activiti task definition id,
     * @param taskDefinitionKey String
     * @param processDefinitionId String
     * @return WorkflowTaskDefinition
     */
    public WorkflowTaskDefinition getTaskDefinition(String taskDefinitionKey, String processDefinitionId)
    {
          ProcessDefinitionEntity procDef = (ProcessDefinitionEntity) activitiUtil.getDeployedProcessDefinition(processDefinitionId);
          Collection<PvmActivity> userTasks = findUserTasks(procDef.getInitial());
          
          TaskDefinition taskDefinition = null;
          for(PvmActivity activity : userTasks)
          {
               taskDefinition = procDef.getTaskDefinitions().get(activity.getId());
               if(taskDefinitionKey.equals(taskDefinition.getKey()))
               {
                    String formKey = getFormKey(taskDefinition);
                    WorkflowNode node = convert(activity);
                    return factory.createTaskDefinition(formKey, node, formKey, false);
               }
          }
          
          return null;
    }‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

However this does not happen because ActivitiTypeConverter.findUserTasks does not find user tasks that have been defined under a subprocess:

    private void findUserTasks(PvmActivity currentActivity, Map<String, PvmActivity> userTasks, Set<String> processedActivities)
    {
        // Only process activity if not already processed, to prevent endless loops
        if(!processedActivities.contains(currentActivity.getId()))
        {
            processedActivities.add(currentActivity.getId());
            if(isUserTask(currentActivity)) 
            {
                userTasks.put(currentActivity.getId(), currentActivity);
            }
            
            // Process outgoing transitions
            if(currentActivity.getOutgoingTransitions() != null)
            {
                for(PvmTransition transition : currentActivity.getOutgoingTransitions())
                {
                    if(transition.getDestination() != null)
                    {
                        findUserTasks(transition.getDestination(), userTasks, processedActivities);
                    }
                }
            }
        }
    }‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

Looks like there is a bug in the above method as it is not looking for nested tasks.