topic DbSqlSession FlushInserts with Custom Entities in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229978#M183108 <HTML><HEAD></HEAD><BODY><SPAN>Hi awesome ppl,</SPAN><BR /><BR /><BR /><SPAN>I'm having a little strange error. I have two custom entities (HistoricProcessInstanceEntity and CommentEntity), when the process is finalized the method DbSqlSession.flushInserts() is called till were it's ok. <img id="smileyhappy" class="emoticon emoticon-smileyhappy" src="https://connect.hyland.com/i/smilies/16x16_smiley-happy.png" alt="Smiley Happy" title="Smiley Happy" /></SPAN><BR /><BR /><SPAN>But inside this method(flushInserts), there is a second for that iterates over the insertedObjects keySet to get the object class implementation. When this list of objects was more then one custom entity class, on the second key of the list this error occurs:</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR />java.util.ConcurrentModificationException: null<BR /> at java.util.HashMap$HashIterator.nextNode(Unknown Source)<BR /> at java.util.HashMap$KeyIterator.next(Unknown Source)<BR /> at org.activiti.engine.impl.db.DbSqlSession.flushInserts(DbSqlSession.java:796)<BR /> at org.activiti.engine.impl.db.DbSqlSession.flush(DbSqlSession.java:611)<BR /> at org.activiti.engine.impl.interceptor.CommandContext.flushSessions(CommandContext.java:212)<BR /> at org.activiti.engine.impl.interceptor.CommandContext.close(CommandContext.java:138)<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>This is happening because inside the method flushPersistentObjects a remove is done on the insertedObjects list.</SPAN><BR /><BR /><SPAN>I'm using Activiti 5.19.0.</SPAN><BR /><BR /><PRE class="language-java line-numbers"><CODE><BR />protected void flushInserts() {<BR />&nbsp; &nbsp;&nbsp;&nbsp;<BR />&nbsp; &nbsp;&nbsp;&nbsp;// Handle in entity dependency order<BR />&nbsp;&nbsp;&nbsp; for (Class&lt;? extends PersistentObject&gt; persistentObjectClass : EntityDependencyOrder.INSERT_ORDER) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (insertedObjects.containsKey(persistentObjectClass)) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;flushPersistentObjects(persistentObjectClass, insertedObjects.get(persistentObjectClass));<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; <BR />&nbsp;&nbsp;&nbsp; // Next, in case of custom entities or we've screwed up and forgotten some entity<BR />&nbsp;&nbsp;&nbsp; if (insertedObjects.size() &gt; 0) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; for (Class&lt;? extends PersistentObject&gt; persistentObjectClass : insertedObjects.keySet()) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;flushPersistentObjects(persistentObjectClass, insertedObjects.get(persistentObjectClass));<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; <BR />&nbsp;&nbsp;&nbsp; insertedObjects.clear();<BR />&nbsp; }<BR /><BR />&nbsp;&nbsp;&nbsp;protected void flushPersistentObjects(Class&lt;? extends PersistentObject&gt; persistentObjectClass, List&lt;PersistentObject&gt; persistentObjectsToInsert) {<BR />&nbsp;&nbsp;&nbsp;&nbsp; if (persistentObjectsToInsert.size() == 1) {<BR />&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;flushRegularInsert(persistentObjectsToInsert.get(0), persistentObjectClass);<BR />&nbsp;&nbsp;&nbsp;&nbsp; } else if (Boolean.FALSE.equals(dbSqlSessionFactory.isBulkInsertable(persistentObjectClass))) {<BR />&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;for (PersistentObject persistentObject : persistentObjectsToInsert) {<BR />&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;flushRegularInsert(persistentObject, persistentObjectClass);<BR />&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}<BR />&nbsp;&nbsp;&nbsp;&nbsp; }&nbsp;&nbsp;&nbsp;else {<BR />&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;flushBulkInsert(insertedObjects.get(persistentObjectClass), persistentObjectClass);<BR />&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp; insertedObjects.remove(persistentObjectClass);<BR />&nbsp; }<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>Dunno if i can change anything or call something before this custom entities inserts. To solve this problem.</SPAN><BR /><BR /><SPAN>Thanks.</SPAN><BR /><BR /></BODY></HTML> Mon, 14 Mar 2016 17:08:44 GMT goodboy 2016-03-14T17:08:44Z DbSqlSession FlushInserts with Custom Entities https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229978#M183108 Hi awesome ppl,I'm having a little strange error. I have two custom entities (HistoricProcessInstanceEntity and CommentEntity), when the process is finalized the method DbSqlSession.flushInserts() is called till were it's ok. <IMG id="smileyhappy" class="emoticon emoticon-smileyhappy" src="https://migration33.stage.lithium.com/i/smilies/16x16_smiley-happy.png" alt="Smiley Happy" title="Smiley Happy" />But inside this method(flushInserts), there is a second for that iterate Mon, 14 Mar 2016 17:08:44 GMT https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229978#M183108 goodboy 2016-03-14T17:08:44Z Re: DbSqlSession FlushInserts with Custom Entities https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229979#M183109 <HTML><HEAD></HEAD><BODY><SPAN>You're correct .. there shouldn't be a remove for the second one. Fixed here: </SPAN><A href="https://github.com/Activiti/Activiti/commit/b03e48f7f0adf970c67b37c2e4a6924ed36ce569" rel="nofollow noopener noreferrer">https://github.com/Activiti/Activiti/commit/b03e48f7f0adf970c67b37c2e4a6924ed36ce569</A><BR /></BODY></HTML> Tue, 15 Mar 2016 11:24:45 GMT https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229979#M183109 jbarrez 2016-03-15T11:24:45Z Re: DbSqlSession FlushInserts with Custom Entities https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229980#M183110 <HTML><HEAD></HEAD><BODY><SPAN><img id="smileyhappy" class="emoticon emoticon-smileyhappy" src="https://connect.hyland.com/i/smilies/16x16_smiley-happy.png" alt="Smiley Happy" title="Smiley Happy" /></SPAN><BR /><BR /><SPAN>Thanks! Joram</SPAN></BODY></HTML> Tue, 15 Mar 2016 12:04:35 GMT https://connect.hyland.com/t5/alfresco-archive/dbsqlsession-flushinserts-with-custom-entities/m-p/229980#M183110 goodboy 2016-03-15T12:04:35Z