topic Re: External authentication with a userIdPattern in Alfresco Archive

External authentication with a userIdPattern

lentinj — Fri, 15 Jan 2010 18:00:57 GMT

Hi,I've been following the instructions here:-http://wiki.alfresco.com/wiki/Alfresco_Authentication_Subsystems#External…to set up Alfresco to trust headers set by the upstream Apache.I've got:-alfresco-global.propertiesauthentication.chain=ssl-headers:external‍‍alfresco/extension/subsystems/Authenti

Re: External authentication with a userIdPattern

lentinj — Thu, 21 Jan 2010 18:31:44 GMT

Hrm, on closer investigation I think a bug renders this option useless. Tracing the execution the regex does make it's way to the relevant code, however:-


            Matcher matcher = this.userIdPattern.matcher(userId);
            if (matcher.matches())
            {
                userId = matcher.group().trim();
            }
‍‍‍‍‍‍‍

.group() returns the section of userId that userIdPattern matched. However, matches() will only succeed if it matches the entirety of the string, in which case matcher.group() == userId, and it's achieved nothing. I'd interpret the documentation as meaning:-


        Matcher matcher = this.userIdPattern.matcher(userId);
        if(matcher.find()) {
            userId = matcher.groupCount() > 0 ? matcher.group(1) : null;
        }  
‍‍‍‍‍‍

…and would be more useful if matcher.group() was returned instead of null. Any comments?

Re: External authentication with a userIdPattern

dward — Mon, 25 Jan 2010 17:43:17 GMT

I agree it should have used group(1). I have logged https://issues.alfresco.com/jira/browse/ETHREEOH-4036