topic Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor in Alfresco Archive

asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

chenyh — Wed, 11 May 2016 04:58:31 GMT

Hello, I recently integrated the latest Activiti 5.20.0 with my Web App using spring. part of my config file is just as follow: <bean id="asyncExecutor" class="org.activiti.engine.impl.asyncexecutor.DefaultAsyncJobExecutor"> <property name="corePoolSize" value="10" /> &l

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

chenyh — Fri, 13 May 2016 08:44:37 GMT

Any comment on my topic would be high appreciated!
I think this case is in common.

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

6pker — Fri, 13 May 2016 10:56:56 GMT

To be honest, I do want to do some help, but it's quite difficult to understand your question.

"After the lock time expired, I restart my activie engine, but no retry will executed!"

Only the jobs with RETRIES_ >= 0 and DUDATE_ is not null in ACT_RU_JOB will be retried.

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

chenyh — Mon, 16 May 2016 01:58:10 GMT

sorry, I detail my question:
When the activiti engine stopped during executing a service task(I marked the service task as asynchronized). in the RU_JOB table, a job data will like below:
TYPE_="message", DUE_DATA_=null, RETRIES_>0(default=3), LOCK_OWNER_=null and LOCK_EXP_TIME_=<some time.
When I restart the activiti engine after the LOCK_EXP_TIME_ , the JOB could not be selected by the async job executor. That means this process instance is hang there forever.
But if I switch the async job executor to jobexecutor, when the current time is later than LOCK_EXP_TIME_, the the job could be selected out and execute.
I deep the code, and find the job select sql for async job executor is below:
<code>
<select id="selectNextTimerJobsToExecute" parameterType="org.activiti.engine.impl.db.ListQueryParameterObject" resultMap="jobResultMap">
    ${limitBefore}
    select
      RES.* ${limitBetween}
    from ${prefix}ACT_RU_JOB RES
      LEFT OUTER JOIN ${prefix}ACT_RU_EXECUTION PI ON PI.ID_ = RES.PROCESS_INSTANCE_ID_
    where (RES.RETRIES_ > 0)
      and (RES.DUEDATE_ is null or RES.DUEDATE_ <= #{parameter, jdbcType=TIMESTAMP})
      and (RES.LOCK_OWNER_ is null or RES.LOCK_EXP_TIME_ <= #{parameter, jdbcType=TIMESTAMP})
      and TYPE_ = 'timer'
      and (
          (RES.EXECUTION_ID_ is null)
          or
          (PI.SUSPENSION_STATE_ = 1)
      )
    ${limitAfter}
</select>

<select id="selectAsyncJobsDueToExecute" parameterType="org.activiti.engine.impl.db.ListQueryParameterObject" resultMap="jobResultMap">
    ${limitBefore}
    select
      RES.* ${limitBetween}
    from ${prefix}ACT_RU_JOB RES
      LEFT OUTER JOIN ${prefix}ACT_RU_EXECUTION PI ON PI.ID_ = RES.PROCESS_INSTANCE_ID_
    where RES.RETRIES_ > 0
      and RES.DUEDATE_ is not null
      and RES.DUEDATE_ <= #{parameter, jdbcType=TIMESTAMP}
      and (RES.LOCK_EXP_TIME_ is null or RES.LOCK_EXP_TIME_ <= #{parameter, jdbcType=TIMESTAMP})
      and TYPE_ = 'message'
      and (
          (RES.EXECUTION_ID_ is null)
          or
          (PI.SUSPENSION_STATE_ = 1)
      )
    ${limitAfter}
</select>
</code>
and the sql for jobexecutor is below:
<code>
<select id="selectNextJobsToExecute" parameterType="org.activiti.engine.impl.db.ListQueryParameterObject" resultMap="jobResultMap">
   ${limitBefore}
    select
     RES.* ${limitBetween}
    from ${prefix}ACT_RU_JOB RES
     LEFT OUTER JOIN ${prefix}ACT_RU_EXECUTION PI ON PI.ID_ = RES.PROCESS_INSTANCE_ID_
    where (RES.RETRIES_ > 0)
      and (RES.DUEDATE_ is null or RES.DUEDATE_ <= #{parameter, jdbcType=TIMESTAMP})
      and (RES.LOCK_OWNER_ is null or RES.LOCK_EXP_TIME_ <= #{parameter, jdbcType=TIMESTAMP})
     and (
        (RES.EXECUTION_ID_ is null)
       or
       (PI.SUSPENSION_STATE_ = 1)
      )
    ${limitAfter}
</select>
</code>

So my question is why they are different, is there any reason for the async job executor not to select the expired job out?

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

martin_grofcik — Mon, 16 May 2016 13:11:31 GMT

Hi chenyh,

Is it possible to reproduce the issue in the jUnit test please?
https://forums.activiti.org/content/sticky-how-write-unit-test

Regards
Martin

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

chenyh — Thu, 19 May 2016 01:00:19 GMT

Hi Martin, my issue use the async job executor and non memory db (H2), and I need to shutdown the engine during the service task executing.
So I think it's hard to write all these in a jUnit test case.
How about write some sample? Or package these in spring boot? (It's really need some works)

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

jbarrez — Thu, 26 May 2016 13:29:25 GMT

Sure, samples that clearly demonstrate a problem are always valuable!

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

louisj — Mon, 30 May 2016 07:19:00 GMT

I am experiencing the exact same problem when using the Activiti async job executor.
Looks like service tasks which were busy executing at the time that my server is rebooted, do not get picked up by the async job executor when the Activiti engine starts up again. I am using Activiti 5.20.0.

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

jbarrez — Fri, 03 Jun 2016 07:05:23 GMT

> Looks like service tasks which were busy executing at the time that my server is rebooted, do not get picked up by the async job executor when the Activiti engine starts up again. I am using Activiti 5.20.0.

That shouldn't happen: if that situation arises, the current transaction is rolled back to the previous wait state and the job will be retried later on.

Is there anything special about this service task? or is it a regular java call with setting/getting some vars.?

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

louisj — Thu, 09 Jun 2016 06:38:35 GMT

Task is asynchronous and exclusive
Task type = expression
Expression = call to method on Spring bean annotated with @Component and @Transactional
Inside the Spring bean method I:
- Read process variables from the DelegateExecution object that is passed in
- Call a stored procedure on Oracle database
- Persist records to a table
- Set variables on the DelegateExecution object that is passed in

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

jbarrez — Mon, 20 Jun 2016 12:11:27 GMT

No.. that's fairly simple. We did however make some improvements in this area around picking up lost jobs in 5.21.

Re: asyncJobLockTimeInMillis not work in DefaultAsyncJobExecutor

louisj — Mon, 04 Jul 2016 11:55:17 GMT

Thank you. I see the following in the release notes of 5.21.0:
[ACT-4190] - Job with null due date is never picked up again
Will upgrade and let you know if I get the issue again.