topic Why is FileFolderService#makeFolders deprecated? in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219808#M172938 <HTML><HEAD></HEAD><BODY><SPAN>Hi folks,</SPAN><BR /><BR /><SPAN>just wondered why method makeFolders() in interface org.alfresco.repo.model.filefolder.FileFolderService is marked as deprecated?&nbsp; :? </SPAN><BR /><SPAN>Instead, a </SPAN><STRONG>static </STRONG><SPAN>method makeFolders() is provided in FileFolderServiceImpl, which is also used by the deprectated method:</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE>public class FileFolderServiceImpl implements FileFolderService<BR />{<BR />&nbsp;&nbsp; …<BR />&nbsp;&nbsp;&nbsp; public static FileInfo makeFolders(FileFolderService service, NodeRef parentNodeRef, List&lt;String&gt; pathElements, QName folderTypeQName)<BR />&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; …..<BR />&nbsp;&nbsp;&nbsp; }<BR /><BR />&nbsp;&nbsp;&nbsp; public FileInfo makeFolders(NodeRef parentNodeRef, List&lt;String&gt; pathElements, QName folderTypeQName)<BR />&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return FileFolderServiceImpl.makeFolders(this, parentNodeRef, pathElements, folderTypeQName);<BR />&nbsp;&nbsp;&nbsp; }<BR />}<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><SPAN>This doesnt seem to make sense for me for several reasons:</SPAN><BR /><BR /><SPAN>- The static method makeFolders() should be rather called "pseudo-static", as it gets an artificial this reference passed! There is no reason why it shouldn't be a method of FileFolderServiceImpl as it was before!</SPAN><BR /><BR /><SPAN>- By forcing users to call a method in the implementation class, the usual separation between interfaces and implementation classes is broken for no reason.</SPAN><BR /><BR /><SPAN>Maybe&nbsp; there is some reason why this method exists as static, but at least the @deprecated annotation should be removed, IMHO</SPAN><BR /><BR /><SPAN>Cheers</SPAN><BR /><SPAN>Gyro</SPAN></BODY></HTML> Wed, 05 May 2010 13:08:24 GMT gyro_gearless 2010-05-05T13:08:24Z Why is FileFolderService#makeFolders deprecated? https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219808#M172938 Hi folks,just wondered why method makeFolders() in interface org.alfresco.repo.model.filefolder.FileFolderService is marked as deprecated?&nbsp; :? Instead, a static method makeFolders() is provided in FileFolderServiceImpl, which is also used by the deprectated method<IMG id="smileytongue" class="emoticon emoticon-smileytongue" src="https://migration33.stage.lithium.com/i/smilies/16x16_smiley-tongue.png" alt="Smiley Tongue" title="Smiley Tongue" />ublic class FileFolderServiceImpl Wed, 05 May 2010 13:08:24 GMT https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219808#M172938 gyro_gearless 2010-05-05T13:08:24Z Re: Why is FileFolderService#makeFolders deprecated? https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219809#M172939 <HTML><HEAD></HEAD><BODY><SPAN>I think I agree with you.&nbsp;&nbsp; I'll talk to my collegues to see if anyone remembers changing it.</SPAN></BODY></HTML> Wed, 05 May 2010 16:51:40 GMT https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219809#M172939 mrogers 2010-05-05T16:51:40Z Re: Why is FileFolderService#makeFolders deprecated? https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219810#M172940 <HTML><HEAD></HEAD><BODY><SPAN>There was a good reason which was that it was due to to security and auditing requirements as the makeFolders method walked down the path.</SPAN><BR /><BR /><SPAN>So I'm not going to un-deprecate makeFolders on FileFolderService.&nbsp; In fact I'm going to remove this long deprecated method entirely from the FileFolders interface.</SPAN><BR /><BR /><SPAN>Since I agree that its bad form to have to directly access an implementation class I'm also going to deprecate FileFolderServiceImpl.makeFolders and move the code to a separate utility class.</SPAN></BODY></HTML> Thu, 13 May 2010 15:52:35 GMT https://connect.hyland.com/t5/alfresco-archive/why-is-filefolderservice-makefolders-deprecated/m-p/219810#M172940 mrogers 2010-05-13T15:52:35Z