topic CommendContext Error handling? in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/commendcontext-error-handling/m-p/215095#M168225 <HTML><HEAD></HEAD><BODY><SPAN>I understand from </SPAN><A _jive_internal="true" href="https://community.alfresco.com/content/behavior-process-when-has-throw-exceptions" rel="nofollow noopener noreferrer">BpmnError catching</A><SPAN> that JavaDelegates should throw a BpmnError when catching an exception.</SPAN><BR /><BR /><SPAN>But what if it's an uncaught exception (NullPointer, ClassCast, etc). Accidents can happen, after all.</SPAN><BR /><BR /><SPAN>Presently </SPAN><A href="https://github.com/Activiti/Activiti/blob/master/modules/activiti-engine/src/main/java/org/activiti/engine/impl/interceptor/CommandContext.java#L171" rel="nofollow noopener noreferrer">CommandContext</A><SPAN> logs this as a DEBUG level… That's not ideal. Optimistic locking exceptions should be at INFO, and all other exceptions should be at ERROR.</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR />if (exception != null) {<BR />&nbsp; if (exception instanceof JobNotFoundException || exception instanceof ActivitiTaskAlreadyClaimedException) {<BR />&nbsp;&nbsp;&nbsp; // reduce log level, because this may have been caused because of job deletion due to cancelActiviti="true"<BR />&nbsp;&nbsp;&nbsp; log.info("Error while closing command context", exception);<BR />&nbsp; } else if (exception instanceof ActivitiOptimisticLockingException) {<BR />&nbsp;&nbsp;&nbsp; // reduce log level, as normally we're not interested in logging this exception<BR />&nbsp;&nbsp;&nbsp; log.debug("Optimistic locking exception : " + exception);<BR />&nbsp; } else {<BR />&nbsp;&nbsp;&nbsp; log.debug("Error while closing command context", exception);<BR />&nbsp; }<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /></BODY></HTML> Thu, 07 Jul 2016 13:08:23 GMT jonnyg 2016-07-07T13:08:23Z CommendContext Error handling? https://connect.hyland.com/t5/alfresco-archive/commendcontext-error-handling/m-p/215095#M168225 I understand from BpmnError catching that JavaDelegates should throw a BpmnError when catching an exception.But what if it's an uncaught exception (NullPointer, ClassCast, etc). Accidents can happen, after all.Presently CommandContext logs this as a DEBUG level… That's not ideal. Optimistic locking Thu, 07 Jul 2016 13:08:23 GMT https://connect.hyland.com/t5/alfresco-archive/commendcontext-error-handling/m-p/215095#M168225 jonnyg 2016-07-07T13:08:23Z Re: CommendContext Error handling? https://connect.hyland.com/t5/alfresco-archive/commendcontext-error-handling/m-p/215096#M168226 <HTML><HEAD></HEAD><BODY><SPAN>Hi,</SPAN><BR /><BR /><SPAN>I think your point about the log level for the other exceptions is correct. We've changed it just now.</SPAN><BR /><SPAN>For Optimistic locking exceptions the log level is set to debug on purpose. The Engine will handle optimstic locking exceptions and the log message is mainly useful in debugging cases.</SPAN><BR /><BR /><SPAN>Best regards,</SPAN></BODY></HTML> Mon, 18 Jul 2016 10:34:17 GMT https://connect.hyland.com/t5/alfresco-archive/commendcontext-error-handling/m-p/215096#M168226 trademak 2016-07-18T10:34:17Z