topic Form property missing when BPMN Model converted to XML in Alfresco Archive

Form property missing when BPMN Model converted to XML

vgaur — Fri, 27 Nov 2015 12:26:24 GMT

Hi,I am trying to generate XML from BPMN model. I have a user task which has a Form Definition which in turn contains several properties.when I convert this model into XML , I don't see the extension tag. All form properties are missing in the generated xml.Do I need to set any special flag or somet

Re: Form property missing when BPMN Model converted to XML

vgaur — Fri, 27 Nov 2015 12:56:19 GMT

I just run test case in BPMN converter module and its creating the form properties properly. To give you more insight, I am using activiti-simple-workflow , creating workflow definition (with form properties) and converting it in XML.

Re: Form property missing when BPMN Model converted to XML

vgaur — Fri, 27 Nov 2015 13:06:47 GMT

OK So I get this.
FormProperty id is a mandatory property and in simple-workflow-converter , when we convert HumanStep we set the id in formProperty with the name of formPropertyDefinition
<code>
formProperty.setId(propertyDefinition.getName());
</code>

Re: Form property missing when BPMN Model converted to XML

trademak — Mon, 30 Nov 2015 07:44:16 GMT

So the issue is resolved?

Re: Form property missing when BPMN Model converted to XML

vgaur — Sat, 05 Dec 2015 09:11:16 GMT

Yes Tijs,

I was not setting the name in FormPropertyDefinition and when I converted it into bpmn xml , the form properties were missing.
When I debugged I found that in org.activiti.bpmn.converter.BaseBpmnXMLConverter.writeFormProperties() there is check for id
<code> if (StringUtils.isNotEmpty(property.getId())) </code> .

So that means in FormPropertyDefinition name is a mandatory property. Ideally it should fail fast if name is not present. Also we should check if id is missing then only set id with name.

I have fixed few such issues and would like that to contribute if that helps.

Re: Form property missing when BPMN Model converted to XML

jbarrez — Tue, 08 Dec 2015 19:33:36 GMT

All contributions are more than welcome! Looking forward to the pull request 😉