topic process instances must not be created from suspended process definitions via signals in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/process-instances-must-not-be-created-from-suspended-process/m-p/213709#M166839 <HTML><HEAD></HEAD><BODY><P>Activiti does allow process instance creation from suspended process definition when the process instance is created via a signal. However, using message or Runtime services this does not happen. In fact, this a bug. When handling a signal leading to the creation of process instance, the process definition is not checked for suspension as is &nbsp;the case with message and runtime process instance creation.</P><P></P><P>I am using activiti.5.21.1.&nbsp;</P><P></P><P>The issue is in <SPAN>org.activiti.engine.impl.event.</SPAN><SPAN>SignalEventHandler, it does not check for process definition suspension.</SPAN></P><P></P><P>My fix is below. I hope you can add that to the base code so that we can have it in next release.</P><P></P><P>/* Licensed under the Apache License, Version 2.0 (the "License");<BR /> * you may not use this file except in compliance with the License.<BR /> * You may obtain a copy of the License at<BR /> * <BR /><SPAN> * </SPAN><A class="jive-link-external-small" href="http://www.apache.org/licenses/LICENSE-2.0" rel="nofollow noopener noreferrer" target="_blank">http://www.apache.org/licenses/LICENSE-2.0</A><BR /> * <BR /> * Unless required by applicable law or agreed to in writing, software<BR /> * distributed under the License is distributed on an "AS IS" BASIS,<BR /> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<BR /> * See the License for the specific language governing permissions and<BR /> * limitations under the License.<BR /> */</P><P>package org.activiti.engine.impl.event;</P><P>import java.util.Map;</P><P>import org.activiti.engine.ActivitiException;<BR />import org.activiti.engine.ActivitiObjectNotFoundException;<BR />import org.activiti.engine.impl.context.Context;<BR />import org.activiti.engine.impl.interceptor.CommandContext;<BR />import org.activiti.engine.impl.persistence.deploy.DeploymentManager;<BR />import org.activiti.engine.impl.persistence.entity.EventSubscriptionEntity;<BR />import org.activiti.engine.impl.persistence.entity.ExecutionEntity;<BR />import org.activiti.engine.impl.persistence.entity.ProcessDefinitionEntity;<BR />import org.activiti.engine.impl.pvm.process.ActivityImpl;<BR />import org.activiti.engine.repository.ProcessDefinition;</P><P></P><P>/**<BR /> * @author Daniel Meyer<BR /> * @author Joram Barrez<BR /> */<BR />public class SignalEventHandler extends AbstractEventHandler {<BR /> <BR /> public static final String EVENT_HANDLER_TYPE = "signal";</P><P>public String getEventHandlerType() {<BR /> return EVENT_HANDLER_TYPE;<BR /> }<BR /> <BR /> @Override<BR /> public void handleEvent(EventSubscriptionEntity eventSubscription, Object payload, CommandContext commandContext) {<BR /> if (eventSubscription.getExecutionId() != null) {<BR /> super.handleEvent(eventSubscription, payload, commandContext);<BR /> } else if (eventSubscription.getProcessDefinitionId() != null) {<BR /> // Start event<BR /> String processDefinitionId = eventSubscription.getProcessDefinitionId();<BR /> DeploymentManager deploymentCache = Context<BR /> .getProcessEngineConfiguration()<BR /> .getDeploymentManager();<BR /> <BR /> ProcessDefinitionEntity processDefinition = deploymentCache.findDeployedProcessDefinitionById(processDefinitionId);<BR /> if (processDefinition == null) {<BR /> throw new ActivitiObjectNotFoundException("No process definition found for id '" + processDefinitionId + "'", ProcessDefinition.class);<BR /> }<BR /> if (processDefinition.isSuspended()) {<BR /> throw new ActivitiException("Could not handle signal: process definition with id: " + processDefinitionId + " is suspended");<BR /> }<BR /> <BR /> ActivityImpl startActivity = processDefinition.findActivity(eventSubscription.getActivityId());<BR /> if (startActivity == null) {<BR /> throw new ActivitiException("Could no handle signal: no start activity found with id " + eventSubscription.getActivityId());<BR /> }<BR /> ExecutionEntity processInstance = processDefinition.createProcessInstance(null, startActivity);<BR /> if (processInstance == null) {<BR /> throw new ActivitiException("Could not handle signal: no process instance started");<BR /> }<BR /> <BR /> if (payload != null) {<BR /> if (payload instanceof Map) {<BR /> Map&lt;String, Object&gt; variables = (Map&lt;String, Object&gt;) payload;<BR /> processInstance.setVariables(variables);<BR /> }<BR /> }<BR /> <BR /> processInstance.start();<BR /> } else {<BR /> throw new ActivitiException("Invalid signal handling: no execution nor process definition set");<BR /> }<BR /> }</P><P>}</P></BODY></HTML> Wed, 14 Dec 2016 21:21:53 GMT dan_ 2016-12-14T21:21:53Z process instances must not be created from suspended process definitions via signals https://connect.hyland.com/t5/alfresco-archive/process-instances-must-not-be-created-from-suspended-process/m-p/213709#M166839 Activiti does allow process instance creation from suspended process definition when the process instance is created via a signal. However, using message or Runtime services this does not happen. In fact, this a bug. When handling a signal leading to the creation of process instance, the process def Wed, 14 Dec 2016 21:21:53 GMT https://connect.hyland.com/t5/alfresco-archive/process-instances-must-not-be-created-from-suspended-process/m-p/213709#M166839 dan_ 2016-12-14T21:21:53Z Re: process instances must not be created from suspended process definitions via signals https://connect.hyland.com/t5/alfresco-archive/process-instances-must-not-be-created-from-suspended-process/m-p/213710#M166840 <HTML><HEAD></HEAD><BODY><P>Here is a pull request: <A class="link-titled" href="https://github.com/Activiti/Activiti/pull/1085" title="https://github.com/Activiti/Activiti/pull/1085" rel="nofollow noopener noreferrer">Fix for process instance created via signal from a suspended process … by HamdanMsheik · Pull Request #1085 · Activiti/A…</A>&nbsp;</P></BODY></HTML> Thu, 15 Dec 2016 04:25:55 GMT https://connect.hyland.com/t5/alfresco-archive/process-instances-must-not-be-created-from-suspended-process/m-p/213710#M166840 dan_ 2016-12-15T04:25:55Z