topic [solved] Wrong message output in UsersBean.java in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/solved-wrong-message-output-in-usersbean-java/m-p/209105#M162235 <HTML><HEAD></HEAD><BODY><SPAN>When changing user password and setting wrong old password, a scaring message appears on the web client : 20 red lines of stack trace on the explorer where as it is a human error !</SPAN><BR /><SPAN>I read in alfresco 2.2.0 source code, a portion of code in part of repository service, responsible of this big red message (AuthenticationComponentImpl.java):</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE>/**<BR />&nbsp;&nbsp;&nbsp;&nbsp; * Authenticate<BR />&nbsp;&nbsp;&nbsp;&nbsp; */<BR />&nbsp;&nbsp;&nbsp; protected void authenticateImpl(String userName, char[] password) throws AuthenticationException<BR />&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; try<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; UsernamePasswordAuthenticationToken authentication = new UsernamePasswordAuthenticationToken(userName,<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; new String(password));<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; authenticationManager.authenticate(authentication);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; setCurrentUser(userName);<BR /><BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; catch (net.sf.acegisecurity.AuthenticationException ae)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // This is a bit gross, I admit, but when LDAP is <BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // configured ae, above, is non-serializable and breaks<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // remote authentication.<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; StringWriter sw = new StringWriter();<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; PrintWriter out = new PrintWriter(sw);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; out.println([b]ae.toString()[/b]);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ae.printStackTrace(out);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; out.close();<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; throw new AuthenticationException(sw.toString());<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; }<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><SPAN>The exception is caught in the method below in UsersBean.java when old password is wrong</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE>/**<BR />&nbsp;&nbsp;&nbsp; * Action handler called for OK button press on Change My Password screen<BR />&nbsp;&nbsp;&nbsp; * For this screen the user is required to enter their old password - effectively login.<BR />&nbsp;&nbsp;&nbsp; */<BR />&nbsp;&nbsp; public String changeMyPasswordOK()<BR />&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; String outcome = DIALOG_CLOSE;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (this.password != null &amp;&amp; this.confirm != null &amp;&amp; this.password.equals(this.confirm))<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; try<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; String userName = (String)this.person.getProperties().get(ContentModel.PROP_USERNAME);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; this.getAuthenticationService().updateAuthentication(userName, this.oldPassword.toCharArray(), this.password.toCharArray());<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; catch (Exception e)<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; outcome = null;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Utils.addErrorMessage(MessageFormat.format(Application.getMessage(FacesContext<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; .getCurrentInstance(), Repository.ERROR_GENERIC), [b]e.getMessage()[/b]), e);<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; else<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; outcome = null;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Utils.addErrorMessage(Application.getMessage(FacesContext.getCurrentInstance(),<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ERROR_PASSWORD_MATCH));<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return outcome;<BR />&nbsp;&nbsp; }<SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><SPAN>The problem is that the web client receive the horrible stack trace coming from the repository service (cf. </SPAN><STRONG>…</STRONG><SPAN> tags in code portions above)</SPAN><BR /><SPAN>It lacks of a good translation of this "human error" message.</SPAN></BODY></HTML> Wed, 18 Feb 2009 16:50:44 GMT zomurn 2009-02-18T16:50:44Z [solved] Wrong message output in UsersBean.java https://connect.hyland.com/t5/alfresco-archive/solved-wrong-message-output-in-usersbean-java/m-p/209105#M162235 When changing user password and setting wrong old password, a scaring message appears on the web client : 20 red lines of stack trace on the explorer where as it is a human error !I read in alfresco 2.2.0 source code, a portion of code in part of repository service, responsible of this big red messa Wed, 18 Feb 2009 16:50:44 GMT https://connect.hyland.com/t5/alfresco-archive/solved-wrong-message-output-in-usersbean-java/m-p/209105#M162235 zomurn 2009-02-18T16:50:44Z Re: [solved] Wrong message output in UsersBean.java https://connect.hyland.com/t5/alfresco-archive/solved-wrong-message-output-in-usersbean-java/m-p/209106#M162236 <HTML><HEAD></HEAD><BODY><SPAN>This bug has been corrected in 2.2 SP2 (sure)</SPAN></BODY></HTML> Wed, 25 Feb 2009 16:34:07 GMT https://connect.hyland.com/t5/alfresco-archive/solved-wrong-message-output-in-usersbean-java/m-p/209106#M162236 zomurn 2009-02-25T16:34:07Z