topic Re: [SOLVED] Third-party review doesn't work well in Alfresco Archive

[SOLVED] Third-party review doesn't work well

Thu, 12 Mar 2009 16:06:41 GMT

Hi everybody I am currently ready Alfresco Developer Guide. I'm ready chapter 7, about the advanced workflows. I made a workflow that works well. Here comes the diagram:http://www.benichka.fr/images/processimage.jpgWhen Operation Review and Marketing Review approve a file, an email is sent to a Th

Re: [SOLVED] Third-party review doesn't work well

jayjayecl — Thu, 12 Mar 2009 16:56:23 GMT

could you please provide us with the definition of your webscript in the webscript-application-context.xml …

Re: [SOLVED] Third-party review doesn't work well

mrogers — Fri, 13 Mar 2009 00:00:08 GMT

I agree with JayJayECL that you need to provide more input.

Do you see the result of logger.debug("Signal sent."); ?
Does your workflow have script components - if it does let's see it.
Is there a stacktrace in the logfile. Lets see it.

Although not the cause of your problem, I do note that if "id" or "action" are null you set status and then carry on regardless :wink:

Re: [SOLVED] Third-party review doesn't work well

Fri, 13 Mar 2009 08:54:29 GMT

Thanks for your replies
@JeyJeyECL:
- I didn't touch the file web-script-application-context.xml. I created a someco-script-context.xml file that is located in config/alfresco/extension/. :
someco-scripts-context.xml:


<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE beans PUBLIC '-//SPRING//DTD BEAN//EN' 'http://www.springframework.org/dtd/spring-beans.dtd'>

<beans>
   <bean id="webscript.com.someco.bpm.review.get" class="com.someco.scripts.GetReview" parent="webscript">
      <property name="workflowService">
         <ref bean="WorkflowService" />
      </property>
   </bean>
</beans>
‍‍‍‍‍‍‍‍‍‍‍‍

Actually I done what was written on the book :s (I didn't create extra files or modify something that weren't supposed to be ^^')

@mrogers:
I inserted the line:


logger.debug("id: " + id + "\r\n" + "action: " + action);
‍‍‍

Just after declaring the strings id and action in the class GetReview.java. Guess what ? the line didn't show up in the log:


09:36:41,921 DEBUG [com.someco.bpm.ExternalReviewNotification] Mail action executed
09:37:41,750 INFO  [org.alfresco.web.scripts.AbstractRuntime] Caught exception & redirecting to status template: Wrapped Exception (with status template): null
‍‍‍‍

(I declared my logger in the log4j.properties files, if you're asking):


# Mail Getter reviewer
log4j.logger.com.someco.scripts.GetReview=debug
‍‍‍‍

The first line indicates that the mail is sent (which is normal because I received it lol).
The second line is the exception

Also, if id or action are, I think that status is not set but that's right, the method carry on…No a perfect way to do thing, but it's an example in the book

script component? don't know that yet :s (or not in these terms)

And noooooo there is no stacktrace, the error is even harder to decrypt

I think that my scripts didn't call well my class, I'm gonna take a look…

Thanks for helping

Re: [SOLVED] Third-party review doesn't work well

Fri, 13 Mar 2009 09:26:48 GMT

Errrrrrrrrr I don't know what I've done, but it works

I forgot to instantiate well the logger:


logger = Logger.getLogger(GetReview.class);
‍‍‍

I've done it, it solved it…

I just don't know why a logger that isn't instantiate can block a whole script, but nevermind, it's solved

Thanks for your help

Re: [SOLVED] Third-party review doesn't work well

prethi — Wed, 23 Sep 2009 11:10:41 GMT

Hi everyone..
I followed the steps as described in advanced workflow article…..
Mail is gettng sent with the transition links perfectly…
But when i click on it…no necessary action is action….
i think i have missed out something…
but couldn't get wat is that????
can anyone please help if u have tried this…

Thanks in advance..

Re: [SOLVED] Third-party review doesn't work well

khinendra — Wed, 18 Nov 2009 05:44:37 GMT

Hi,

I did the same descibed above but I am unable to send mail.
I am getting the null poiner exception from ExternalReviewNotification.

A brief Stack trace I am writting below.

18:49:07,235 ERROR [org.jbpm.graph.def.GraphElement] action threw exception: null
java.lang.NullPointerException

18:49:07,265 ERROR [org.alfresco.web.ui.common.Utils] A system error happened during the operation: Failed to signal transition 'Approve' from workflow task 'jbpm$51'
org.alfresco.service.cmr.workflow.WorkflowException: Failed to signal transition 'Approve' from workflow task 'jbpm$51'

Caused by: org.jbpm.graph.def.DelegationException
   at org.jbpm.graph.def.GraphElement.raiseException(GraphElement.java:387)

Caused by: java.lang.NullPointerException
   at com.tcs.bpm.ExternalReviewNotification.execute(ExternalReviewNotification.java:60)

getting null pointer exception from below line of class ExternalReviewNotification.java
      Action mailAction = this.actionService.createAction(MailActionExecuter.NAME);

Please resond

Regard,

Khinendra