topic Re: How to Name Sequence Flow and make them visible on generated diagram in Alfresco Archive

How to Name Sequence Flow and make them visible on generated diagram

smadhu — Mon, 28 Jul 2014 05:26:56 GMT

Hi, Iam stuck. I need help in naming SequenceFlows. When I use Eclipse Designer Iam able to name Sequence Flows and Also see them in the diagram inside the IDE.But now the problem is, I have written a small program to generate BPM diagram using Activiti. It works perfectly, but in the genera

Re: How to Name Sequence Flow and make them visible on generated diagram

frederikherema1 — Tue, 29 Jul 2014 13:07:54 GMT

That feature is currently not supported in the DiagramGenerator. However, I saw a pull-request passing by related to this: https://github.com/Activiti/Activiti/pull/331

Re: How to Name Sequence Flow and make them visible on generated diagram

smadhu — Sat, 02 Aug 2014 12:01:28 GMT

Hi,
I downloaded 5.16 based on your suggestion and tried the above code example

(flow.setName("x > 10"));

it still does not gets displayed in generated png diagram. Not sure if this feature has been enabled. Can u suggest me how to get this done, is there any alternative.

thanks in advance

Re: How to Name Sequence Flow and make them visible on generated diagram

frederikherema1 — Wed, 06 Aug 2014 08:17:31 GMT

If you look at the https://github.com/Activiti/Activiti/pull/331 comments and state, it's clear that this is not included in the 5.16 release.

Re: How to Name Sequence Flow and make them visible on generated diagram

ruckenhof — Wed, 06 Aug 2014 14:04:04 GMT

Hi Sudarshan! I've encountered the same problem and I've found that small changes in the sourcecode of activiti-image-generator-5.16.jar will do the trick. Recompile it in Eclipse or contact me: the.measurer@gmail.com.

In org.activiti.image.impl.DefaultProcessDiagramCanvas.java:
1) find method "public void drawLabel(String text, GraphicInfo graphicInfo, boolean centered)"
2) str 1105: replace "int textY = (int) (graphicInfo.getY() + graphicInfo.getHeight());" with "int textY = (int) graphicInfo.getY();"
3) str 1119: replace "double tY = graphicInfo.getY();" with "double tY = graphicInfo.getX();"

In org.activiti.image.impl.DefaultProcessDiagramGenerator.java:
1) find method "protected void drawActivity( …args here )"
2) str 566: comment the line "GraphicInfo lineCenter = getLineCenter(graphicInfoList);"
3) str 567: replace "processDiagramCanvas.drawLabel(sequenceFlow.getName(), lineCenter, false);" with "processDiagramCanvas.drawLabel(sequenceFlow.getName(), labelGraphicInfo, false);"

That should fix horizontal and vertical alignment of your labels. Hope this will help you!

Re: How to Name Sequence Flow and make them visible on generated diagram

shar — Wed, 06 Aug 2014 14:04:04 GMT

Yes. It works. Thank you very much.
Probably needs to be done to fix initProcessDiagramCanvas. Labels at the bottom boundary of the diagram are cut off.
I still do not understand where I need to fix it.

Re: How to Name Sequence Flow and make them visible on generated diagram

ruckenhof — Wed, 06 Aug 2014 14:21:55 GMT

Glad to help! You're right about initProcessDiagramCanvas, its logic doesn't take existence of labels into account, so they're cut off when they are too far beyond other elements.

Modify it like that:
1) add initialization of label's GraphicInfo after line 727:
"GraphicInfo labelGraphicInfo = bpmnModel.getLabelGraphicInfo(sequenceFlow.getId());"
2) add the next snippet immediately after, before the declaration of graphicInfoList and appropriate for-loop:
          if (labelGraphicInfo.getX() + labelGraphicInfo.getWidth() > maxX) {
            maxX = labelGraphicInfo.getX() + labelGraphicInfo.getWidth();
          }
          if (labelGraphicInfo.getX() < minX) {
            minX = labelGraphicInfo.getX();
          }
          if (labelGraphicInfo.getY() + labelGraphicInfo.getHeight() > maxY) {
            maxY = labelGraphicInfo.getY() + labelGraphicInfo.getHeight();
          }
          if (labelGraphicInfo.getY() < minY) {
            minY = labelGraphicInfo.getY();
          }

It should push the boundaries of canvas if necessary.

Re: How to Name Sequence Flow and make them visible on generated diagram

shar — Thu, 07 Aug 2014 05:25:26 GMT

Thank you again. Now everything looks fine.
It is only necessary to insert the check
if (labelGraphicInfo! = null) {
before the snippet.
Like this

if(labelGraphicInfo != null){
if (labelGraphicInfo.getX() + labelGraphicInfo.getWidth() > maxX) {
maxX = labelGraphicInfo.getX() + labelGraphicInfo.getWidth();
}
if (labelGraphicInfo.getX() < minX) {
minX = labelGraphicInfo.getX();
}
if (labelGraphicInfo.getY() + labelGraphicInfo.getHeight() > maxY) {
maxY = labelGraphicInfo.getY() + labelGraphicInfo.getHeight();
}
if (labelGraphicInfo.getY() < minY) {
minY = labelGraphicInfo.getY();
}
}

Re: How to Name Sequence Flow and make them visible on generated diagram

shar — Thu, 07 Aug 2014 05:36:56 GMT

I wonder when these changes will appear in the standard version. Only 5.17? In October?

Re: How to Name Sequence Flow and make them visible on generated diagram

smadhu — Thu, 07 Aug 2014 11:51:04 GMT

Hi Ruckenhof ,

Thanks for your response, really appreciate your help. I tried as you have mentioned above. But still the label does not gets displayed in the diagram. I have attached my class, the modified files (as you have mentioned above), I'm not sure what's happening, Can you please me out.

thanks

Re: How to Name Sequence Flow and make them visible on generated diagram

shar — Fri, 08 Aug 2014 10:24:05 GMT

I think that the problem solved (Ruckenhof) is not relevant to your situation. It seems to me that the problem lies in the error Activiti Engine. Indeed, the generated PNG, names sequences are absent.
Indeed, in the case of dynamic (via API) describe the process of creating the names of sequences apparently formed incomplete. And therefore are not shown. I can not say exactly why.
However, in my opinion, the case https://github.com/Activiti/Activiti/pull/331 also not relevant to your situation. There is debate about the show names of sequences in Diagram viewer and corrections are included in the file js.

In org.activiti.image.impl.DefaultProcessDiagramCanvas.java:
If replace snippet

            GraphicInfo labelGraphicInfo = bpmnModel.getLabelGraphicInfo(sequenceFlow.getId());
            if (labelGraphicInfo != null) {
                processDiagramCanvas.drawLabel(sequenceFlow.getName(), labelGraphicInfo, false);
            }

with
            GraphicInfo labelGraphicInfo = bpmnModel.getLabelGraphicInfo(sequenceFlow.getId());
            List<GraphicInfo> gi = bpmnModel.getFlowLocationGraphicInfo(sequenceFlow.getId());
            if (labelGraphicInfo != null) {
                processDiagramCanvas.drawLabel(sequenceFlow.getName(), labelGraphicInfo, false);
            } else if (gi != null && !gi.isEmpty()){
                processDiagramCanvas.drawLabel(sequenceFlow.getName(), gi.get(0), false);
            }
You view Sequences Names
But I'm not sure that this will be the right decision

Re: How to Name Sequence Flow and make them visible on generated diagram

frederikherema1 — Mon, 11 Aug 2014 07:19:00 GMT

shar, thanks for your insight. If one of you could perhaps create a pull-request for this, that would be great