topic Re: SelectUsersPopupWindow searchPeople should not put % around the name in Alfresco Archive

SelectUsersPopupWindow searchPeople should not put % around the name

olegpavliv — Thu, 23 Jul 2015 09:02:41 GMT

SelectUsersPopupWindow searchPeople() puts percent % around the name. Maybe it was done to do a search in a DB table. But it is used in the LDAP search in activity-webapp-explorer. After inserting the % symbol the search result is empty in LDAP. Here is a correct version of searchPeople() method pr

Re: SelectUsersPopupWindow searchPeople should not put % around the name

jbarrez — Thu, 23 Jul 2015 09:53:11 GMT

Is this fixed by https://github.com/Activiti/Activiti/pull/581 ? Or is this something else?

Re: SelectUsersPopupWindow searchPeople should not put % around the name

olegpavliv — Thu, 23 Jul 2015 10:05:53 GMT

Yes, it seems to be the same issue. But it is not fixed yet on master.

https://github.com/Activiti/Activiti/blob/master/modules/activiti-explorer/src/main/java/org/activiti/explorer/ui/custom/SelectUsersPopupWindow.java

Re: SelectUsersPopupWindow searchPeople should not put % around the name

jbarrez — Tue, 28 Jul 2015 11:26:56 GMT

No, it is fixed by this line in the LdapUserManager:

final String fullNameLike = query.getFullNameLike().replaceAll("%", "");

Re: SelectUsersPopupWindow searchPeople should not put % around the name

olegpavliv — Tue, 28 Jul 2015 12:16:12 GMT

OK, I see.

It's a bit strange of fix: add percent characters around the name to replace them later.
Imagine that I have a percent character in the name. Then it won't be possible to find this entity because % will be removed.