topic LDAP check email is null in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/ldap-check-email-is-null/m-p/191416#M144546 <HTML><HEAD></HEAD><BODY><SPAN>In LDAPUserManager.java&nbsp;&nbsp; mapSearchResultToUser() verifies that the query result returned First and Last user names. In case of NullPointerException it sets the correspondent value to the empty string. </SPAN><BR /><BR /><SPAN>The same verification should be done for email. Otherwise if a result entry does not have email then the NullPointerException is ignored and the application behavior is incorrect.</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp; protected void mapSearchResultToUser( SearchResult result, UserEntity user) throws NamingException {<BR />&nbsp;&nbsp;&nbsp; if (ldapConfigurator.getUserIdAttribute() != null) {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; user.setId(result.getAttributes().get(ldapConfigurator.getUserIdAttribute()).get().toString());<BR />&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; if (ldapConfigurator.getUserFirstNameAttribute() != null) {<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;try{<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;user.setFirstName(result.getAttributes().get(ldapConfigurator.getUserFirstNameAttribute()).get().toString());<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}catch(NullPointerException e){<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;user.setFirstName("");<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}<BR />&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; if (ldapConfigurator.getUserLastNameAttribute() != null) {<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;try{<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;user.setLastName(result.getAttributes().get(ldapConfigurator.getUserLastNameAttribute()).get().toString());<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}catch(NullPointerException e){<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;user.setLastName("");<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}<BR />&nbsp;&nbsp;&nbsp; }<BR />&nbsp;&nbsp;&nbsp; if (ldapConfigurator.getUserEmailAttribute() != null) {<BR />&nbsp;&nbsp;&nbsp;&nbsp; // here we need to catch NullPointerException as well<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;try {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; user.setEmail(result.getAttributes().get(ldapConfigurator.getUserEmailAttribute()).get().toString());<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}catch(NullPointerException e){<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;user.setEmail("");<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;}<BR />&nbsp;&nbsp;&nbsp; }<BR />&nbsp; }<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE></BODY></HTML> Thu, 23 Jul 2015 07:45:02 GMT olegpavliv 2015-07-23T07:45:02Z LDAP check email is null https://connect.hyland.com/t5/alfresco-archive/ldap-check-email-is-null/m-p/191416#M144546 In LDAPUserManager.java&nbsp;&nbsp; mapSearchResultToUser() verifies that the query result returned First and Last user names. In case of NullPointerException it sets the correspondent value to the empty string. The same verification should be done for email. Otherwise if a result entry does not have email th Thu, 23 Jul 2015 07:45:02 GMT https://connect.hyland.com/t5/alfresco-archive/ldap-check-email-is-null/m-p/191416#M144546 olegpavliv 2015-07-23T07:45:02Z Re: LDAP check email is null https://connect.hyland.com/t5/alfresco-archive/ldap-check-email-is-null/m-p/191417#M144547 <HTML><HEAD></HEAD><BODY><SPAN>This is already fixed on master: </SPAN><A href="https://github.com/Activiti/Activiti/blame/master/modules/activiti-ldap/src/main/java/org/activiti/ldap/LDAPUserManager.java#L184" rel="nofollow noopener noreferrer">https://github.com/Activiti/Activiti/blame/master/modules/activiti-ldap/src/main/java/org/activiti/ldap/LDAPUserManager.java#L184</A></BODY></HTML> Thu, 23 Jul 2015 09:49:55 GMT https://connect.hyland.com/t5/alfresco-archive/ldap-check-email-is-null/m-p/191417#M144547 jbarrez 2015-07-23T09:49:55Z