topic Re: Loss of ID when converting BpmnToJson in Alfresco Archive

Loss of ID when converting BpmnToJson

eee — Fri, 09 Oct 2015 07:21:34 GMT

Hello, I'm trying to convert Bpmn model (bpmn20.xml) to Json format for a new editor. There are problems with conversion values in "formProperty".Example source text:…<formProperty id="priority" name="уровень срочности:" required="false" type="enum" variable="priority" writable="false"> <

Re: Loss of ID when converting BpmnToJson

jbarrez — Tue, 13 Oct 2015 10:39:21 GMT

You've pretty much have the whole bug analysed and already proposed a fix 🙂
Would you be willing to submit a pull request with these code changes?

Re: Loss of ID when converting BpmnToJson

kotslon — Fri, 23 Oct 2015 07:26:05 GMT

https://github.com/Activiti/Activiti/pull/698

Re: Loss of ID when converting BpmnToJson

vasile_dirla — Mon, 26 Oct 2015 08:59:42 GMT

@kotslon, thanks for your contribution.
would be great if you could add also some tests for your changes.

Your PR will be reviewed and merged as soon as possible.

Re: Loss of ID when converting BpmnToJson

kotslon — Mon, 26 Oct 2015 12:27:04 GMT

It's strange: existing tests don't fail, because here: https://github.com/Activiti/Activiti/blob/master/modules/activiti-json-converter/src/test/java/org/activiti/editor/language/FormPropertiesConverterTest.java#L58 `userTask.getFormProperties()` always gives an empty list.

Re: Loss of ID when converting BpmnToJson

vasile_dirla — Mon, 26 Oct 2015 13:37:34 GMT

Hmm yes, as you said: userTask.getFormProperties() is always empty then the "for" block is skipped every time.
We have to review and fix this test, it must have a check for the formPropertyList length before iterating through the list.

Thanks for rising this flag, it seems the test must be improved.

Re: Loss of ID when converting BpmnToJson

kotslon — Tue, 27 Oct 2015 06:44:52 GMT

https://github.com/Activiti/Activiti/pull/703

1. Fix enum values in editor and converter:
    * `id` and `name` instead of single `value`.
2. Fix form properties test:
    * check the size of form properties list
    * use json instead of string for `formproperties` in test fixture file `test.formpropertiesmodel.json`
    * `id` and `name` of `enumValues` are changed to be different.

Re: Loss of ID when converting BpmnToJson

vasile_dirla — Tue, 27 Oct 2015 07:19:42 GMT

@kotslon,
Thanks, just had a look over your pull request, and it covers the issues I saw yesterday in this test.
nicely done!

I also have some changes for the form properties test with XML data. (when these 2 will be merged the form properties test is complete)