topic HistoryManager in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/historymanager/m-p/178737#M131867 <HTML><HEAD></HEAD><BODY><SPAN>Hi,</SPAN><BR /><SPAN>I'm using activiti 5.14 and I want to ask some questions about HistoryManager implementation..</SPAN><BR /><BR /><SPAN>1- HistoryManager implementation is different from manual (activity vs audit).</SPAN><BR /><SPAN>1.a) Although it says controlling ACTIVITY level, implementation controls ACTIVITY, as:</SPAN><BR /><SPAN>&nbsp; /**</SPAN><BR /><SPAN>&nbsp;&nbsp; * Record a variable has been updated, if audit history is enabled.&nbsp; //////////////// says AUDIT</SPAN><BR /><SPAN>&nbsp;&nbsp; */</SPAN><BR /><SPAN>&nbsp; public void recordVariableUpdate(VariableInstanceEntity variable) {</SPAN><BR /><SPAN>&nbsp;&nbsp;&nbsp; if (isHistoryLevelAtLeast(HistoryLevel.ACTIVITY)) { … }&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; //////////////// controls ACTIVITY </SPAN><BR /><SPAN>&nbsp; }</SPAN><BR /><BR /><SPAN>&nbsp; /**</SPAN><BR /><SPAN>&nbsp;&nbsp; * Record a variable has been created, if audit history is enabled.&nbsp;&nbsp;&nbsp; //////////////// says AUDIT</SPAN><BR /><SPAN>&nbsp;&nbsp; */</SPAN><BR /><SPAN>&nbsp; public void recordVariableCreate(VariableInstanceEntity variable) { //////////////// controls ACTIVITY </SPAN><BR /><SPAN>&nbsp;&nbsp;&nbsp; // Historic variables</SPAN><BR /><SPAN>&nbsp;&nbsp;&nbsp; if (isHistoryLevelAtLeast(HistoryLevel.ACTIVITY)) { … }</SPAN><BR /><SPAN>&nbsp; }</SPAN><BR /><BR /><SPAN>1.b) Variables are kept sync in AUDIT according to the manual, but in implementation, over ACTIVITY level (includes ACTIVITY) variables are kept sync. I think in ACTIVITIY level, variables should be kept only for initial and the last time, not always..</SPAN><BR /><BR /><SPAN>3- In ExecutionEntity.newExecution(), there is an insert statement but insert() method is not used. This reduces code readability, and hard to find insert statements.</SPAN><BR /><BR /><SPAN>4- I couldn't see any DAO structure. All cruds (especially inserts) are defined over context as:</SPAN><BR /><SPAN>Context.getCommandContext()……insert(obj);</SPAN><BR /><SPAN>This makes hard to understand and hard to maintain. Why ?</SPAN><BR /><BR /><SPAN>Thanks..</SPAN></BODY></HTML> Tue, 10 Mar 2015 13:52:22 GMT baivs 2015-03-10T13:52:22Z HistoryManager https://connect.hyland.com/t5/alfresco-archive/historymanager/m-p/178737#M131867 Hi,I'm using activiti 5.14 and I want to ask some questions about HistoryManager implementation..1- HistoryManager implementation is different from manual (activity vs audit).1.a) Although it says controlling ACTIVITY level, implementation controls ACTIVITY, as:&nbsp; /**&nbsp;&nbsp; * Record a variable has been u Tue, 10 Mar 2015 13:52:22 GMT https://connect.hyland.com/t5/alfresco-archive/historymanager/m-p/178737#M131867 baivs 2015-03-10T13:52:22Z Re: HistoryManager https://connect.hyland.com/t5/alfresco-archive/historymanager/m-p/178738#M131868 <HTML><HEAD></HEAD><BODY><SPAN>1)b) I see that the docs are wrong there. But we can't change that now, that would break too many installations.</SPAN><BR /><BR /><SPAN>3) Why do you believe it is not used? The way I read it, it is used.</SPAN><BR /><BR /><SPAN>4) Why would DAO be the best way forward? Cause it used to be a best practice in the get-as-many-layers-as-possible-java? Activiti has to cater for many different environments and the current architecture is an evolution reflecting that. I'm not saying you're wrong, I'm just saying that Activiti is 5 years old and has been used in many (many!) different environments and has grown like that because of it.</SPAN></BODY></HTML> Tue, 17 Mar 2015 08:36:43 GMT https://connect.hyland.com/t5/alfresco-archive/historymanager/m-p/178738#M131868 jbarrez 2015-03-17T08:36:43Z