Activiti designer 5.14 removes custom form property information

k0k0pelli — Sun, 26 Jan 2014 16:18:13 GMT

Hi!We implemented an extension for the activiti engine which allows us to use the form mechanism of activiti together with our own custom form property fields. We are using activiti:value inside a activiti:formProperty xml element to specify additional form information, such as column and row inform

Re: Activiti designer 5.14 removes custom form property information

frederikherema1 — Mon, 27 Jan 2014 08:47:53 GMT

So the "activiti:value" elements are removed? I guess that can be considered as a bug, can you create a JIRA-issue for this?

Re: Activiti designer 5.14 removes custom form property information

k0k0pelli — Mon, 27 Jan 2014 09:01:50 GMT

Yes, the activiti:value elements are removed. I will create a JIRA issue.

Re: Activiti designer 5.14 removes custom form property information

frederikherema1 — Thu, 30 Jan 2014 09:23:42 GMT

Thanks!

Re: Activiti designer 5.14 removes custom form property information

wojtek — Wed, 12 Feb 2014 09:38:14 GMT

Hi!
I have the same problem (it is quiet anoying). Could you inform me in case of solution (I do not have a JIRA account ) ?
Regards
Wojtek

Re: Activiti designer 5.14 removes custom form property information

chearius — Mon, 08 Dec 2014 15:27:42 GMT

Hi,

the problem is in the class org.activiti.engine.impl.form.FormTypes. In case of enum or date, new instance of a subclass of org.activiti.engine.form.AbstractFormType is created and only for this instance the value of datePattern or activiti:value elements respectively is passed to the newly created instance. All other form types (including custom ones) won't get any of these values!

As a workaround you can create a subclass of org.activiti.engine.impl.form.FormTypes and set the values in your custom form type. Here is an example:

activiti-standalone-context.xml
<code>
 <bean id="activitiFormTypes" class="ActivitiFormTypes">
 <property name="activitiFormTypes">
 <list>
 <bean class="org.activiti.engine.impl.form.BooleanFormType" />
 <bean class="org.activiti.engine.impl.form.DateFormType">
 <constructor-arg index="0" value="dd/MM/yyyy" />
 </bean>
 <bean class="org.activiti.engine.impl.form.DoubleFormType" />
 <bean class="org.activiti.engine.impl.form.LongFormType" />
 <bean class="org.activiti.engine.impl.form.StringFormType" />

 <bean class="CustomCheckboxFormPropertyType" />
 <bean class="CustomTextboxFormPropertyType" />
 </list>
 </property>
 </bean>
 <bean id="processEngineConfiguration" class="org.activiti.spring.SpringProcessEngineConfiguration">
 <property name="dataSource" ref="dataSource" />
 <property name="transactionManager" ref="transactionManager" />
 <property name="databaseSchemaUpdate" value="true" />
 <property name="jobExecutorActivate" value="true" />
 <property name="enableDatabaseEventLogging" value="true" />
 <property name="formTypes" ref="activitiFormTypes" />
 </bean>
</code>
ActivitiFormTypes.java
<java>
public class ActivitiFormTypes extends FormTypes implements InitializingBean {

 private List<AbstractFormType> activitiFormTypes;

 @Override
 public void addFormType(AbstractFormType formType) {
 super.addFormType(formType);
 }

 @Override
 public void afterPropertiesSet() throws Exception {
 for (AbstractFormType type : activitiFormTypes) {
 super.addFormType(type);
 }
 }

 public List<AbstractFormType> getActivitiFormTypes() {
 return activitiFormTypes;
 }

 @Override
 public AbstractFormType parseFormPropertyType(FormProperty formProperty) {
 if (formTypes.containsKey(formProperty.getType()) && formTypes.get(formProperty.getType()) instanceof AbstractActivitiFormType) {
 AbstractActivitiFormType abstractFormType = (AbstractActivitiFormType) formTypes.get(formProperty.getType());
 AbstractActivitiFormType clone = abstractFormType.cloneFormType();
 clone.setFormProperty(formProperty);

 return clone;

 } else {
 return super.parseFormPropertyType(formProperty);
 }
 }

 public void setActivitiFormTypes(List<AbstractFormType> activitiFormTypes) {
 this.activitiFormTypes = activitiFormTypes;
 }
}
</java>
AbstractActivitiFormType.java
<java>
public abstract class AbstractActivitiFormType extends AbstractFormType {

 protected FormProperty formProperty;

 protected Map<String, FormValue> formValues;

 public abstract AbstractActivitiFormType cloneFormType();

 public FormProperty getFormProperty() {
 return formProperty;
 }

 public FormValue getValue(String id) {
 return formValues.get(id);
 }

 public Collection<FormValue> getValues() {
 return formValues.values();
 }

 public void setFormProperty(FormProperty formProperty) {
 this.formProperty = formProperty;
 setValues(formProperty.getFormValues());
 }

 protected void setValues(Collection<FormValue> values){
 formValues = new LinkedHashMap<>();

 for (FormValue value : values) {
 formValues.put(value.getId(), value);
 }
 }
}
</java>

Your custom form types (like CustomTextboxFormPropertyType or CustomCheckboxFormPropertyType) will be subclasses of the new abstract class AbstractActivitiFormType. The cloneFormType method should just create a new instance of the custom form type.


Please note, that you have to register standard Activiti Form Types yourself if you want to user them. They wont get registered by the org.activiti.engine.impl.cfg.ProcessEngineConfigurationImpl bean (or its subclasses).


This solution is not as clean as it could be but it works. I'd suggest that a new element (like activiti:fieldProperty) should be defined for form properties in order to make custom form property types configurable from within the process definition. If I find some time and ifthere is an interest in this feature, I'll create a patch.


Best Regards, 
chearius

topic Re: Activiti designer 5.14 removes custom form property information in Alfresco Archive

Activiti designer 5.14 removes custom form property information

Re: Activiti designer 5.14 removes custom form property information

Re: Activiti designer 5.14 removes custom form property information

Re: Activiti designer 5.14 removes custom form property information

Re: Activiti designer 5.14 removes custom form property information

Re: Activiti designer 5.14 removes custom form property information