topic Unable to advice routes holding activiti consumers in Alfresco Archive https://connect.hyland.com/t5/alfresco-archive/unable-to-advice-routes-holding-activiti-consumers/m-p/165569#M119240 <HTML><HEAD></HEAD><BODY><SPAN>Hi there,</SPAN><BR /><BR /><SPAN>I'm new to Activiti, evaluating it as a potential replacement solution for our BPM engine.&nbsp; </SPAN><BR /><SPAN>While checking some use cases I've hit a problem trying to write a test case that tries to advice a camel route with an activiti consumer. The environment was:</SPAN><BR /><SPAN>- Activiti 5.14</SPAN><BR /><SPAN>- Camel 2.11</SPAN><BR /><SPAN>- JDK 1.6</SPAN><BR /><SPAN>- Test case using a spring context, declaring a camel context to scan a package for routes.</SPAN><BR /><BR /><SPAN>The issue seems to be related to this sequence of operations:</SPAN><BR /><SPAN>- The spring context is setup, creating the camel context, which sets up the discovered routes.</SPAN><BR /><SPAN>- The test case is started, and the camel context is instructed to advice the route</SPAN><BR /><SPAN>- The camel context tries to refresh the route, to perform the required modifications</SPAN><BR /><SPAN>- Starting the route again, throws the following exception:</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR />java.lang.RuntimeException: Activit consumer already defined for activiti://TestProcess:sender!<BR />&nbsp;&nbsp;&nbsp;at org.activiti.camel.ActivitiEndpoint.addConsumer(ActivitiEndpoint.java:60)<BR />&nbsp;&nbsp;&nbsp;at org.activiti.camel.ActivitiConsumer.doStart(ActivitiConsumer.java:27)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.support.ServiceSupport.start(ServiceSupport.java:61)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.startService(DefaultCamelContext.java:1803)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.doStartOrResumeRouteConsumers(DefaultCamelContext.java:2097)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.doStartRouteConsumers(DefaultCamelContext.java:2033)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.safelyStartRouteServices(DefaultCamelContext.java:1963)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.safelyStartRouteServices(DefaultCamelContext.java:1976)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.startRouteService(DefaultCamelContext.java:1853)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.impl.DefaultCamelContext.startRoute(DefaultCamelContext.java:752)<BR />&nbsp;&nbsp;&nbsp;at org.apache.camel.model.RouteDefinition.adviceWith(RouteDefinition.java:278)<BR />&nbsp;&nbsp;&nbsp;at camel.test.AdviceActivitiConsumerRouteTest.testAdviceOnActivitiRoute(AdviceActivitiConsumerRouteTest.java:21)<BR />…<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>Checking the code in activiti-camel, I understand that on start, the ActivitiConsumer sets himself as the consumer for the ActivitiEndpoint. However, no overloading of the doStop() method is made, and so, a stop/start sequence on the consumer leads to the Endpoint throwing that exception since a consumer is already setup. </SPAN><BR /><BR /><SPAN>In my understanding, this prevents a route with an activiti consumer to be restarted and hence, to be adviced in case it was already started. I've tried a little modifications to the ActivitiConsumer to override doStop() and remove the consumer from the endpoint, and it seems to work properly. I'm adding below some analysis on the issue I've made, to your consideration (and also the patch).</SPAN><BR /><BR /><SPAN>Should I open a Jira issue for this or could be something related to a bad usage from my side?</SPAN><BR /><BR /><SPAN>Best regards,</SPAN><BR /><BR /><SPAN>Manuel.</SPAN><BR /><BR /><BR /><SPAN>Following a simple test case to prove it (it throws the aforementioned exception)</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR />@RunWith(SpringJUnit4ClassRunner.class)<BR />@ContextConfiguration("classpath:/activiti-camel-test.xml")<BR />public class AdviceActivitiConsumerRouteTest {<BR />&nbsp;&nbsp;&nbsp;<BR />&nbsp;&nbsp;&nbsp;@Autowired<BR />&nbsp;&nbsp;&nbsp;private ModelCamelContext camelContext;<BR />&nbsp;&nbsp;&nbsp;<BR />&nbsp;&nbsp;&nbsp; @Test<BR />&nbsp;&nbsp;&nbsp; public void testAdviceOnActivitiRoute() throws Exception {<BR /><BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;camelContext.getRouteDefinitions().get(0).adviceWith(camelContext, <BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;new AdviceWithRouteBuilder() {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;@Override<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;public void configure() throws Exception {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;intercept().to("mock:foo");<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;});<BR />&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;<BR />&nbsp;&nbsp;&nbsp; }<BR />}<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>Where the route is anything holding an activiti consumer, like:</SPAN><BR /><BR /><PRE class="language-none line-numbers"><CODE><BR />public class CamelTestRoute extends RouteBuilder {<BR /><BR />&nbsp;&nbsp;&nbsp;@Override<BR />&nbsp;&nbsp;&nbsp;public void configure() throws Exception {<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;from("activiti:TestProcess:sender")<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;.to("log:test");<BR />&nbsp;&nbsp;&nbsp;}<BR />}<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><SPAN>The spring context has nothing special other than the standard configuration. Only a camel context to scan a given package for routes:</SPAN><BR /><PRE class="language-none line-numbers"><CODE><BR />&nbsp;&nbsp;&nbsp;&lt;camelContext id="camelContext" xmlns="<A href="http://camel.apache.org/schema/spring" rel="nofollow noopener noreferrer">http://camel.apache.org/schema/spring</A>"&gt;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;packageScan&gt;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;package&gt;camel.test.route&lt;/package&gt;<BR />&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&lt;/packageScan&gt;<BR />&nbsp;&nbsp;&nbsp;&lt;/camelContext&gt;<BR /><SPAN class="line-numbers-rows"><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN><SPAN>‍</SPAN></SPAN></CODE></PRE><BR /><BR /><BR /></BODY></HTML> Thu, 27 Mar 2014 09:46:31 GMT mteira 2014-03-27T09:46:31Z Unable to advice routes holding activiti consumers https://connect.hyland.com/t5/alfresco-archive/unable-to-advice-routes-holding-activiti-consumers/m-p/165569#M119240 Hi there,I'm new to Activiti, evaluating it as a potential replacement solution for our BPM engine.&nbsp; While checking some use cases I've hit a problem trying to write a test case that tries to advice a camel route with an activiti consumer. The environment was:- Activiti 5.14- Camel 2.11- JDK 1.6- Te Thu, 27 Mar 2014 09:46:31 GMT https://connect.hyland.com/t5/alfresco-archive/unable-to-advice-routes-holding-activiti-consumers/m-p/165569#M119240 mteira 2014-03-27T09:46:31Z Re: Unable to advice routes holding activiti consumers https://connect.hyland.com/t5/alfresco-archive/unable-to-advice-routes-holding-activiti-consumers/m-p/165570#M119241 <HTML><HEAD></HEAD><BODY><SPAN>Hello again,</SPAN><BR /><BR /><SPAN>I've opened ticket </SPAN><A href="http://jira.codehaus.org/browse/ACT-1988" rel="nofollow noopener noreferrer">http://jira.codehaus.org/browse/ACT-1988</A><SPAN> for this issue.</SPAN><BR /><BR /><SPAN>Best regards,</SPAN><BR /><BR /><SPAN>Manuel</SPAN></BODY></HTML> Wed, 23 Apr 2014 08:16:13 GMT https://connect.hyland.com/t5/alfresco-archive/unable-to-advice-routes-holding-activiti-consumers/m-p/165570#M119241 mteira 2014-04-23T08:16:13Z