topic Re: Bug in TaskQuery.taskCandidateOrAssigned? in Alfresco Archive

Bug in TaskQuery.taskCandidateOrAssigned?

xman-berlin — Wed, 30 Apr 2014 06:33:54 GMT

Hi all,after a discussion (http://forums.activiti.org/content/howto-get-both-assigned-tasks-and-tasks-where-use-candidate-one-call) about getting both assigned tasks and tasks being candidates in one call, I would like to discuss whether or not the function is buggy. Here's the scenariotart proces

Re: Bug in TaskQuery.taskCandidateOrAssigned?

martin_grofcik — Wed, 30 Apr 2014 06:56:51 GMT

I attached jUnit test patch. I think it can be done by intention too.

Re: Bug in TaskQuery.taskCandidateOrAssigned?

xman-berlin — Fri, 02 May 2014 13:12:22 GMT

Hi Martin,

what do you mean with "it can be done by intention too". Do you think this is a bug or not?

I still consider this a bug because the query should return tasks that can be claimed by candidates or are already claimed by the assignee.

Thanks,
Torsten

Re: Bug in TaskQuery.taskCandidateOrAssigned?

martin_grofcik — Mon, 05 May 2014 07:47:54 GMT

Hi Thorsten,

I think it is not a bug. (Let somebody from activiti core team to decide).
Regards
Martin

Re: Bug in TaskQuery.taskCandidateOrAssigned?

jbarrez — Tue, 27 May 2014 07:12:37 GMT

This is not a bug. Activiti never does security checks on queries - this is for every query the case, not only for tasks. This should be done in the layer above.
This is intentional, in that we do not want to force any company in a model they don't want.

Re: Bug in TaskQuery.taskCandidateOrAssigned?

andrei_akatsyeu — Thu, 17 Jul 2014 13:13:54 GMT

Hi,
I 've a question.

user1 is assignee on task1
user2 is candidate on task1
user3 is membership of group1 and group1 is candidate on task1
taskService.createTaskQuery().taskCandidateOrAssigned("user1") return task1
taskService.createTaskQuery().taskCandidateOrAssigned("user2") return empty list
taskService.createTaskQuery().taskCandidateOrAssigned("user3") return task1

I think point six is like a bug.
Should "taskService.createTaskQuery().taskCandidateOrAssigned("user3")" statement return empty list in this situation?

This is the SQL query which is used to retrieve the task list. <code lang="sql">
<when test="bothCandidateAndAssigned">
          <if test="userIdForCandidateAndAssignee != null">
            and (RES.ASSIGNEE_ = #{userIdForCandidateAndAssignee} or (RES.ASSIGNEE_ is null and I.USER_ID_ = #{userIdForCandidateAndAssignee} or I.GROUP_ID_ IN (select g.GROUP_ID_ from ACT_ID_MEMBERSHIP g where g.USER_ID_ = #{userIdForCandidateAndAssignee} ) ) )
          </if>
        </when>
</code>I think, the query is missing the limitation to "RES.ASSIGNEE_ is null" when testing the user groups, e.g.:<code lang="sql">
<when test="bothCandidateAndAssigned">
          <if test="userIdForCandidateAndAssignee != null">
            and (RES.ASSIGNEE_ = #{userIdForCandidateAndAssignee} or (RES.ASSIGNEE_ is null and I.USER_ID_ = #{userIdForCandidateAndAssignee} or (RES.ASSIGNEE_ is null and I.GROUP_ID_ IN (select g.GROUP_ID_ from ACT_ID_MEMBERSHIP g where g.USER_ID_ = #{userIdForCandidateAndAssignee} ) ) ) )
          </if>
        </when>
</code>

Re: Bug in TaskQuery.taskCandidateOrAssigned?

trademak — Mon, 21 Jul 2014 10:09:10 GMT

You are correct, fixed it. Could you please retest it?

Best regards,